Commit 4bddb1ab authored by William Jon McCann's avatar William Jon McCann Committed by William Jon McCann

Fix a bunch of compiler warnings and remove unused code. Patch from:

2008-02-19  William Jon McCann  <jmccann@redhat.com>

	* common/gdm-settings-client.c:
	(gdm_settings_client_get_locale_string),
	(gdm_settings_client_init):
	* common/gdm-settings-desktop-backend.c: (save_settings):
	* common/gdm-settings-direct.c: (gdm_settings_direct_init):
	* common/test-log.c: (test_log):
	* common/test-settings-client.c: (test_settings_client):
	* daemon/gdm-chooser-server.c: (gdm_chooser_server_constructor):
	* daemon/gdm-chooser-session.c: (gdm_chooser_session_set_property),
	(gdm_chooser_session_get_property),
	(gdm_chooser_session_constructor):
	* daemon/gdm-display-access-file.c:
	* daemon/gdm-display.c: (_create_access_file_for_user),
	(gdm_display_constructor):
	* daemon/gdm-factory-slave.c: (gdm_factory_slave_start),
	(gdm_factory_slave_stop), (gdm_factory_slave_set_property),
	(gdm_factory_slave_get_property), (gdm_factory_slave_constructor):
	* daemon/gdm-greeter-server.c: (gdm_greeter_server_constructor):
	* daemon/gdm-greeter-session.c: (gdm_greeter_session_set_property),
	(gdm_greeter_session_get_property):
	* daemon/gdm-local-display-factory.c:
	(gdm_local_display_factory_set_property),
	(gdm_local_display_factory_get_property),
	(gdm_local_display_factory_constructor):
	* daemon/gdm-manager.c: (gdm_manager_constructor):
	* daemon/gdm-product-display.c: (gdm_product_display_constructor):
	* daemon/gdm-product-slave.c: (gdm_product_slave_start),
	(gdm_product_slave_stop), (gdm_product_slave_set_property),
	(gdm_product_slave_get_property), (gdm_product_slave_constructor):
	* daemon/gdm-server.c: (gdm_server_constructor):
	* daemon/gdm-session-auditor.c:
	* daemon/gdm-session-direct.c: (gdm_session_direct_open):
	* daemon/gdm-session-linux-auditor.c:
	* daemon/gdm-session-relay.c: (gdm_session_relay_set_property),
	(gdm_session_relay_get_property), (gdm_session_relay_constructor):
	* daemon/gdm-session-settings.c:
	* daemon/gdm-session-worker-job.c:
	(gdm_session_worker_job_constructor):
	* daemon/gdm-session-worker.c: (gdm_session_worker_constructor):
	* daemon/gdm-simple-slave.c: (gdm_simple_slave_start),
	(gdm_simple_slave_stop), (gdm_simple_slave_set_property),
	(gdm_simple_slave_get_property), (gdm_simple_slave_constructor):
	* daemon/gdm-slave.c: (gdm_slave_run_script),
	(_get_primary_user_session_id), (gdm_slave_constructor):
	* daemon/gdm-static-display.c: (gdm_static_display_set_property),
	(gdm_static_display_get_property):
	* daemon/gdm-static-factory-display.c:
	(gdm_static_factory_display_set_property),
	(gdm_static_factory_display_get_property),
	(gdm_static_factory_display_constructor):
	* daemon/gdm-transient-display.c:
	(gdm_transient_display_set_property),
	(gdm_transient_display_get_property):
	* daemon/gdm-welcome-session.c: (parse_dbus_launch_output),
	(gdm_welcome_session_constructor):
	* daemon/gdm-xdmcp-chooser-slave.c:
	(gdm_xdmcp_chooser_slave_start), (gdm_xdmcp_chooser_slave_stop),
	(gdm_xdmcp_chooser_slave_set_property),
	(gdm_xdmcp_chooser_slave_get_property),
	(gdm_xdmcp_chooser_slave_constructor):
	* daemon/gdm-xdmcp-display-factory.c: (do_bind),
	(indirect_client_create), (gdm_xdmcp_handle_forward_query):
	* daemon/test-session.c: (main):
	* gui/simple-chooser/gdm-chooser-client.c:
	(gdm_chooser_client_set_property),
	(gdm_chooser_client_get_property),
	(gdm_chooser_client_constructor), (gdm_chooser_client_dispose):
	* gui/simple-chooser/gdm-chooser-session.c:
	(gdm_chooser_session_set_property),
	(gdm_chooser_session_get_property),
	(gdm_chooser_session_constructor), (gdm_chooser_session_dispose):
	* gui/simple-chooser/gdm-host-chooser-dialog.c:
	(gdm_host_chooser_dialog_set_property),
	(gdm_host_chooser_dialog_get_property),
	(gdm_host_chooser_dialog_constructor),
	(gdm_host_chooser_dialog_dispose):
	* gui/simple-chooser/gdm-host-chooser-widget.c:
	(gdm_host_chooser_widget_set_property),
	(gdm_host_chooser_widget_get_property),
	(gdm_host_chooser_widget_constructor):
	* gui/simple-greeter/gdm-a11y-preferences-dialog.c:
	(gdm_a11y_preferences_dialog_set_property),
	(gdm_a11y_preferences_dialog_get_property),
	(gdm_a11y_preferences_dialog_constructor),
	(gdm_a11y_preferences_dialog_dispose):
	* gui/simple-greeter/gdm-chooser-widget.c:
	(shrink_edge_toward_active_row), (gdm_chooser_widget_constructor):
	* gui/simple-greeter/gdm-greeter-client.c:
	(gdm_greeter_client_set_property),
	(gdm_greeter_client_get_property),
	(gdm_greeter_client_constructor), (gdm_greeter_client_dispose):
	* gui/simple-greeter/gdm-greeter-login-window.c:
	(gdm_greeter_login_window_constructor):
	* gui/simple-greeter/gdm-greeter-panel.c:
	(gdm_greeter_panel_set_property), (gdm_greeter_panel_get_property),
	(gdm_greeter_panel_constructor), (gdm_greeter_panel_dispose):
	* gui/simple-greeter/gdm-greeter-session.c:
	(gdm_greeter_session_set_property),
	(gdm_greeter_session_get_property),
	(gdm_greeter_session_constructor), (gdm_greeter_session_dispose):
	* gui/simple-greeter/gdm-language-chooser-widget.c:
	(gdm_language_chooser_widget_dispose):
	* gui/simple-greeter/gdm-option-widget.c: (activate_from_item_id),
	(gdm_option_widget_constructor):
	* gui/simple-greeter/gdm-recent-option-widget.c:
	(gdm_recent_option_widget_dispose):
	* gui/simple-greeter/gdm-remote-login-window.c:
	(gdm_remote_login_window_set_property),
	(gdm_remote_login_window_get_property),
	(gdm_remote_login_window_constructor):
	* gui/simple-greeter/gdm-session-client.c:
	(gdm_session_client_constructor), (gdm_session_client_dispose):
	* gui/simple-greeter/gdm-session-manager.c:
	(gdm_session_manager_set_property),
	(gdm_session_manager_get_property),
	(gdm_session_manager_constructor), (gdm_session_manager_dispose):
	* gui/simple-greeter/gdm-user-chooser-dialog.c:
	(gdm_user_chooser_dialog_set_property),
	(gdm_user_chooser_dialog_get_property),
	(gdm_user_chooser_dialog_constructor),
	(gdm_user_chooser_dialog_dispose):
	* gui/simple-greeter/gdm-user-chooser-widget.c:
	(gdm_user_chooser_widget_set_property),
	(gdm_user_chooser_widget_get_property),
	(gdm_user_chooser_widget_constructor):
	* gui/simple-greeter/gdm-user-manager.c:
	(_get_primary_user_session_id), (_get_login_window_session_id):
	* gui/simple-greeter/gdm-user.c:
	* gui/simple-greeter/libnotificationarea/na-tray-manager.c:
	(na_tray_manager_handle_begin_message):
	* gui/simple-greeter/libnotificationarea/na-tray.c:
	* gui/user-switch-applet/applet.c: (prefs_cb),
	(switch_to_user_session), (display_key_changed), (applet_fill_cb):
	* gui/user-switch-applet/gdm-user-menu-item.c:
	* tests/s-common-address.c: (START_TEST):
	* utils/gdmflexiserver.c: (get_login_window_session_id):
	Fix a bunch of compiler warnings and remove unused code.
	Patch from: Kjartan Maraas <kmaraas@broadpark.no>


svn path=/trunk/; revision=5800
parent 6434eb5a
2008-02-19 William Jon McCann <jmccann@redhat.com>
* common/gdm-settings-client.c:
(gdm_settings_client_get_locale_string),
(gdm_settings_client_init):
* common/gdm-settings-desktop-backend.c: (save_settings):
* common/gdm-settings-direct.c: (gdm_settings_direct_init):
* common/test-log.c: (test_log):
* common/test-settings-client.c: (test_settings_client):
* daemon/gdm-chooser-server.c: (gdm_chooser_server_constructor):
* daemon/gdm-chooser-session.c: (gdm_chooser_session_set_property),
(gdm_chooser_session_get_property),
(gdm_chooser_session_constructor):
* daemon/gdm-display-access-file.c:
* daemon/gdm-display.c: (_create_access_file_for_user),
(gdm_display_constructor):
* daemon/gdm-factory-slave.c: (gdm_factory_slave_start),
(gdm_factory_slave_stop), (gdm_factory_slave_set_property),
(gdm_factory_slave_get_property), (gdm_factory_slave_constructor):
* daemon/gdm-greeter-server.c: (gdm_greeter_server_constructor):
* daemon/gdm-greeter-session.c: (gdm_greeter_session_set_property),
(gdm_greeter_session_get_property):
* daemon/gdm-local-display-factory.c:
(gdm_local_display_factory_set_property),
(gdm_local_display_factory_get_property),
(gdm_local_display_factory_constructor):
* daemon/gdm-manager.c: (gdm_manager_constructor):
* daemon/gdm-product-display.c: (gdm_product_display_constructor):
* daemon/gdm-product-slave.c: (gdm_product_slave_start),
(gdm_product_slave_stop), (gdm_product_slave_set_property),
(gdm_product_slave_get_property), (gdm_product_slave_constructor):
* daemon/gdm-server.c: (gdm_server_constructor):
* daemon/gdm-session-auditor.c:
* daemon/gdm-session-direct.c: (gdm_session_direct_open):
* daemon/gdm-session-linux-auditor.c:
* daemon/gdm-session-relay.c: (gdm_session_relay_set_property),
(gdm_session_relay_get_property), (gdm_session_relay_constructor):
* daemon/gdm-session-settings.c:
* daemon/gdm-session-worker-job.c:
(gdm_session_worker_job_constructor):
* daemon/gdm-session-worker.c: (gdm_session_worker_constructor):
* daemon/gdm-simple-slave.c: (gdm_simple_slave_start),
(gdm_simple_slave_stop), (gdm_simple_slave_set_property),
(gdm_simple_slave_get_property), (gdm_simple_slave_constructor):
* daemon/gdm-slave.c: (gdm_slave_run_script),
(_get_primary_user_session_id), (gdm_slave_constructor):
* daemon/gdm-static-display.c: (gdm_static_display_set_property),
(gdm_static_display_get_property):
* daemon/gdm-static-factory-display.c:
(gdm_static_factory_display_set_property),
(gdm_static_factory_display_get_property),
(gdm_static_factory_display_constructor):
* daemon/gdm-transient-display.c:
(gdm_transient_display_set_property),
(gdm_transient_display_get_property):
* daemon/gdm-welcome-session.c: (parse_dbus_launch_output),
(gdm_welcome_session_constructor):
* daemon/gdm-xdmcp-chooser-slave.c:
(gdm_xdmcp_chooser_slave_start), (gdm_xdmcp_chooser_slave_stop),
(gdm_xdmcp_chooser_slave_set_property),
(gdm_xdmcp_chooser_slave_get_property),
(gdm_xdmcp_chooser_slave_constructor):
* daemon/gdm-xdmcp-display-factory.c: (do_bind),
(indirect_client_create), (gdm_xdmcp_handle_forward_query):
* daemon/test-session.c: (main):
* gui/simple-chooser/gdm-chooser-client.c:
(gdm_chooser_client_set_property),
(gdm_chooser_client_get_property),
(gdm_chooser_client_constructor), (gdm_chooser_client_dispose):
* gui/simple-chooser/gdm-chooser-session.c:
(gdm_chooser_session_set_property),
(gdm_chooser_session_get_property),
(gdm_chooser_session_constructor), (gdm_chooser_session_dispose):
* gui/simple-chooser/gdm-host-chooser-dialog.c:
(gdm_host_chooser_dialog_set_property),
(gdm_host_chooser_dialog_get_property),
(gdm_host_chooser_dialog_constructor),
(gdm_host_chooser_dialog_dispose):
* gui/simple-chooser/gdm-host-chooser-widget.c:
(gdm_host_chooser_widget_set_property),
(gdm_host_chooser_widget_get_property),
(gdm_host_chooser_widget_constructor):
* gui/simple-greeter/gdm-a11y-preferences-dialog.c:
(gdm_a11y_preferences_dialog_set_property),
(gdm_a11y_preferences_dialog_get_property),
(gdm_a11y_preferences_dialog_constructor),
(gdm_a11y_preferences_dialog_dispose):
* gui/simple-greeter/gdm-chooser-widget.c:
(shrink_edge_toward_active_row), (gdm_chooser_widget_constructor):
* gui/simple-greeter/gdm-greeter-client.c:
(gdm_greeter_client_set_property),
(gdm_greeter_client_get_property),
(gdm_greeter_client_constructor), (gdm_greeter_client_dispose):
* gui/simple-greeter/gdm-greeter-login-window.c:
(gdm_greeter_login_window_constructor):
* gui/simple-greeter/gdm-greeter-panel.c:
(gdm_greeter_panel_set_property), (gdm_greeter_panel_get_property),
(gdm_greeter_panel_constructor), (gdm_greeter_panel_dispose):
* gui/simple-greeter/gdm-greeter-session.c:
(gdm_greeter_session_set_property),
(gdm_greeter_session_get_property),
(gdm_greeter_session_constructor), (gdm_greeter_session_dispose):
* gui/simple-greeter/gdm-language-chooser-widget.c:
(gdm_language_chooser_widget_dispose):
* gui/simple-greeter/gdm-option-widget.c: (activate_from_item_id),
(gdm_option_widget_constructor):
* gui/simple-greeter/gdm-recent-option-widget.c:
(gdm_recent_option_widget_dispose):
* gui/simple-greeter/gdm-remote-login-window.c:
(gdm_remote_login_window_set_property),
(gdm_remote_login_window_get_property),
(gdm_remote_login_window_constructor):
* gui/simple-greeter/gdm-session-client.c:
(gdm_session_client_constructor), (gdm_session_client_dispose):
* gui/simple-greeter/gdm-session-manager.c:
(gdm_session_manager_set_property),
(gdm_session_manager_get_property),
(gdm_session_manager_constructor), (gdm_session_manager_dispose):
* gui/simple-greeter/gdm-user-chooser-dialog.c:
(gdm_user_chooser_dialog_set_property),
(gdm_user_chooser_dialog_get_property),
(gdm_user_chooser_dialog_constructor),
(gdm_user_chooser_dialog_dispose):
* gui/simple-greeter/gdm-user-chooser-widget.c:
(gdm_user_chooser_widget_set_property),
(gdm_user_chooser_widget_get_property),
(gdm_user_chooser_widget_constructor):
* gui/simple-greeter/gdm-user-manager.c:
(_get_primary_user_session_id), (_get_login_window_session_id):
* gui/simple-greeter/gdm-user.c:
* gui/simple-greeter/libnotificationarea/na-tray-manager.c:
(na_tray_manager_handle_begin_message):
* gui/simple-greeter/libnotificationarea/na-tray.c:
* gui/user-switch-applet/applet.c: (prefs_cb),
(switch_to_user_session), (display_key_changed), (applet_fill_cb):
* gui/user-switch-applet/gdm-user-menu-item.c:
* tests/s-common-address.c: (START_TEST):
* utils/gdmflexiserver.c: (get_login_window_session_id):
Fix a bunch of compiler warnings and remove unused code.
Patch from: Kjartan Maraas <kmaraas@broadpark.no>
2008-02-18 William Jon McCann <jmccann@redhat.com>
* common/gdm-address.c:
......
......@@ -45,8 +45,6 @@
#define SETTINGS_DBUS_PATH "/org/gnome/DisplayManager/Settings"
#define SETTINGS_DBUS_INTERFACE "org.gnome.DisplayManager.Settings"
static char *schemas_file = NULL;
static char *schemas_root = NULL;
static GHashTable *notifiers = NULL;
static GHashTable *schemas = NULL;
static DBusGProxy *settings_proxy = NULL;
......@@ -250,7 +248,6 @@ gdm_settings_client_get_locale_string (const char *key,
{
char *candidate_key;
char *translated_value;
GError *error;
char **languages;
gboolean free_languages = FALSE;
int i;
......@@ -260,7 +257,6 @@ gdm_settings_client_get_locale_string (const char *key,
candidate_key = NULL;
translated_value = NULL;
error = NULL;
if (locale != NULL) {
languages = g_new (char *, 2);
......@@ -529,9 +525,6 @@ gdm_settings_client_init (const char *file,
schemas = g_hash_table_new_full (g_str_hash, g_str_equal, g_free, (GDestroyNotify)gdm_settings_entry_free);
g_slist_foreach (list, (GFunc)hashify_list, NULL);
schemas_file = g_strdup (file);
schemas_root = g_strdup (root);
dbus_g_proxy_add_signal (settings_proxy, "ValueChanged", G_TYPE_STRING, G_TYPE_STRING, G_TYPE_STRING, G_TYPE_INVALID);
dbus_g_proxy_connect_signal (settings_proxy,
"ValueChanged",
......
......@@ -173,7 +173,6 @@ static void
save_settings (GdmSettingsDesktopBackend *backend)
{
GError *local_error;
gboolean res;
char *contents;
gsize length;
......@@ -192,10 +191,10 @@ save_settings (GdmSettingsDesktopBackend *backend)
}
local_error = NULL;
res = g_file_set_contents (backend->priv->filename,
contents,
length,
&local_error);
g_file_set_contents (backend->priv->filename,
contents,
length,
&local_error);
if (local_error != NULL) {
g_warning ("Unable to save settings: %s", local_error->message);
g_error_free (local_error);
......
......@@ -38,8 +38,6 @@
#include "gdm-settings-utils.h"
#include "gdm-settings-direct.h"
static char *schemas_file;
static char *schemas_root;
static GHashTable *schemas;
static GdmSettings *settings_object;
......@@ -226,9 +224,6 @@ gdm_settings_direct_init (GdmSettings *settings,
schemas = g_hash_table_new_full (g_str_hash, g_str_equal, g_free, (GDestroyNotify)gdm_settings_entry_free);
g_slist_foreach (list, (GFunc)hashify_list, NULL);
schemas_file = g_strdup (file);
schemas_root = g_strdup (root);
settings_object = settings;
return TRUE;
......
......@@ -46,8 +46,8 @@ test_log (void)
g_message ("Test message");
g_warning ("Test warning");
g_error ("Test error");
g_critical ("Test critical");
g_error ("Test error");
}
int
......
......@@ -51,7 +51,6 @@ test_settings_client (gpointer data)
char *strval;
gboolean boolval;
gboolean res;
guint notify_id;
strval = NULL;
res = gdm_settings_client_get_string (GDM_KEY_WILLING, &strval);
......@@ -62,7 +61,7 @@ test_settings_client (gpointer data)
g_debug ("Got res=%d %s=%s", res, GDM_KEY_XDMCP, boolval ? "true" : "false");
g_debug ("Adding notify for all keys");
notify_id = gdm_settings_client_notify_add ("/", notify_cb, NULL, NULL);
gdm_settings_client_notify_add ("/", notify_cb, NULL, NULL);
g_debug ("Setting boolean key %s to %s", GDM_KEY_XDMCP, !boolval ? "true" : "false");
gdm_settings_client_set_boolean (GDM_KEY_XDMCP, !boolval);
......
......@@ -514,9 +514,6 @@ gdm_chooser_server_constructor (GType type,
GObjectConstructParam *construct_properties)
{
GdmChooserServer *chooser_server;
GdmChooserServerClass *klass;
klass = GDM_CHOOSER_SERVER_CLASS (g_type_class_peek (GDM_TYPE_CHOOSER_SERVER));
chooser_server = GDM_CHOOSER_SERVER (G_OBJECT_CLASS (gdm_chooser_server_parent_class)->constructor (type,
n_construct_properties,
......
......@@ -68,10 +68,6 @@ gdm_chooser_session_set_property (GObject *object,
const GValue *value,
GParamSpec *pspec)
{
GdmChooserSession *self;
self = GDM_CHOOSER_SESSION (object);
switch (prop_id) {
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
......@@ -85,10 +81,6 @@ gdm_chooser_session_get_property (GObject *object,
GValue *value,
GParamSpec *pspec)
{
GdmChooserSession *self;
self = GDM_CHOOSER_SESSION (object);
switch (prop_id) {
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
......@@ -102,9 +94,6 @@ gdm_chooser_session_constructor (GType type,
GObjectConstructParam *construct_properties)
{
GdmChooserSession *chooser_session;
GdmChooserSessionClass *klass;
klass = GDM_CHOOSER_SESSION_CLASS (g_type_class_peek (GDM_TYPE_CHOOSER_SESSION));
chooser_session = GDM_CHOOSER_SESSION (G_OBJECT_CLASS (gdm_chooser_session_parent_class)->constructor (type,
n_construct_properties,
......
......@@ -58,7 +58,7 @@ enum
PROP_PATH
};
G_DEFINE_TYPE (GdmDisplayAccessFile, gdm_display_access_file, G_TYPE_OBJECT);
G_DEFINE_TYPE (GdmDisplayAccessFile, gdm_display_access_file, G_TYPE_OBJECT)
static void
gdm_display_access_file_get_property (GObject *object,
......
......@@ -142,7 +142,7 @@ _create_access_file_for_user (GdmDisplay *display,
file_error = NULL;
if (!gdm_display_access_file_open (access_file, &file_error)) {
g_propagate_error (error, file_error);
return FALSE;
return NULL;
}
return access_file;
......@@ -778,11 +778,8 @@ gdm_display_constructor (GType type,
GObjectConstructParam *construct_properties)
{
GdmDisplay *display;
GdmDisplayClass *klass;
gboolean res;
klass = GDM_DISPLAY_CLASS (g_type_class_peek (GDM_TYPE_DISPLAY));
display = GDM_DISPLAY (G_OBJECT_CLASS (gdm_display_parent_class)->constructor (type,
n_construct_properties,
construct_properties));
......
......@@ -670,14 +670,13 @@ gdm_factory_slave_run (GdmFactorySlave *slave)
static gboolean
gdm_factory_slave_start (GdmSlave *slave)
{
gboolean res;
gboolean ret;
ret = FALSE;
g_debug ("GdmFactorySlave: Starting factory slave");
res = GDM_SLAVE_CLASS (gdm_factory_slave_parent_class)->start (slave);
GDM_SLAVE_CLASS (gdm_factory_slave_parent_class)->start (slave);
GDM_FACTORY_SLAVE (slave)->priv->session = gdm_session_relay_new ();
g_signal_connect (GDM_FACTORY_SLAVE (slave)->priv->session,
......@@ -766,11 +765,9 @@ gdm_factory_slave_start (GdmSlave *slave)
static gboolean
gdm_factory_slave_stop (GdmSlave *slave)
{
gboolean res;
g_debug ("GdmFactorySlave: Stopping factory_slave");
res = GDM_SLAVE_CLASS (gdm_factory_slave_parent_class)->stop (slave);
GDM_SLAVE_CLASS (gdm_factory_slave_parent_class)->stop (slave);
if (GDM_FACTORY_SLAVE (slave)->priv->session != NULL) {
gdm_session_relay_stop (GDM_FACTORY_SLAVE (slave)->priv->session);
......@@ -809,10 +806,6 @@ gdm_factory_slave_set_property (GObject *object,
const GValue *value,
GParamSpec *pspec)
{
GdmFactorySlave *self;
self = GDM_FACTORY_SLAVE (object);
switch (prop_id) {
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
......@@ -826,10 +819,6 @@ gdm_factory_slave_get_property (GObject *object,
GValue *value,
GParamSpec *pspec)
{
GdmFactorySlave *self;
self = GDM_FACTORY_SLAVE (object);
switch (prop_id) {
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
......@@ -843,9 +832,6 @@ gdm_factory_slave_constructor (GType type,
GObjectConstructParam *construct_properties)
{
GdmFactorySlave *factory_slave;
GdmFactorySlaveClass *klass;
klass = GDM_FACTORY_SLAVE_CLASS (g_type_class_peek (GDM_TYPE_FACTORY_SLAVE));
factory_slave = GDM_FACTORY_SLAVE (G_OBJECT_CLASS (gdm_factory_slave_parent_class)->constructor (type,
n_construct_properties,
......
......@@ -916,9 +916,6 @@ gdm_greeter_server_constructor (GType type,
GObjectConstructParam *construct_properties)
{
GdmGreeterServer *greeter_server;
GdmGreeterServerClass *klass;
klass = GDM_GREETER_SERVER_CLASS (g_type_class_peek (GDM_TYPE_GREETER_SERVER));
greeter_server = GDM_GREETER_SERVER (G_OBJECT_CLASS (gdm_greeter_server_parent_class)->constructor (type,
n_construct_properties,
......
......@@ -66,10 +66,6 @@ gdm_greeter_session_set_property (GObject *object,
const GValue *value,
GParamSpec *pspec)
{
GdmGreeterSession *self;
self = GDM_GREETER_SESSION (object);
switch (prop_id) {
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
......@@ -83,10 +79,6 @@ gdm_greeter_session_get_property (GObject *object,
GValue *value,
GParamSpec *pspec)
{
GdmGreeterSession *self;
self = GDM_GREETER_SESSION (object);
switch (prop_id) {
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
......
......@@ -438,10 +438,6 @@ gdm_local_display_factory_set_property (GObject *object,
const GValue *value,
GParamSpec *pspec)
{
GdmLocalDisplayFactory *self;
self = GDM_LOCAL_DISPLAY_FACTORY (object);
switch (prop_id) {
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
......@@ -455,10 +451,6 @@ gdm_local_display_factory_get_property (GObject *object,
GValue *value,
GParamSpec *pspec)
{
GdmLocalDisplayFactory *self;
self = GDM_LOCAL_DISPLAY_FACTORY (object);
switch (prop_id) {
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
......@@ -515,11 +507,8 @@ gdm_local_display_factory_constructor (GType type,
GObjectConstructParam *construct_properties)
{
GdmLocalDisplayFactory *factory;
GdmLocalDisplayFactoryClass *klass;
gboolean res;
klass = GDM_LOCAL_DISPLAY_FACTORY_CLASS (g_type_class_peek (GDM_TYPE_LOCAL_DISPLAY_FACTORY));
factory = GDM_LOCAL_DISPLAY_FACTORY (G_OBJECT_CLASS (gdm_local_display_factory_parent_class)->constructor (type,
n_construct_properties,
construct_properties));
......
......@@ -320,9 +320,6 @@ gdm_manager_constructor (GType type,
GObjectConstructParam *construct_properties)
{
GdmManager *manager;
GdmManagerClass *klass;
klass = GDM_MANAGER_CLASS (g_type_class_peek (GDM_TYPE_MANAGER));
manager = GDM_MANAGER (G_OBJECT_CLASS (gdm_manager_parent_class)->constructor (type,
n_construct_properties,
......
......@@ -187,9 +187,6 @@ gdm_product_display_constructor (GType type,
GObjectConstructParam *construct_properties)
{
GdmProductDisplay *display;
GdmProductDisplayClass *klass;
klass = GDM_PRODUCT_DISPLAY_CLASS (g_type_class_peek (GDM_TYPE_PRODUCT_DISPLAY));
display = GDM_PRODUCT_DISPLAY (G_OBJECT_CLASS (gdm_product_display_parent_class)->constructor (type,
n_construct_properties,
......
......@@ -966,13 +966,12 @@ static gboolean
gdm_product_slave_start (GdmSlave *slave)
{
gboolean ret;
gboolean res;
GError *error;
char *display_id;
ret = FALSE;
res = GDM_SLAVE_CLASS (gdm_product_slave_parent_class)->start (slave);
GDM_SLAVE_CLASS (gdm_product_slave_parent_class)->start (slave);
g_object_get (slave,
"display-id", &display_id,
......@@ -1019,11 +1018,9 @@ gdm_product_slave_start (GdmSlave *slave)
static gboolean
gdm_product_slave_stop (GdmSlave *slave)
{
gboolean res;
g_debug ("GdmProductSlave: Stopping product_slave");
res = GDM_SLAVE_CLASS (gdm_product_slave_parent_class)->stop (slave);
GDM_SLAVE_CLASS (gdm_product_slave_parent_class)->stop (slave);
if (GDM_PRODUCT_SLAVE (slave)->priv->session != NULL) {
gdm_session_close (GDM_SESSION (GDM_PRODUCT_SLAVE (slave)->priv->session));
......@@ -1050,10 +1047,6 @@ gdm_product_slave_set_property (GObject *object,
const GValue *value,
GParamSpec *pspec)
{
GdmProductSlave *self;
self = GDM_PRODUCT_SLAVE (object);
switch (prop_id) {
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
......@@ -1067,10 +1060,6 @@ gdm_product_slave_get_property (GObject *object,
GValue *value,
GParamSpec *pspec)
{
GdmProductSlave *self;
self = GDM_PRODUCT_SLAVE (object);
switch (prop_id) {
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
......@@ -1084,9 +1073,6 @@ gdm_product_slave_constructor (GType type,
GObjectConstructParam *construct_properties)
{
GdmProductSlave *product_slave;
GdmProductSlaveClass *klass;
klass = GDM_PRODUCT_SLAVE_CLASS (g_type_class_peek (GDM_TYPE_PRODUCT_SLAVE));
product_slave = GDM_PRODUCT_SLAVE (G_OBJECT_CLASS (gdm_product_slave_parent_class)->constructor (type,
n_construct_properties,
......
......@@ -831,9 +831,6 @@ gdm_server_constructor (GType type,
GObjectConstructParam *construct_properties)
{
GdmServer *server;
GdmServerClass *klass;
klass = GDM_SERVER_CLASS (g_type_class_peek (GDM_TYPE_SERVER));
server = GDM_SERVER (G_OBJECT_CLASS (gdm_server_parent_class)->constructor (type,
n_construct_properties,
......
......@@ -61,7 +61,7 @@ enum {
PROP_DISPLAY_DEVICE
};
G_DEFINE_TYPE (GdmSessionAuditor, gdm_session_auditor, G_TYPE_OBJECT);
G_DEFINE_TYPE (GdmSessionAuditor, gdm_session_auditor, G_TYPE_OBJECT)
static void
gdm_session_auditor_class_init (GdmSessionAuditorClass *auditor_class)
......
......@@ -107,7 +107,7 @@ G_DEFINE_TYPE_WITH_CODE (GdmSessionDirect,
gdm_session_direct,
G_TYPE_OBJECT,
G_IMPLEMENT_INTERFACE (GDM_TYPE_SESSION,
gdm_session_iface_init));
gdm_session_iface_init))
static gboolean
send_dbus_message (DBusConnection *connection,
......@@ -1334,13 +1334,12 @@ static void
gdm_session_direct_open (GdmSession *session)
{
GdmSessionDirect *impl = GDM_SESSION_DIRECT (session);
gboolean res;
g_return_if_fail (session != NULL);
g_debug ("GdmSessionDirect: Opening session");
res = start_worker (impl);
start_worker (impl);
}
static void
......
......@@ -42,7 +42,7 @@ struct _GdmSessionLinuxAuditorPrivate
static void gdm_session_linux_auditor_finalize (GObject *object);
G_DEFINE_TYPE (GdmSessionLinuxAuditor, gdm_session_linux_auditor, GDM_TYPE_SESSION_AUDITOR);
G_DEFINE_TYPE (GdmSessionLinuxAuditor, gdm_session_linux_auditor, GDM_TYPE_SESSION_AUDITOR)
static void
gdm_session_linux_auditor_report_login_attempt (GdmSessionAuditor *auditor,
......
......@@ -1017,10 +1017,6 @@ gdm_session_relay_set_property (GObject *object,
const GValue *value,
GParamSpec *pspec)
{
GdmSessionRelay *self;
self = GDM_SESSION_RELAY (object);
switch (prop_id) {
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
......@@ -1034,10 +1030,6 @@ gdm_session_relay_get_property (GObject *object,
GValue *value,
GParamSpec *pspec)
{
GdmSessionRelay *self;
self = GDM_SESSION_RELAY (object);
switch (prop_id) {
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
......@@ -1051,9 +1043,6 @@ gdm_session_relay_constructor (GType type,
GObjectConstructParam *construct_properties)
{
GdmSessionRelay *session_relay;
GdmSessionRelayClass *klass;
klass = GDM_SESSION_RELAY_CLASS (g_type_class_peek (GDM_TYPE_SESSION_RELAY));
session_relay = GDM_SESSION_RELAY (G_OBJECT_CLASS (gdm_session_relay_parent_class)->constructor (type,
n_construct_properties,
......
......@@ -59,7 +59,7 @@ enum {
PROP_LANGUAGE_NAME,
};
G_DEFINE_TYPE (GdmSessionSettings, gdm_session_settings, G_TYPE_OBJECT);
G_DEFINE_TYPE (GdmSessionSettings, gdm_session_settings, G_TYPE_OBJECT)
static void
gdm_session_settings_class_init (GdmSessionSettingsClass *settings_class)
......
......@@ -339,9 +339,6 @@ gdm_session_worker_job_constructor (GType type,
GObjectConstructParam *construct_properties)
{
GdmSessionWorkerJob *session_worker_job;
GdmSessionWorkerJobClass *klass;
klass = GDM_SESSION_WORKER_JOB_CLASS (g_type_class_peek (GDM_TYPE_SESSION_WORKER_JOB));
session_worker_job = GDM_SESSION_WORKER_JOB (G_OBJECT_CLASS (gdm_session_worker_job_parent_class)->constructor (type,
n_construct_properties,
......
......@@ -2138,11 +2138,8 @@ gdm_session_worker_constructor (GType type,
GObjectConstructParam *construct_properties)
{
GdmSessionWorker *worker;
GdmSessionWorkerClass *klass;
DBusError error;
klass = GDM_SESSION_WORKER_CLASS (g_type_class_peek (GDM_TYPE_SESSION_WORKER));
worker = GDM_SESSION_WORKER (G_OBJECT_CLASS (gdm_session_worker_parent_class)->constructor (type,
n_construct_properties,
construct_properties));
......
......@@ -874,9 +874,7 @@ gdm_simple_slave_run (GdmSimpleSlave *slave)
static gboolean
gdm_simple_slave_start (GdmSlave *slave)
{
gboolean res;
res = GDM_SLAVE_CLASS (gdm_simple_slave_parent_class)->start (slave);
GDM_SLAVE_CLASS (gdm_simple_slave_parent_class)->start (slave);
gdm_simple_slave_run (GDM_SIMPLE_SLAVE (slave));
......@@ -886,11 +884,9 @@ gdm_simple_slave_start (GdmSlave *slave)
static gboolean
gdm_simple_slave_stop (GdmSlave *slave)
{
gboolean res;
g_debug ("GdmSimpleSlave: Stopping simple_slave");
res = GDM_SLAVE_CLASS (gdm_simple_slave_parent_class)->stop (slave);
GDM_SLAVE_CLASS (gdm_simple_slave_parent_class)->stop (slave);
if (GDM_SIMPLE_SLAVE (slave)->priv->greeter != NULL) {
gdm_welcome_session_stop (GDM_WELCOME_SESSION (GDM_SIMPLE_SLAVE (slave)->priv->greeter));
......@@ -919,10 +915,6 @@ gdm_simple_slave_set_property (GObject *object,
const GValue *value,
GParamSpec *pspec)
{
GdmSimpleSlave *self;
self = GDM_SIMPLE_SLAVE (object);
switch (prop_id) {
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
......@@ -936,10 +928,6 @@ gdm_simple_slave_get_property (GObject *object,
GValue *value,
GParamSpec *pspec)
{
GdmSimpleSlave *self;
self = GDM_SIMPLE_SLAVE (object);
switch (prop_id) {
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
......@@ -953,9 +941,6 @@ gdm_simple_slave_constructor (GType type,
GObjectConstructParam *construct_properties)
{
GdmSimpleSlave *simple_slave;
GdmSimpleSlaveClass *klass;
klass = GDM_SIMPLE_SLAVE_CLASS (g_type_class_peek (GDM_TYPE_SIMPLE_SLAVE));
simple_slave = GDM_SIMPLE_SLAVE (G_OBJECT_CLASS (gdm_simple_slave_parent_class)->constructor (type,
n_construct_properties,
......
......@@ -337,6 +337,11 @@ gdm_slave_run_script (GdmSlave *slave,
g_ptr_array_foreach (env, (GFunc)g_free, NULL);
g_ptr_array_free (env, TRUE);
if (! res) {
g_warning ("GdmSlave: Unable to run script: %s", error->message);
g_error_free (error);
}
gdm_slave_whack_temp_auth_file (slave);
if (WIFEXITED (status)) {
......@@ -836,7 +841,6 @@ _get_primary_user_session_id (GdmSlave *slave,
const char *username)
{
gboolean res;
gboolean ret;
gboolean can_activate_sessions;
GError *error;
DBusGProxy *manager_proxy;
......@@ -851,7 +855,6 @@ _get_primary_user_session_id (GdmSlave *slave,
return