1. 14 Aug, 2019 4 commits
  2. 13 Aug, 2019 1 commit
    • Daniel van Vugt's avatar
      fileItem.js: Create menus lazily · fa21e66c
      Daniel van Vugt authored
      Now menus don't get created until they're needed.
      
      And since menus often won't be needed at all, this conveniently works
      around apparent leaks in gnome-shell PopupMenu (#104).
      fa21e66c
  3. 22 Jul, 2019 1 commit
  4. 11 Jul, 2019 1 commit
  5. 28 Jun, 2019 8 commits
    • Sergio Costas's avatar
      fileItem.js: remove the menu during destruction · 3d398fda
      Sergio Costas authored
      The menu for each file icon is added to a menuManager and to the
      layoutManager, but it is never removed, so it is never destroyed when
      the desktop is refreshed.
      
      This patch removes the menu and ensures its destruction when the
      fileItem is destroyed.
      3d398fda
    • Sergio Costas's avatar
      fileItem.js: disconnect writable-by-others signal · 5772b0a9
      Sergio Costas authored
      When a FileItem object is destroyed, the 'writable-by-others' signal
      must be disconnected, because it is connected to an external object.
      5772b0a9
    • Sergio Costas's avatar
      fileItem.js: fix code alignment · 73722b33
      Sergio Costas authored
      The parameters of a call to set_attributes_async were misplaced.
      This patch fixes it.
      73722b33
    • Sergio Costas's avatar
      fileItem.js: nullify _setMetadataCancellable · 6a28f7f1
      Sergio Costas authored
      This patch ensures that _setMetadataCancellable is nullified when we
      are done with the Cancellable object.
      6a28f7f1
    • Sergio Costas's avatar
      fileItem.js: nullify _loadThumbnailDataCancellable · b6766a84
      Sergio Costas authored
      _loadThumbnailDataCancellable is used while loading the data from a
      picture's thumbnail. This patch sets it to null when we are done
      with it. This allows to free the memory used and avoids calling its
      'cancel' method without reason when the fileItem is destroyed.
      b6766a84
    • Sergio Costas's avatar
      fileItem.js: fix property name · b676c00e
      Sergio Costas authored
      The property _trashInitializeCancellable isn't used. What is used
      is _queryTrashInfoCancellable, so it is a good idea to initialize it
      instead.
      b676c00e
    • Sergio Costas's avatar
      fileItem.js: avoid error after creating thumbnail · 51a2b445
      Sergio Costas authored
      When a file have to create a thumbnail, it creates a watch to detect
      when the thumbnail has been created. In case that there is already a
      thumbnail being created, it removes the watch and creates a new one.
      Unfortunately, once the thumbnail has been created, the watch ID
      isn't removed, so if a new thumbnail has to be created, or when the
      fileItel is destroyed, the code will try to remove the old watch,
      and producing an error.
      
      This patch fixes this.
      51a2b445
    • Sergio Costas's avatar
      fileItem.js: ensure refresh attrs. in .desktop files · 2dc5760a
      Sergio Costas authored
      In the current code, when the attributes or the content of a .desktop
      files change, they are reloaded. But if the file now contains a syntax
      error, it will be marked as non-desktop file. The problem is that,
      from now until a desktop refresh is performed, the contents won't be
      checked again. This means that if the user edits a .desktop file and
      stores it with a bug (which will render it not-launchable), fixes the
      error and saves it again, the .desktop file will remain as
      non-launchable until a desktop refresh is performed and the contents
      are re-read.
      
      This patch fixes this by triggering an attribute reload when the
      file type is .desktop.
      2dc5760a
  6. 22 Jun, 2019 1 commit
  7. 02 Jun, 2019 1 commit
  8. 01 Jun, 2019 1 commit
  9. 27 May, 2019 1 commit
  10. 14 May, 2019 2 commits
  11. 13 May, 2019 5 commits
  12. 10 May, 2019 1 commit
    • Sergio Costas's avatar
      general: don't use specific monitor for .desktop files · 5ecd2841
      Sergio Costas authored
      Currently, when a .desktop file exists in the desktop folder, it
      creates its own monitor to detect when their permissions change and
      adjust its icon and hability to be launched.
      
      This patch removes this monitor and uses the same used to monitor the
      desktop folder, thus reducing the resources usage.
      5ecd2841
  13. 03 May, 2019 1 commit
  14. 01 May, 2019 1 commit
  15. 30 Apr, 2019 1 commit
  16. 29 Apr, 2019 3 commits
  17. 23 Apr, 2019 3 commits
  18. 16 Apr, 2019 1 commit
    • Sergio Costas's avatar
      desktopGrid.js: Check shell version for method existence · 0b383878
      Sergio Costas authored
      In gnome shell 3.32 there was an API change, where the show() method
      was renamed as open(), and hide() as close(); thus the correct one
      must be called to ensure compatibility with previous versions.
      
      In the previous patch, this was done just by checking the existence
      of the newest method, and if it didn't exist, the old one should be
      called. This is not a good way of doing it. The right way is
      implemented in this patch, by checking the current gnome shell version
      and calling the apropriate method.
      0b383878
  19. 03 Apr, 2019 2 commits
    • Sergio Costas's avatar
      desktopGrid.js: remove unnecessary NULL parameters · b0cfb3d4
      Sergio Costas authored
      The open() and show() methods were being called with three parameters,
      and the last one is NULL. But both methods receive in fact only two
      parameters, so the NULL one can be safely removed.
      b0cfb3d4
    • Sergio Costas's avatar
      desktopGrid.js: Fix keyboard hang when renaming · c95a571b
      Sergio Costas authored
      A previous patch changed the calls to BoxPointer.show() and
      BoxPointer.hide() to open() and close() respectively, because those
      calls are being deprecated in Gnome Shell 3.32. Unfortunately, the
      former ones doesn't exist in Gnome Shell 3.30, which means that those
      calls fail in that case, with the unfortunate effect of locking the
      keyboard.
      
      This patch checks whether the open() and close() calls do exist or
      not, in which case it will call the old show() and hide() ones, thus
      ensuring that the code will work both in 3.30 and newer versions.
      
      Fixes https://gitlab.gnome.org/World/ShellExtensions/desktop-icons/issues/101
      c95a571b
  20. 27 Mar, 2019 1 commit