Commit 39038173 authored by adrian15sgd's avatar adrian15sgd
Browse files

Readd findiso parametre to loopback.cfg generation.

parent e4a4d4ae
Show whitespace changes
Inline Side-by-side
  • Thanatermesis 💬 @Thanatermesis ·

    @adrian15sgd-guest after my recent update, the isos doesn't boot anymore in (grub) EFI mode, due to this parameter

    I don't see any other "findiso" reference on my git clone, only this entry, maybe there's missing code?

    For what is needed the findiso parameter? (it booted correctly previously before to add it)

  • adrian15sgd @adrian15sgd-guest ·
    Author Owner

    Didn't see your comment till now.

    This should be hopefully solved with an updated live-boot package. If it's not the case or maybe you use another initramfs and it does not work properly please complain.

  • Thanatermesis 💬 @Thanatermesis ·

    Wow 5 years, unbeliable how time pass...

    I don't even remember this

    But I just looked into my code and I see that I still have a modification to remove it:

    /e/live-build git:elive-buster ❯❯❯ ack findiso
scripts/build/binary_loopback_cfg
178-# wtf with this?
179:#APPEND_LIVE="${LB_BOOTAPPEND_LIVE} findiso=\${iso_path}"
180-APPEND_LIVE="${LB_BOOTAPPEND_LIVE}"

    Actually, I don't have much information than that, is just the way I still using it to have it working

  • Thanatermesis 💬 @Thanatermesis ·

    By the way "iso_path" seems to be only declared on this line, no other matches on the rest of the source code, is this expected?

  • adrian15sgd @adrian15sgd-guest ·
    Author Owner

    Wow 5 years, unbeliable how time pass...

    I don't even remember this

    But I just looked into my code and I see that I still have a modification to remove it:

    /e/live-build git:elive-buster ❯❯❯ ack findiso
scripts/build/binary_loopback_cfg
178-# wtf with this?
179:#APPEND_LIVE="${LB_BOOTAPPEND_LIVE} findiso=\${iso_path}"
180-APPEND_LIVE="${LB_BOOTAPPEND_LIVE}"

    Actually, I don't have much information than that, is just the way I still using it to have it working

    Having an empty findiso parametre does not seem to be a problem to me.

    If you revert that change right now... Does it work for you? Or does it fail? Could you share either generated loopback.cfg or the syslinux equivalent to see what kernel cmdline is this generating for you?

    Do you modify LB_BOOTAPPEND_LIVE variable manually in a custom hook maybe?

    Edited by adrian15sgd
  • adrian15sgd @adrian15sgd-guest ·
    Author Owner

    Also... Are you using an initramfs other than live-boot ?

0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment