Skip to content
GitLab
Switch branch/tag
  1. 20 Mar, 2019 9 commits
  3. 11 Feb, 2019 1 commit
  5. 25 Jan, 2019 2 commits
  7. 16 Jan, 2019 1 commit
  9. 15 Dec, 2018 3 commits
  11. 14 Dec, 2018 11 commits
  13. 13 Dec, 2018 2 commits
  15. 14 Nov, 2018 2 commits
    • NIIBE Yutaka's avatar
      libassuan.vers: Remove duplicates. · eac43aad
      NIIBE Yutaka authored 
      

Signed-off-by: NIIBE Yutaka's avatarNIIBE Yutaka <gniibe@fsij.org>
      eac43aad
    • NIIBE Yutaka's avatar
      server: Don't call _assuan_waitpid on server side. · 81536080
      NIIBE Yutaka authored 
      * src/server.c (_assuan_server_finish): Never call waitpid here.
* src/assuan-socket-server.c (accept_connection_bottom): Indentation.

--

The waitpid/wait only makes sense by parent catching its child
process.

Since the commit 93595de1 (for version
0.6.5, in 2004-04-21), CTX->PID on server side has client PID.

In the commit cb53f862

 (2009-11-19),
call of _assuan_waitpid was introduced in assuan_server_finish, but
this call always fails because the process is not a child process of
server.

(If we could catch exit of non-child process, it might cause a dead
lock, since client does call waitpid too.)

The indentation fix is to show the place where PID is assigned.

Signed-off-by: NIIBE Yutaka's avatarNIIBE Yutaka <gniibe@fsij.org>
      81536080
  17. 13 Nov, 2018 1 commit
  19. 08 Nov, 2018 1 commit
    • NIIBE Yutaka's avatar
      socket: Use union for sockaddr access. · ea69c712
      NIIBE Yutaka authored 
      

* src/assuan-socket.c (socks5_connect, use_socks): Use union
to access, instead of using cast to the pointer.

--

In some machine like 32-bit ARM, alignment requirement of struct
sockaddr and struct sockaddr_in (or struct sockaddr_in6) is different.

Although it is completely valid to use the value of the address by
cast here, because the object should be allocated by struct
sockaddr_in or struct sockaddr_in6 to be referred by struct
sockaddr *.  But compiler doesn't assume such a usage, thus, emits
warnings.

The API with struct sockaddr * is a bit difficult thing.  I examined
GNU C library for the implementation of the connect function, it uses
transparent union, the GCC feature.  It would be too much, if we do
same thing here.

Signed-off-by: NIIBE Yutaka's avatarNIIBE Yutaka <gniibe@fsij.org>
      ea69c712
  21. 02 Nov, 2018 1 commit
  23. 29 Oct, 2018 1 commit
  25. 26 Oct, 2018 4 commits
  27. 25 Oct, 2018 1 commit