Commit 9e243b13 authored by Ian Jackson's avatar Ian Jackson

Dgit.pm: reflog_cache_lookup: Replace `confess' with `die' after exec

With `confess' after `exec', perl complains

  Statement unlikely to be reached at /usr/share/perl5/Debian/Dgit.pm line 770.
	  (Maybe you meant system() when you said exec()?)

The error message's suggestion is not right here - what is wrong is
that confess is not really appropriate in the child in this way.

Replace it with die, using a better error string.
Signed-off-by: Ian Jackson's avatarIan Jackson <ijackson@chiark.greenend.org.uk>
parent b6e890bc
......@@ -767,7 +767,7 @@ sub reflog_cache_lookup ($$) {
printdebug ">(no reflog)\n";
finish 0;
}
exec @cmd; confess $!;
exec @cmd; die f_ "exec %s: %s\n", $cmd[0], $!;
}
while (<GC>) {
chomp;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment