Reinstate the new package in experimental for NEW

This reverts commit 5f4ab40d.

Temporary revert, need to finish the 20.11 -> 21.11 transition first.
Will re-add it to the experimental branch and upload it there to
get in the NEW queue.

This reverts commit 4ffd8d77.

Gbp-Dch: ignore

/lib/dpdk/dpdk-init calls sysctl which is part of procps, when not
installed systemd service will not come up.

Signed-off-by: Henning Schild <henning.schild@siemens.com>

QAT devices can support being used for either crypto or compression
and upstream despite code existing in the drivers/crypto and
drivers/compress directories for QAT, combines this into one common
PMD that implements support for both.

As a consequence, the QAT PMD isn't a dependency of either
librte-meta-crypto or librte-meta-compress. Whilst librte-common-qat*
could be added as an explicit dependency of the librte-meta-crypto and
librte-meta-compress packages, it is assumed that ease of long term
maintainance is preferred and this would go against that. Therefore,
add a librte-meta-common package that pulls in the common drivers
which could contain PMDs, like the QAT driver does. Then applications
can have a dependency on this rather than having to fall back to the
librte-meta-allpmds package which might contain much more than they
want and need.

Update to upstream version '20.11.5'
with Debian dir c0810cd4b0c41246d3088e9ed3555d912196d63d

Signed-off-by: Luca Boccassi <bluca@debian.org>

../drivers/net/dpaa2/dpaa2_rxtx.c: In function ‘dpaa2_dev_rx’:
../drivers/net/dpaa2/dpaa2_rxtx.c:863:4: error: ‘priv’ undeclared (first use in this function); did you mean ‘ldiv’?
    priv->rx_timestamp =
    ^~~~
    ldiv

Bugzilla ID: 982

Fixes: 1d10966a

 ("net/dpaa2: fix timestamping for IEEE1588")

Signed-off-by: Luca Boccassi <bluca@debian.org>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

$ meson --werror --buildtype=debugoptimized build && ninja-build -C build
[..]
[5/2516] Compiling C object buildtools/pmdinfogen/pmdinfogen.p/pmdinfogen.c.o
FAILED: buildtools/pmdinfogen/pmdinfogen.p/pmdinfogen.c.o
clang -Ibuildtools/pmdinfogen/pmdinfogen.p -Ibuildtools/pmdinfogen -I../../root/dpdk/buildtools/pmdinfogen -I. -I../../root/dpdk -Iconfig -I../../root/dpdk/config -Ilib/librte_eal/include -I../../root/dpdk/lib/librte_eal/include -Ilib/librte_eal/linux/include -I../../root/dpdk/lib/librte_eal/linux/include -Ilib/librte_eal/x86/include -I../../root/dpdk/lib/librte_eal/x86/include -Ilib/librte_pci -I../../root/dpdk/lib/librte_pci -Xclang -fcolor-diagnostics -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -O2 -g -MD -MQ buildtools/pmdinfogen/pmdinfogen.p/pmdinfogen.c.o -MF buildtools/pmdinfogen/pmdinfogen.p/pmdinfogen.c.o.d -o buildtools/pmdinfogen/pmdinfogen.p/pmdinfogen.c.o -c ../../root/dpdk/buildtools/pmdinfogen/pmdinfoge...

Causes symbols changes, so it's not appropriate for 20.11.

This reverts commit 64452c87

.

Signed-off-by: Luca Boccassi <bluca@debian.org>
Reviewed-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>

Ferruh Yigit authored Oct 04, 2021 and Luca Boccassi committed Mar 30, 2022

[ backported from upstream commit a99bf951

 ]

reported by "gcc (GCC) 12.0.0 20211003 (experimental)":

../drivers/net/cxgbe/cxgbe_ethdev.c:
	In function ‘cxgbe_dev_rx_queue_setup’:
../drivers/net/cxgbe/cxgbe_ethdev.c:682:24:
	error: the comparison will always evaluate as ‘true’ for the
	address of ‘fl’ will never be NULL [-Werror=address]
  682 |         if ((&rxq->fl) != NULL)
      |                        ^~

Fixing it by removing useless check.

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Reviewed-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>

Signed-off-by: Luca Boccassi <bluca@debian.org>

The enum was renamed to fix a typo in main, and backported.
But in the stable release we want to keep backward compatibility
when possible, so also define the old name so that both old and
new code will work.

Fixes: 7b5609a5

 ("cryptodev: fix RSA key type name")

Signed-off-by: Luca Boccassi <bluca@debian.org>
Tested-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>

Wei Huang authored Mar 16, 2022 and Luca Boccassi committed Mar 17, 2022

[ upstream commit 047c25401d2b4001e7e20200a5ec05868a113290 ]

Compile failed with cflag optimization=1 on Ubuntu20.04 with GCC10.3,
it reported vendor_id and dev_id may be used uninitialized in function
ifpga_rawdev_fill_info().
Actually it's not the truth, the variables are initialized in function
ifpga_get_dev_vendor_id(). To avoid such compile error, the variables
are initialized when they are defined.

Fixes: 9c006c45

 ("raw/ifpga: scan PCIe BDF device tree")

Signed-off-by: Wei Huang <wei.huang@intel.com>
Acked-by: Tianfei Zhang <tianfei.zhang@intel.com>
Acked-by: Rosen Xu <rosen.xu@intel.com>

Bruce Richardson authored Mar 16, 2022 and Luca Boccassi committed Mar 17, 2022

[ upstream commit b421909ce7c42109ebb3236275793b1c7fd3394e ]

The docs on binding drivers was updated as part of the removal of the
igb_uio module from the main DPDK repo. As part of that update, a note
about uio_pci_generic requiring legacy interrupts was removed, but
should have been kept.

Fixes: 56bb5841

 ("kernel/linux: remove igb_uio")

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Bruce Richardson authored Mar 16, 2022 and Luca Boccassi committed Mar 17, 2022

[ upstream commit c265d58619e7fc0f72441faafec56a2a8633a15b ]

Some IDEs, such as eclipse, complained on save about the use of special
characters in the (R) symbol in linux GSG doc. We can replace those with
the equivalent "|reg|" text, and including isonum.txt.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Jiawei Wang authored Mar 07, 2022 and Luca Boccassi committed Mar 17, 2022

[ upstream commit 04c0d3f20f54618c2b62f353b31b5a2fb20d687a ]

If there are an explicit port match and sample action in the same flow,
mlx5 PMD pushes the explicit port match in the prefix subflow, and
uses the tag item match in the suffix subflow.

The explicit port match was translated into source vport match so
the sample suffix subflow lost this match after flow split.

This patch copies the explicit port match to the sample suffix subflow,
and the latter gets the correct source vport value in the flow matcher.

Fixes: b4c0ddbf

 ("net/mlx5: split sample flow into two sub-flows")

Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

Devendra Singh Rawat authored Mar 16, 2022 and Luca Boccassi committed Mar 16, 2022

[ upstream commit f65c7fbceca91b54200ca3dc5d27f2292e5d829f ]

qede_alloc_rx_bulk_mbufs() was trimming the number of requested
mbufs count to QEDE_MAX_BULK_ALLOC_COUNT.
The Rx callback was ignorant of this trimming and it was always
resetting the number of empty RX BD ring slots to 0.
This resulted in Rx BD ring getting into an inconsistent
state and ultimately the application fails to receive any traffic.

The fix trims the number of requested mbufs count before
making call to qede_alloc_rx_bulk_mbufs().
After qede_alloc_rx_bulk_mbufs() returns successfully, the
number of empty Rx BD ring slots are decremented by the
correct count.

Fixes: 8f231247

 ("net/qede: fix performance bottleneck in Rx path")

Signed-off-by: Devendra Singh Rawat <dsinghrawat@marvell.com>
Signed-off-by: Rasesh Mody <rmody@marvell.com>

Satheesh Paul authored Mar 15, 2022 and Luca Boccassi committed Mar 16, 2022

This patch fixes issues in rearranging the MCAM entries
when user is creating flows with priority levels.
The MCAM preallocation scheme and the free entry cache are
removed. For every flow created, an MCAM allocation request
is made to the kernel. Each priority level has a list of
MCAM entries. For every flow rule added, the MCAM entry
obtained from kernel is checked if it is at the correct user
specified priority. If not, the existing rules are moved
across MCAM entries so that the user specified priority is
maintained.

Fixes: 29a2017c

 ("net/octeontx2: add flow mbox utility functions")

Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
Acked-by: Kiran Kumar Kokkilagadda <kirankumark@marvell.com>

Bruce Richardson authored Mar 11, 2022 and Luca Boccassi committed Mar 15, 2022

[ upstream commit 1763c91b06ca65bbb8516f47b97cffe1cac97dde ]

When compiling on FreeBSD with clang and include checking enabled,
errors are emitted due to differences in how empty structs/unions are
handled in C and C++, as C++ structs cannot have zero size.

lib/cryptodev/rte_crypto.h:127:2: error:
union has size 0 in C, non-zero size in C++

Since the contents of the union are all themselves of zero size,
the actual union wrapper is unnecessary. We therefore remove it for C++
builds - though keep it for C builds for safety and clarity of
understanding the code.

Fixes: c0f87eb5 ("cryptodev: change burst API to be crypto op oriented")
Fixes: d2a4223c

 ("cryptodev: do not store pointer to op specific params")

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Bruce Richardson authored Mar 11, 2022 and Luca Boccassi committed Mar 15, 2022

[ upstream commit dfb90fbe6b2b11ecf3535286c8d418ba8cc5485c ]

Building with clang on FreeBSD with chkincs enabled, we get the
following error about a missing space:

lib/compressdev/rte_compressdev_internal.h:25:58: error:
invalid suffix on literal;
C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
        rte_log(RTE_LOG_ ## level, compressdev_logtype, "%s(): "fmt "\n", \

Adding in a space between the '"' and 'fmt' removes the error.

Fixes: ed7dd94f

 ("compressdev: add basic device management")

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Bruce Richardson authored Mar 11, 2022 and Luca Boccassi committed Mar 15, 2022

[ upstream commit 29fd052dcc3be76112bc7b03a918308ebcf901d8 ]

Add missing 'extern "C"' to file.

Fixes: 428eb983

 ("eal: add OS specific header file")

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Rahul Bhansali authored Jan 11, 2022 and Luca Boccassi committed Mar 15, 2022

[ upstream commit 0490d69d58d9d75c37e780966c837a062658f528 ]

This patch fixes the stack buffer overflow error reported
from AddressSanitizer.
Function send_packetsx4() tries to access out of bound data
from rte_mbuf and fill it into TX buffer even in the case
where no pending packets (len = 0).
Performance impact:- No

ASAN error report:-
==819==ERROR: AddressSanitizer: stack-buffer-overflow on address
0xffffe2c0dcf0 at pc 0x0000005e791c bp 0xffffe2c0d7e0 sp 0xffffe2c0d800
READ of size 8 at 0xffffe2c0dcf0 thread T0
 #0 0x5e7918 in send_packetsx4 ../examples/l3fwd/l3fwd_common.h:251
 #1 0x5e7918 in send_packets_multi ../examples/l3fwd/l3fwd_neon.h:226

Fixes: 96ff4453

 ("examples/l3fwd: reorganise and optimize LPM code path")

Signed-off-by: Rahul Bhansali <rbhansali@marvell.com>
Reviewed-by: Conor Walsh <conor.walsh@intel.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

Adham Masarwah authored Mar 13, 2022 and Luca Boccassi committed Mar 15, 2022

[ upstream commit 5aae2723cddba81b179162b5e7e4f6bd429eaac5 ]

Replaced using strtoul with strtoull when converting to
64-bit mask field.
In Windows strtoul returns 32-bit values which cause an
issue with show RSS RETA.

Fixes: 66c59490

 ("ethdev: support multiple sizes of redirection table")

Signed-off-by: Adham Masarwah <adham@nvidia.com>
Acked-by: Aman Singh <aman.deep.singh@intel.com>

David Marchand authored Mar 10, 2022 and Luca Boccassi committed Mar 15, 2022

[ upstream commit 63f39a430a0a7a8b893ffbf88cd452dbc7b97c97 ]

This is something caught in UNH FreeBSD env.

For some reason [1], the pcap/bpf.h header started to define _BPF_H_.

It happens that the bpf_impl.h internal DPDK header uses this define as
an internal guard.
This triggers a build failure in bpf_convert.c which can't find
RTE_BPF_LOG macro.

Fix the include guard to use the filename and remove _.

1: https://github.com/the-tcpdump-group/libpcap/pull/1074

Fixes: 94972f35

 ("bpf: add BPF loading and execution framework")

Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>

Jiawei Wang authored Mar 09, 2022 and Luca Boccassi committed Mar 15, 2022

[ upstream commit 9a726360dd3010a4c664e37682826b68a0a7f7fe ]

A flow rule with sample action will be split into two sub flows,
and a tag action was added implicitly in the sample prefix sub flow,
the reserved metadata regC index was used for this tag action.

The reserved metadata regC was shared with metering action,
for ConnectX-5 trusted device (VF/SF), the reserved metadata regC was
invalid since PF only supported the legacy metering.

This patch adds the checking for the tag index and back to use the
application tag if a failure happened.

Fixes: a9b6ea45

 ("net/mlx5: fix tag ID conflict with sample action")

Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

David Marchand authored Jan 18, 2022 and Luca Boccassi committed Mar 15, 2022

[ upstream commit af74f7db384ed149fe42b21dbd7975f8a54ef227 ]

Even if unlikely, a buggy vhost-user master might attach fds to inflight
messages. Add checks like for other types of vhost-user messages.

Fixes: d87f1a1c

 ("vhost: support inflight info sharing")

Signed-off-by: David Marchand <david.marchand@redhat.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Chenbo Xia authored Feb 14, 2022 and Luca Boccassi committed Mar 15, 2022

[ upstream commit 6442c329b9d2ded0f44b27d2016aaba8ba5844c5 ]

In function vhost_user_set_inflight_fd, queue number in inflight
message is used to access virtqueue. However, queue number could
be larger than VHOST_MAX_VRING and cause write OOB as this number
will be used to write inflight info in virtqueue structure. This
patch checks the queue number to avoid the issue and also make
sure virtqueues are allocated before setting inflight information.

Fixes: ad0a4ae4

 ("vhost: checkout resubmit inflight information")

Reported-by: Wenxiang Qian <leonwxqian@gmail.com>
Signed-off-by: Chenbo Xia <chenbo.xia@intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>