• Bernhard Link's avatar
    don't install gv_spartan.dat and gv_widgetless.dat with fallback styles · 6dcafe6c
    Bernhard Link authored
    * Markus Steinborn <gnugv_maintainer@yahoo.de> [110506 13:28]:
    > Hello Bernhard,
    >
    > I've applied the other three patches.
    >
    > Bernhard R. Link schrieb:
    >> With fallback styles enabled (currently default), gv_spartan.dat and
    >> gv_widgetless.dat are always replaced with compiled in versions,
    >> so do not install those files to not confuse users with installing
    >> files that have no effect if changed.
    >> ---
    >>
    > On my system, GNU gv 3.7.2 installs the following files within
    > /usr/share/gv/
    >
    > /usr/share/gv/GV
    
    that is stored in appdefaultsdir (which by default might be the same,
    but can thus be installed in a way that it is used.
    
    > /usr/share/gv/gv_class.ad
    > /usr/share/gv/gv_copyright.dat
    > /usr/share/gv/gv_spartan.dat
    > /usr/share/gv/gv_system.ad
    > /usr/share/gv/gv_user.ad
    > /usr/share/gv/gv_user_res.dat
    > /usr/share/gv/gv_widgetless.dat
    >
    > Except "/usr/share/gv/gv_system.ad" none is read iff fallback styles are
    > enabled. I do not see any reason to handle gv_spartan.dat and
    > gv_widgetless.dat different from the raiming gv_*-files (except
    > gv_system.ad).
    
    I did not realize that. I only saw that those two are used with fallback
    styles and not without. What about the following then?
    
    >From 6540ff7072006cc84768704c1e0ceef80544be13 Mon Sep 17 00:00:00 2001
    From: Bernhard R. Link <brlink@debian.org>
    Date: Thu, 28 Apr 2011 16:24:16 +0200
    Subject: [PATCH] don't install .ad files not used
    
    Only install files gv actually reads. Having other files around
    is confusing as changing them has no effect.
    
    With fallback styles enabled (currently default), gv_spartan.dat and
    gv_widgetless.dat are always replaced with compiled in versions,
    so only install them if fallback styles are disabled.
    6dcafe6c
configure.ac 10.2 KB