1. 13 Dec, 2018 4 commits
  2. 12 Dec, 2018 2 commits
    • Paul Gevers's avatar
      Merge branch 'improve-readability-of-dependency-issues-on-install' into 'master' · 11c2e2d3
      Paul Gevers authored
      Better debug of failed of test dependencies
      
      See merge request !40
      11c2e2d3
    • Christian Ehrhardt's avatar
      Better debug of failed of test dependencies · 70cd3426
      Christian Ehrhardt authored
      In Ubuntu quite often things got build against packages in the
      -proposed pocket but might get tested withotu proposed enabled.
      That leads to an error of autopkgtest-satdep being removed.
      
      Unfortunately in those cases the "offending" packages are not
      listed in the output, so users have to recreate locally to
      debug.
      
      To solve this adds the ouput of a basic `apt install` call to
      the error path. That will report the missing dependency in a
      more readable way.
      
      Example - pre fix:
      autopkgtest [08:18:17]: test daemon: preparing testbed
      [...]
      Starting pkgProblemResolver with broken count: 0
      Starting 2 pkgProblemResolver with broken count: 0
      Done
      The following packages will be REMOVED:
        autopkgtest-satdep
      
      Example - post fix (the old output stays unmodified):
      autopkgtest: WARNING: Test dependencies are unsatisfiable -
      calling apt install on test deps directly for further data about
      failing dependencies in test log
      [...]
      Broken libstrongswan-extra-plugins:amd64 Depends on
      libunbound8:amd64 < none @un H > (>= 1.8.0)
      [...]
      The following packages have unmet dependencies:
       libstrongswan-extra-plugins : Depends: libunbound8 (>= 1.8.0)
       but it is not installable
      E: Unable to correct problems, you have held broken packages.
      Signed-off-by: Christian Ehrhardt's avatarChristian Ehrhardt <christian.ehrhardt@canonical.com>
      70cd3426
  3. 11 Dec, 2018 1 commit
  4. 10 Dec, 2018 1 commit
    • Iain Lane's avatar
      autopkgtest-build-lxd hack: mask serial-getty@getty.service · 9e2cdaec
      Iain Lane authored
      This blocks and slows down our boot, which causes autopkgtest-build-lxd
      to timeout.
      
      Also, don't fail if we can't mask that unit
      
      also, final hack: sleep 5 before the mask
      
      Apparently for bionic it takes a couple of seconds for the container to
      want to accept this lxd exec command.
      
        Failed to connect to bus: No such file or directory
      
      We could retry properly, but since this is a hack and we want
      serial-getty@getty to actually go away, just do this.
      9e2cdaec
  5. 20 Nov, 2018 1 commit
  6. 19 Nov, 2018 1 commit
  7. 18 Nov, 2018 3 commits
  8. 08 Nov, 2018 1 commit
  9. 15 Oct, 2018 4 commits
  10. 14 Oct, 2018 1 commit
  11. 29 Sep, 2018 8 commits
    • Simon McVittie's avatar
      Merge branch 'pycodestyle' into 'master' · 300ece79
      Simon McVittie authored
      Fix new pycodestyle warnings
      
      See merge request !37
      300ece79
    • Simon McVittie's avatar
      Fix most pycodestyle warnings for invalid escape sequences · aacea218
      Simon McVittie authored
      Recent pycodestyle versions add warnings for escape sequences not known
      to the current Python version. These currently expand to themselves,
      but could mean something different in a future Python version.
      
      In simple cases, use raw strings r'...' for regular expressions,
      shell scripts, and other strings likely to contain backslashes that
      are intended to be passed through to another interpreter like the
      regular expression parser or the shell.
      
      In more complex cases where the string already contains backslashes
      (other than in regular expressions), I've continued to use non-raw
      strings and just doubled the offending backslashes.
      
      In the test code, I've systematically used r'' for all regular
      expressions (even when it doesn't make any difference), since that seems
      least likely to introduce mistakes later.
      
      Note that
      
          assertRegex(foo, 'new\nline and\ttab')
          assertRegex(foo, r'new\nline and\ttab')
      
      both assert that foo contains "new<U+000A>line and<U+0009>tab", where
      <U+xxxx> represents the given control character. In the first match,
      the regular expression contains a literal U+000A (newline/line feed)
      and a literal U+0009 (horizontal tab), which match themselves, whereas
      in the second match, the regular expression contains the sequences
      backslash, n (which matches a newline) and backslash, t (which matches
      a tab).
      Signed-off-by: Simon McVittie's avatarSimon McVittie <smcv@debian.org>
      aacea218
    • Simon McVittie's avatar
      tests/pycodestyle: Print all warnings before exiting unsuccessfully · c4ef4765
      Simon McVittie authored
      If a new pycodestyle version introduces new warnings, we presumably
      want to report on them in all libraries and scripts, but `set -e`
      means we bail out early on a failed command. This resulted in, for
      example, not inspecting runner/autopkgtest if autopkgtest-virt-qemu
      provokes warnings.
      Signed-off-by: Simon McVittie's avatarSimon McVittie <smcv@debian.org>
      c4ef4765
    • Simon McVittie's avatar
      Ignore pycodestyle W504 "line break after binary operator" · fdf611d4
      Simon McVittie authored
      pycodestyle 2.4.0 warns whenever a line break occurs at a binary
      operator; the intention seems to be that projects suppress either
      W503 or W504, whichever one they prefer. Recent revisions of PEP 8
      recommend breaking long lines before binary operators:
      
          if (foo
              and bar
              and baz):
      
      but it seems autopkgtest consistently breaks after binary operators:
      
          if (foo and
              bar and
              baz):
      
      so enforce that one for now.
      Signed-off-by: Simon McVittie's avatarSimon McVittie <smcv@debian.org>
      fdf611d4
    • Simon McVittie's avatar
      Merge branch 'trivial-904979' into 'master' · 474d735b
      Simon McVittie authored
      Implement the 'superficial' restriction
      
      See merge request !34
      474d735b
    • Simon McVittie's avatar
    • Simon McVittie's avatar
      Implement superficial as a test restriction · 3c17c0c4
      Simon McVittie authored
      This feature was previously prototyped under the name 'trivial'.
      
      Superficial tests do not provide significant test coverage, so if they
      pass, that does not necessarily mean that the package under test
      is actually functional. If a superficial test fails, it will be
      treated like any other failing test, but if it succeeds, this is
      only a weak indication of success. Continuous integration systems
      should treat a package where all non-superficial tests are skipped as
      equivalent to a package where all tests are skipped.
      
      For example, debian/tests/build in packages like dbus, libinput and
      pango1.0 should be marked as superficial. For packages that have other
      tests (like dbus and pango1.0), this has no effect on migration to
      testing unless the non-superficial tests happen to be skipped. For
      packages where the only test is superficial (like libinput), marking
      the test as superficial removes the migration delay bonus on success
      (because the test doesn't actually confirm that the library works,
      so we have to rely on user testing to detect most regressions), while
      retaining the migration delay penalty on failure.
      
      Based on a patch from Rebecca N. Palmer.
      Signed-off-by: Simon McVittie's avatarSimon McVittie <smcv@debian.org>
      Closes: #904979
      3c17c0c4
    • Simon McVittie's avatar
      a3c67836
  12. 28 Sep, 2018 1 commit
  13. 12 Sep, 2018 1 commit
  14. 30 Aug, 2018 1 commit
  15. 22 Aug, 2018 1 commit
  16. 19 Aug, 2018 1 commit
    • Martin Pitt's avatar
      doc: Clarify scope of tests · 90876a75
      Martin Pitt authored
      autopkgtests are in no way limited to testing programs. Generalize the
      requirement that tests must test the installed *packages*, not just
      *programs*.
      
      Side issue in #906617.
      90876a75
  17. 16 Aug, 2018 2 commits
  18. 10 Aug, 2018 4 commits
  19. 08 Aug, 2018 2 commits