Commit 5f3776af authored by Sven Eckelmann's avatar Sven Eckelmann Committed by Marek Lindner

batctl: Return failure code when ping was not successful

The standard iputils-ping returns an error code when it could not receive a
single reply to a echo request. batctl ping behaved differently and made it
only possible to detect that the target is not reachable by parsing the text
output of batctl.

A new return code EXIT_NOSUCCESS (2) is introduced to distinguish a general
failure from the inability to reach another node.
Reported-by: default avatarFilippo Sallemi <tonyputi@gmail.com>
Signed-off-by: default avatarSven Eckelmann <sven@narfation.org>
parent 4c81da24
......@@ -25,4 +25,6 @@
#define SOCKET_PATH_FMT "%s/batman_adv/%s/socket"
#define EXIT_NOSUCCESS 2
#define __packed __attribute((packed)) /* linux kernel compat */
......@@ -322,7 +322,10 @@ sleep:
printf("rtt min/avg/max/mdev = %.3f/%.3f/%.3f/%.3f ms\n",
min, avg, max, mdev);
ret = EXIT_SUCCESS;
if (packets_in)
ret = EXIT_SUCCESS;
else
ret = EXIT_NOSUCCESS;
out:
bat_hosts_free();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment