1. 05 Jan, 2018 2 commits
    • luzpaz's avatar
      Misc. typos · 17d20685
      luzpaz authored
      Followup to previous PRs
      
      (cherry picked from commit d1316a17)
      17d20685
    • Unknown's avatar
      Source comment typos · 3432f27f
      Unknown authored
      Found using `codespell -q 3 --skip="*.po,./src/external" -I ../darktable-whitelist.txt`
      where whitelist consisted of:
      ```
      cas
      childs
      ect
      eacg
      isnt
      liquify
      nd
      nonexistant
      substract
      thru
      ```
      This PR is actually split up from #1576
      .
      
      (cherry picked from commit ca07fcc0)
      3432f27f
  2. 15 Dec, 2017 1 commit
  3. 14 Dec, 2017 1 commit
    • Tobias Ellinghaus's avatar
      exposure: Don't hide mode, just disable it · 7d82a2d7
      Tobias Ellinghaus authored
      When using exposure on anything but raw files we don't support automatic
      mode. Before the iop hid the combobox, confusing users. With this commit
      we make it insensitive instead so people understand that they can't
      change it while still seeing in what mode they are.
      
      Related to bug #11855.
      7d82a2d7
  4. 12 Dec, 2017 3 commits
  5. 07 Dec, 2017 1 commit
  6. 27 Nov, 2017 1 commit
    • Matthieu Moy's avatar
      temperature: properly deal with NaN coefficients · 89f0a8a9
      Matthieu Moy authored
      Before this patch, the call to mul2temp at the end of reoad_defaults()
      was returning
      
        TempK = 24999.647537
        tint = -nan
      
      The visible effect was that the tint slider was not properly colored
      (white to green instead of magenta to white to green).
      
      The expression computing CAM[k] was clearly wrong. Not only the
      assignment within the "then" branch of ?: was misleading, but the
      "else" branch was just a no-op: return 0.0f and throw it away.
      
      Fix the expression to make it what the initial author probably
      intended, i.e. an assignment of a conditional expression to CAM[k].
      With this patch, I get:
      
        TempK = 6244.398697
        tint = 1.002153
      
      and the slider is properly colored.
      89f0a8a9
  7. 25 Nov, 2017 1 commit
  8. 19 Nov, 2017 1 commit
    • ILiebhardt's avatar
      FDC squashed commit. · feea032a
      ILiebhardt authored
      Clang format selective to changes
      
      Remove CLIPping of input.
      
      Minor error correction.
      
      Correct combobox fallback behaviour to Markesteijn.
      
      Removed clipping in output stage and shifted intermediary clipping to chroma domain.
      
      Removed mutex; fftw plans now in init_global and cleanup_global.
      
      Correction in gitignore.
      
      Minor error correction for non-fftw.
      
      Removed FFTW3 dependecy.
      
      Minor correction: removal of last FFTW3 residual.
      
      Use fprintf instead of printf.
      feea032a
  9. 18 Nov, 2017 1 commit
  10. 05 Nov, 2017 1 commit
  11. 02 Nov, 2017 1 commit
  12. 26 Oct, 2017 1 commit
    • Tobias Ellinghaus's avatar
      Don't use export's conf to pass data to colorout · 1425e4f3
      Tobias Ellinghaus authored
      Abusing the configuration system by setting override profile/intent in
      the export namespace from all over the code to control what colorout
      does is bad style and prone to race conditions. It also messes with
      exporting images.
      
      Fixes #11787
      1425e4f3
  13. 22 Oct, 2017 1 commit
    • johannes hanika's avatar
      local laplacian: make roi aware in darkroom mode · 911133c8
      johannes hanika authored
      this only affects zooming in darkroom mode.
      the upper level of the laplacian pyramid are stolen
      from the preview pipeline. because they are at a different
      resolution, trilinear filtering is done to braid the data
      into the new output pyramids.
      
      this can result in some artifacts on very fine geometry
      for unlucky ratios between full and preview resolution.
      i think it's already a lot better than without though.
      
      the opencl code path is not fixed yet.
      
      i did not benchmark it, but since the full pipeline
      actually computes /less/ it should be faster modulo
      synchronisation with the preview pipe.
      911133c8
  14. 20 Oct, 2017 1 commit
  15. 07 Oct, 2017 1 commit
    • Tobias Ellinghaus's avatar
      Fix a crash from spot's legacy_params · 4c0754d0
      Tobias Ellinghaus authored
      I am not sure if the crash is really fixed by this, and if it maybe has
      side effects with legacy_params not working as intended, but the old
      code assumed that it was only run while in darkroom view, which is not
      necessarily true for legacy_params which is also run when generating
      thumbnails.
      Another part of the crash was libs/history.c getting the
      DT_SIGNAL_DEVELOP_HISTORY_CHANGE signal while in lighttable and doing
      bad things because of that. I didn't change that, but the crash seems to
      not happen any more. I assume it's just luck and that we have to revisit
      our signal system some day to either not emit those signals while not in
      darkroom, don't run callbacks from libs not visible at the moment, or at
      least check the current view before assuming that we are in darkroom and
      accessing darktable.develop.
      4c0754d0
  16. 01 Oct, 2017 1 commit
  17. 26 Sep, 2017 2 commits
    • Pascal Obry's avatar
      borders: sync opencl version. · f0cf3c41
      Pascal Obry authored
      The code for OpenCL had some discrepancies.
      f0cf3c41
    • Pascal Obry's avatar
      borders: fix frame size for the larger borders. · aea1d691
      Pascal Obry authored
      We do not want to extend the frame for the larger borders. This issue
      arise for a frame which do not have the same aspect than the image.
      
      To reproduce, open a portrait image, in the framing module:
      
         border size       : 10%
         aspect            : square
         frame line size   : 25%
         frame line offset : 100%
      
      The whole right part of the image is black.
      aea1d691
  18. 16 Sep, 2017 1 commit
  19. 12 Sep, 2017 1 commit
  20. 08 Sep, 2017 1 commit
    • Tobias Ellinghaus's avatar
      Make white balance sliders colored · 468ae24c
      Tobias Ellinghaus authored
      The temperature slider follows the inversed logic we have for Kelvin
      values, i.e., you set the color of the image and not the color cast you
      want to achieve. The tint slider however works like the rgb ones: it
      reflects the result on the image. This is open for discussion!
      468ae24c
  21. 07 Sep, 2017 1 commit
    • Tobias Ellinghaus's avatar
      Fix #11723: Fix a threading issue in rsvg/cairo · 9f10c211
      Tobias Ellinghaus authored
      This is mitigating the bug by running less of watermark's process() in
      parallel and putting more into a mutex. Not ideal. Eventually we might
      want to look at moving more of the setup code into commit_params().
      9f10c211
  22. 31 Aug, 2017 1 commit
  23. 21 Aug, 2017 1 commit
  24. 22 Jun, 2017 1 commit
  25. 21 Jun, 2017 2 commits
  26. 19 Jun, 2017 1 commit
  27. 17 Jun, 2017 1 commit
  28. 13 Jun, 2017 2 commits
  29. 12 Jun, 2017 1 commit
  30. 10 Jun, 2017 1 commit
  31. 09 Jun, 2017 2 commits
  32. 07 Jun, 2017 1 commit
  33. 06 Jun, 2017 1 commit