1. 21 Apr, 2017 1 commit
  2. 27 Oct, 2016 1 commit
  3. 06 Oct, 2016 1 commit
  4. 07 Sep, 2016 1 commit
  5. 25 Mar, 2016 1 commit
  6. 24 Mar, 2016 1 commit
  7. 20 Feb, 2016 2 commits
  8. 16 Feb, 2016 1 commit
  9. 14 Feb, 2016 1 commit
  10. 13 Feb, 2016 1 commit
    • Roman Lebedev's avatar
      Update DT module interface: add process_sse2() · e40129a7
      Roman Lebedev authored
      The idea is following:
      * Each IOP should implement process()
      * process() MUST ONLY contain OpenMP SIMD, no intrinsics !!!
      * instead, IOP can implement process_sse2()
      * if process_sse2() is implemented, it must only contain SSE2 intrinsics
      * then, default_process() will call correct process() implementation
        based on options
      e40129a7
  11. 06 Feb, 2016 1 commit
  12. 31 Jan, 2016 1 commit
  13. 31 Jul, 2015 3 commits
    • Roman Lebedev's avatar
      Modulelist lib: fix multi-instance-related crash. Fixes #10438 · b15b157f
      Roman Lebedev authored
      Modulelist should not be filled from iop instance list,
      but from global iop list, that contains only one instance
      of each iop, and where each item is valid until DT shutdowns.
      
      Also, iop state (dt_iop_module_state_t) is per-module and not
      per-instance, so move some code around to fix that.
      
      Fixes following AdressSanitizer error:
      =================================================================
      ==25777==ERROR: AddressSanitizer: heap-use-after-free on address 0x6190048dddb0 at pc 0x7f3595bcb351 bp 0x7ffe062883f0 sp 0x7ffe062883e8
      READ of size 4 at 0x6190048dddb0 thread T0
          0 0x7f3595bcb350 in favorite_renderer_function /home/lebedevri/darktable/src/libs/modulelist.c:127
          1 0x7f35b7264bfa  (/usr/lib/x86_64-linux-gnu/libgtk-3.so.0+0x124bfa)
          2 0x7f35b55691df in g_hash_table_foreach (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x391df)
      ...
          142 0x7f35b557a241 in g_main_loop_run (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4a241)
          143 0x7f35b7346f54 in gtk_main (/usr/lib/x86_64-linux-gnu/libgtk-3.so.0+0x206f54)
          144 0x7f35b7d2c572 in dt_gui_gtk_run /home/lebedevri/darktable/src/gui/gtk.c:964
          145 0x400cf3 in main /home/lebedevri/darktable/src/main.c:25
          146 0x7f35b02e9b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)
          147 0x400bd8  (/usr/local/bin/darktable+0x400bd8)
      
      0x6190048dddb0 is located 304 bytes inside of 904-byte region [0x6190048ddc80,0x6190048de008)
      freed by thread T0 here:
          0 0x7f35b803c0da in free (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x940da)
          1 0x7f3592f6378d in dt_dev_change_image /home/lebedevri/darktable/src/views/darkroom.c:580
          2 0x7f3592f64b2d in dt_dev_jump_image /home/lebedevri/darktable/src/views/darkroom.c:743
          3 0x7f3592f64bca in skip_f_key_accel_callback /home/lebedevri/darktable/src/views/darkroom.c:834
          4 0x7f35b7349a1a  (/usr/lib/x86_64-linux-gnu/libgtk-3.so.0+0x209a1a)
      
      previously allocated by thread T0 here:
          0 0x7f35b803c4e1 in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x944e1)
          1 0x7f35b7c42cd3 in dt_iop_load_modules /home/lebedevri/darktable/src/develop/imageop.c:1280
          2 0x7f35b7c262c9 in dt_dev_load_image /home/lebedevri/darktable/src/develop/develop.c:468
          3 0x7f3592f6be5e in enter /home/lebedevri/darktable/src/views/darkroom.c:1182
          4 0x7f35b7d74e54 in dt_view_manager_switch /home/lebedevri/darktable/src/views/view.c:414
          5 0x7f35b7bfcaf9 in _dt_ctl_switch_mode_to /home/lebedevri/darktable/src/control/control.c:647
          6 0x7f35b557abe4 in g_main_context_invoke_full (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4abe4)
      
      SUMMARY: AddressSanitizer: heap-use-after-free /home/lebedevri/darktable/src/libs/modulelist.c:127 favorite_renderer_function
      Shadow bytes around the buggy address:
      ...
      ==25777==ABORTING
      b15b157f
    • Roman Lebedev's avatar
      Implement monochrome demosaicing for thumbnail in DR. · 4dc64fa6
      Roman Lebedev authored
      Caveat 1: there is something about white balance being applied
      after demosaicing. Monochrome thumbnail looks blue-ish.
      
      Caveat 2: after you set demosaicing mode to passthrough (monochrome),
      thumbnail will be displayed right only after you re-open image in DR,
      or even restart DT - too good caching :)
      4dc64fa6
    • Roman Lebedev's avatar
      Implement dt_iop_clip_and_zoom_demosaic_passthrough_monochrome_f() · e643c4ca
      Roman Lebedev authored
      Downsamples and Demosaics at the same time.
      Should be faster than doing it in 2 steps.
      e643c4ca
  14. 23 Apr, 2015 1 commit
    • Ulrich Pegelow's avatar
      fix for last commit · 8ee11ed7
      Ulrich Pegelow authored
      we need to define specific dt_iop_clip_and_zoom_roi()/_roi_cl() routines and
      leave the original dt_iop_clip_and_zoom()/_cl() untouched
      8ee11ed7
  15. 06 Apr, 2015 1 commit
    • Roman Lebedev's avatar
      Pixelpipe: histogram capture code rewrite. · 1ef01924
      Roman Lebedev authored
      1. Histogram is per module per pipe
      2. module->histogram contains copy of histogram from preview pipe,
         if it was captured and if it was requested (more thread-safe).
      3. IOP widget will be only redrawn after preview histogram capture.
      1ef01924
  16. 24 Mar, 2015 2 commits
  17. 25 Jan, 2015 1 commit
  18. 03 Dec, 2014 1 commit
  19. 21 Jul, 2014 2 commits
  20. 08 Jul, 2014 2 commits
  21. 06 Jul, 2014 1 commit
  22. 08 Jun, 2014 1 commit
  23. 04 Jun, 2014 1 commit
  24. 01 Jun, 2014 1 commit
  25. 26 May, 2014 1 commit
  26. 25 May, 2014 1 commit
  27. 19 May, 2014 3 commits
  28. 07 May, 2014 1 commit
  29. 03 May, 2014 1 commit
  30. 25 Apr, 2014 1 commit
  31. 05 Apr, 2014 2 commits