• Sriram Karra's avatar
    pychecker catch: unused variables gid and statfi · 46efc984
    Sriram Karra authored
    there were two typos, one harmless and the other that could have
    caused some painful bugs with Outlook syncs.
    
    statefi should really be statei. Now fixed.
    
    The other is more subtle. The routine that is used to compute the
    olgid to be used at time of new profile creation works by first
    making a list of all used gids for that dbid, and then finding
    one that is unused. The array that was being built, due to the
    typo, was an array of strings of hte profile names, instead of the
    olgids of those profiles.
    
    This bug will hurt if there are a number of profiles created and the
    deleted, and then some more new ones are created. When this happens
    the buggy code will check a olgid with a profile name, find that the
    number is "unused" and then apply that for the new profile, leaing
    to mixing of the contacts from different profiles.
    
    Phew, good catch, pychecker.
    46efc984
Name
Last commit
Last update
.stash Loading commit data...
asynk Loading commit data...
doc Loading commit data...
gae Loading commit data...
lib Loading commit data...
scripts Loading commit data...
test Loading commit data...
.gitignore Loading commit data...
README.org Loading commit data...
asynk.py Loading commit data...
config.json Loading commit data...
gout.spec Loading commit data...
state.init.json Loading commit data...