local uploader: Fix silent lossage bug

Ian Jacksonrequested to merge
iwj/dput-ng:error-handling into master

Fixes https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1129961

I'm afraid this is a bit of a half-arsed job. If someone would like to carry on and clean this up further then that would be great. But I think the lossage is sufficiently bad that we shouldn't wait too long for those improvements before merging this MR as-is.

The outstanding things that I am aware of:

  • I had to totally disable two test cases; they were ineffective before I fixed the error handling
  • The run_command function has a hazardous API that invites this kind of bug

There are probably other things that are suboptimal. Python is not my nativwe language.

Merge request reports