• Paul Eggert's avatar
    faccessat: port to macOS (Bug#29231) · dd1890b7
    Paul Eggert authored
    macOS faccessat has the same bug that lstat does: if the file
    name ends in '/' it ignores the trailing slash.
    Problem reported for Emacs by Vincent Zhang.
    * doc/posix-functions/faccessat.texi (faccessat): Document this.
    * lib/faccessat.c (_GL_INCLUDING_UNISTD_H): Define and undef
    around the initial includes.  Include errno.h, string.h, sys/stat.h.
    (orig_faccessat) [HAVE_FACCESSAT]: New function.
    Include "unistd.h" after defining it.
    (rpl_faccessat) [HAVE_FACCESSAT]: New implementation.
    * lib/unistd.in.h (faccessat) [REPLACE_FACCESSAT]:
    Handle in the usual way.
    * m4/faccessat.m4 (gl_FUNC_FACCESSAT): Replace faccessat if
    lstat dereferences symlinks, since faccessat is likely to
    have the same problem.
    * m4/unistd_h.m4 (gl_UNISTD_H_DEFAULTS): Default REPLACE_ACCESSAT.
    * modules/faccessat (Depends-on): Add fstatat.
    Depend if REPLACE_FACCESSAT is 1, too.
    (configure.ac): Link if REPLACE_FACCESSAT is 1.
    * modules/faccessat-tests (Depends-on): Add symlink.
    * modules/unistd (unistd.h): Substitute REPLACE_FACCESSAT.
    * tests/test-faccessat.c (main): Test for the bug.