Skip to content
GitLab
Switch branch/tag
  1. 13 Dec, 2018 1 commit
  3. 14 Nov, 2018 2 commits
    • NIIBE Yutaka's avatar
      libassuan.vers: Remove duplicates. · eac43aad
      NIIBE Yutaka authored 
      

Signed-off-by: NIIBE Yutaka's avatarNIIBE Yutaka <gniibe@fsij.org>
      eac43aad
    • NIIBE Yutaka's avatar
      server: Don't call _assuan_waitpid on server side. · 81536080
      NIIBE Yutaka authored 
      * src/server.c (_assuan_server_finish): Never call waitpid here.
* src/assuan-socket-server.c (accept_connection_bottom): Indentation.

--

The waitpid/wait only makes sense by parent catching its child
process.

Since the commit 93595de1 (for version
0.6.5, in 2004-04-21), CTX->PID on server side has client PID.

In the commit cb53f862

 (2009-11-19),
call of _assuan_waitpid was introduced in assuan_server_finish, but
this call always fails because the process is not a child process of
server.

(If we could catch exit of non-child process, it might cause a dead
lock, since client does call waitpid too.)

The indentation fix is to show the place where PID is assigned.

Signed-off-by: NIIBE Yutaka's avatarNIIBE Yutaka <gniibe@fsij.org>
      81536080
  5. 13 Nov, 2018 1 commit
  7. 08 Nov, 2018 1 commit
    • NIIBE Yutaka's avatar
      socket: Use union for sockaddr access. · ea69c712
      NIIBE Yutaka authored 
      

* src/assuan-socket.c (socks5_connect, use_socks): Use union
to access, instead of using cast to the pointer.

--

In some machine like 32-bit ARM, alignment requirement of struct
sockaddr and struct sockaddr_in (or struct sockaddr_in6) is different.

Although it is completely valid to use the value of the address by
cast here, because the object should be allocated by struct
sockaddr_in or struct sockaddr_in6 to be referred by struct
sockaddr *.  But compiler doesn't assume such a usage, thus, emits
warnings.

The API with struct sockaddr * is a bit difficult thing.  I examined
GNU C library for the implementation of the connect function, it uses
transparent union, the GCC feature.  It would be too much, if we do
same thing here.

Signed-off-by: NIIBE Yutaka's avatarNIIBE Yutaka <gniibe@fsij.org>
      ea69c712
  9. 02 Nov, 2018 1 commit
  11. 29 Oct, 2018 1 commit
  13. 26 Oct, 2018 4 commits
  15. 25 Oct, 2018 4 commits
  17. 24 Oct, 2018 6 commits
  19. 14 Sep, 2018 1 commit
  21. 27 Mar, 2018 1 commit
  23. 26 Feb, 2018 1 commit
  25. 23 Feb, 2018 1 commit
  27. 20 Feb, 2018 1 commit
    • NIIBE Yutaka's avatar
      Better credential support for other OSes. · 0ad3aafe
      NIIBE Yutaka authored 
      

* configure.ac (HAVE_UCRED_H, HAVE_SYS_UCRED_H): Check these headers
unconditionally.
(HAVE_SO_PEERCRED, HAVE_LOCAL_PEEREID): Remove.
(HAVE_STRUCT_SOCKPEERCRED_PID): New.
(HAVE_GETPEEREID): New.
* src/assuan-socket-server.c (accept_connection_bottom): Add
support for OpenBSD, macOS, and FreeBSD.

--

Code in gpg-agent/command-ssh.c are integrated.

Signed-off-by: NIIBE Yutaka's avatarNIIBE Yutaka <gniibe@fsij.org>
      0ad3aafe
  29. 07 Dec, 2017 6 commits
  31. 06 Dec, 2017 1 commit
  33. 01 Dec, 2017 2 commits
  35. 30 Nov, 2017 1 commit
  37. 20 Nov, 2017 1 commit
  39. 16 Nov, 2017 2 commits
  41. 15 Nov, 2017 1 commit