* configure.ac: Set LT version to C24/A24/R2.

--

Signed-off-by: Werner Koch <wk@gnupg.org>

* src/w32-estream.c (reader): Use standard free.
(writer): Ditto.
--

There are two errors: The minor one is that we allocated with calloc
but released with _gpgrt_free.  The major one is the recursive use of
npth_unprotect due to the syscall_clamp mechanism:

1. Around the call to _gpgrt_w32_poll

2. By gpgrt_lock_lock on behalf of a the custom allocation handler in
   the worker threads at their _gpgrt_free.

This problem was exhibited by GnuPG's dirmngr component.

GnuPG-bug-id: 3937
Signed-off-by: Werner Koch <wk@gnupg.org>

emma peel authored Apr 15, 2018 and Daniel Kahn Gillmor committed May 01, 2018

Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>

--

* configure.ac: Bump LT version to C24/A/24/R1.

Signed-off-by: Werner Koch <wk@gnupg.org>

* Makefile.am: Add release and sign-release targets.

Signed-off-by: Werner Koch <wk@gnupg.org>

* src/estream.c (_gpgrt_poll) [W32]: Use syscall clamp.

Signed-off-by: Werner Koch <wk@gnupg.org>

--

* doc/Makefile.am: Fix target of yat2m-for-build.

--

GnuPG-bug-id: 3901
Fixes-commit: efc47693


Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>

* configure.ac: Check inet_addr for -lnsl, and socket for -lsocket.

--

Once I used LIB_SOCKET_NSL for the variable name, but it is already
used by AX_LIB_SOCKET_NSL in autoconf-archive as an alias of the
macro.  So, I changed the variable name.

GnuPG-bug-id: 3869
Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>

[[PGP Signed Part:Good signature from AA4373E6C82C78AD Damien Goutte-Gattat <dgouttegattat@incenp.org> (trust undefined) created at 2018-04-11T17:05:27+0200 using RSA]]
[1. text/plain]

* doc/Makefile.am (yat2m-stamp): Depend on version.texi.
--

When building from a cloned Git repository and with `make -j 3`
(or higher), the version.texi file may not have been generated
yet when yat2m is called to generate the man page, resulting in
a build failure.

Signed-off-by: Damien Goutte-Gattat <dgouttegattat@incenp.org>

--

* configure.ac: Bump LT version to C24/A24/R0.

Signed-off-by: Werner Koch <wk@gnupg.org>

--

Signed-off-by: Werner Koch <wk@gnupg.org>

* src/gpg-error.h.in (ARGPARSE_end): Simplify.
* src/argparse.c (_gpgrt_argparse_internal_s): Add field opts.
(deinitialize): Release new field.
(initialize): Add arg opts and create a copy of the option list.  Add
the internal options.
(_gpgrt_argparse): Rename arg opts to opts_orig and set new local var
opts.  Adjust all references to opts.
(find_long_option): Adjust for chnaged type of OPTS.  Re-indent.
(arg_parse): Remove internal option assignment.  Rename arg opts to
opts_orig and set new local var opts.  Adjust all references to opts.
(show_help): Adjust all references to opts.
--

The old ARGPARSE_end maro was a bit cumbersome and does not allow to
chnage the number of internal options.  Thus this somewhat larger
chnage to keep the internal options out of the API.

Note that with this change the internal options now also work in a
option file and not just on the command line; that does not make much
sense but is probably less surprising.

Signed-off-by: Werner Koch <wk@gnupg.org>

--

Fixes-commit: efc47693


Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>

* configure.ac (HAVE_YAT2M): New.
* doc/Makefile.am [CROSS_COMPILING]: Supported.

--

Makefile portability is also improved.

Fixes-commit: 4dc6d4d2


Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>

--

--

Why don't they return useful error messages????

--

--

--

--

--

--

* doc/yat2m.c (evaluate_conditions): Mark args unused
(proc_texi_cmd): Avoid shadowing warning.

Signed-off-by: Werner Koch <wk@gnupg.org>

--

* src/b64enc.c: Change to fit into libgpg-error.
* src/Makefile.am: Add b64enc.c
* src/b64dec.c: Use xtrymalloc etc.  Always use gpg_err_code_t.
(_gpgrt_b64dec_start): Set decoder flag
(_gpgrt_b64dec_finish): Check for conflict.
(_gpgrt_b64state): Move to ...
* src/gpgrt-int.h: here.  Add new fields.
* src/visibility.c (gpgrt_b64enc_start): New.
(gpgrt_b64enc_write): New.
(gpgrt_b64enc_finish): New.
* src/gpg-error.vers, src/gpg-error.def.in: Add new functions.
* src/gpg-error.h.in: Ditto.
* src/visibility.h: Ditto.

* tests/t-b64dec.c: Remove.
* tests/t-b64.c: New.
* tests/Makefile.am (TESTS): Replace t-b64dec by t-b64.
--

Signed-off-by: Werner Koch <wk@gnupg.org>

--

This is from GnuPG commit fa0ed1c7e2eee7c559026696e6b21acc882a97aa
with two tabs replaced by spaces.

Signed-off-by: Werner Koch <wk@gnupg.org>

* configure.ac (YAT2M): Require it when cross compiling.
* doc/Makefile.am (bin_PROGRAMS): Add yat2m.

--

Before 1.28, yat2m used to be an internal tool.  Now, it's a standard
tool.  For native build, it is built and used for initial
installation.  For cross build, it is required on the build system.

Signed-off-by: NIIBE Yutaka <gniibe@fsij.org>

--

This was due to the removal of the "%s: " used for the prefix in a
printf.  It is now printed with log_error which prints the prefix on
its own.

Signed-off-by: Werner Koch <wk@gnupg.org>

Signed-off-by: Werner Koch <wk@gnupg.org>

* src/gpg-error.c (show_usage): Remove.
(my_strusage): New.
(main): Change to use argparse.  Also use log_error.

Signed-off-by: Werner Koch <wk@gnupg.org>

* src/visibility.c (gpgrt_usage): New.

Signed-off-by: Werner Koch <wk@gnupg.org>

* src/visibility.c (gpgrt_argparse): New.
(gpgrt_strusage): New.
(gpgrt_set_strusage): New.
(gpgrt_set_usage_outfnc): New.
(gpgrt_set_fixed_string_mapper): New.
* src/gpg-error.def.in, src/gpg-error.vers: Add new functions.
* src/gpg-error.h.in: Add ARGPARSE macros from the former argparse.h.
(gpgrt_argparse_t): New.
(gpgrt_opt_t): New.
* configure.ac (AH_BOTTOM): Request argparse macros.
* src/Makefile.am (libgpg_error_la_SOURCES): Add argparse.c.
* src/argparse.h: Remove.
* src/argparse.c: Revamp to fit into libgpg-error.
(_gpgrt_argparse): New.
(_gpgrt_usage): Rename from usage.
(_gpgrt_strusage): Rename from strusage.  Define two new levels and
templates for three common licenses.
(_gpgrt_set_strusage): Rename from set_strusage.
(_gpgrt_set_usage_outfnc): New.
(_gpgrt_set_fixed_string_mapper): New.

* tests/t-argparse.c: New.
--

These functions are in use by GnuPG and other software for 20 years
and it makes sense to have them always available instead of copying
and maintaing the source in several projects.  Note that there are
minor changes in the API compared to GnuPG.

Signed-off-by: Werner Koch <wk@gnupg.org>

--

* src/logging.c (_gpgrt_log_printhex): Provide a dummy arg instead of
NULL.
--

Fix
Suggested-by: Jakub Wilk <jwilk@jwilk.net>

Signed-off-by: Werner Koch <wk@gnupg.org>

* src/w32-add.h: Remove hack to define pid_t.
* src/gpg-error.h.in: Eval macro to define pid_t.
* src/mkheader.c (have_sys_types_h, sys_types_h_included): New.
(parse_config_h): Test for sys/types.h.
(write_special): Protect inclusion of sys/types.h.  Define new macro
'define:pid_t'.
--

Regression-due-to: 1865c0ba


Signed-off-by: Werner Koch <wk@gnupg.org>