1. 22 Sep, 2013 1 commit
    • Philippe Teuwen's avatar
      Verify return of nfc_device_set_property_bool() · a4f466df
      Philippe Teuwen authored
      Problem reported by Coverity:
      CID 1090325 (#1 of 1): Unchecked return value (CHECKED_RETURN)
        unchecked_value: No check of the return value of "nfc_device_set_property_bool(pnd, NP_AUTO_ISO14443_4, false)".
      a4f466df
  2. 21 Sep, 2013 1 commit
    • Philippe Teuwen's avatar
      Verify return of nfc_device_set_property_bool() · d9b531f5
      Philippe Teuwen authored
      Problem reported by Coverity
      CID 1090319 (#1 of 1): Unchecked return value (CHECKED_RETURN)
        unchecked_value: No check of the return value of "nfc_device_set_property_bool(pnd, NP_EASY_FRAMING, nt.nti.nai.btSak & 0x20)".
      CID 1090320 (#1 of 1): Unchecked return value (CHECKED_RETURN)
        unchecked_value: No check of the return value of "nfc_device_set_property_bool(dev, NP_HANDLE_CRC, false)".
      CID 1090324 (#1 of 2): Unchecked return value (CHECKED_RETURN)
        unchecked_value: No check of the return value of "nfc_device_set_property_bool(pnd, NP_ACTIVATE_FIELD, true)".
      CID 1090325 (#1 of 1): Unchecked return value (CHECKED_RETURN)
        unchecked_value: No check of the return value of "nfc_device_set_property_bool(pnd, NP_AUTO_ISO14443_4, false)".
      d9b531f5
  3. 17 Jul, 2013 1 commit
  4. 09 Apr, 2013 1 commit
  5. 05 Apr, 2013 1 commit
  6. 12 Mar, 2013 6 commits
  7. 10 Mar, 2013 1 commit
  8. 07 Mar, 2013 1 commit
    • Alex Lian's avatar
      Convert by value passing of nfc_target to pointer for str_nfc_target and... · c72846e3
      Alex Lian authored
      Convert by value passing of nfc_target to pointer for str_nfc_target and nfc_initiator_target_is_present
      
      This becomes more consistent with all other pass by pointer of most structures.
      Additionally, this should lessen stack memory usage, as building strings with str_nfc_target would push the target (283 bytes) plus then a copy of the info objects (up to 275) onto the stack as it dives into the sprintf functions.
      
      Lastly, this makes my attempt at a .NET wrapper easier, as I can make passing by pointer work, but passing by value seems to bomb on the interop right now.
      c72846e3
  9. 06 Mar, 2013 1 commit
  10. 05 Mar, 2013 3 commits
    • Philippe Teuwen's avatar
      Fix cppcheck style: scope of variable can be reduced · 47693921
      Philippe Teuwen authored
      Fix the following cppcheck warnings:
      [libnfc/drivers/pn532_uart.c:492]: (style) The scope of the variable 'res' can be reduced
      [libnfc/chips/pn53x.c:320]: (style) The scope of the variable 'res' can be reduced
      [libnfc/chips/pn53x.c:616]: (style) The scope of the variable 'res' can be reduced
      [libnfc/nfc.c:356]: (style) The scope of the variable '_device_found' can be reduced
      [utils/nfc-mfclassic.c:178]: (style) The scope of the variable 'key_index' can be reduced
      47693921
    • Philippe Teuwen's avatar
    • Philippe Teuwen's avatar
      Error conditions in utils & examples: fix leaks, unify style (see details) · bece73fa
      Philippe Teuwen authored
      * in main():
      ** errx()/err()/return -> exit()
      ** return values -> EXIT_SUCCESS & EXIT_FAILURE
      
      * out of main:
      ** err()/errx()/exit() -> return
      ** change retval from size_t to int to allow returning errors
      ** don't use EXIT_SUCCESS / EXIT_FAILURE as retvals
      
      * add nfc_close() & nfc_exit() to exit() on errors
      * add missing fclose() on errors
      * add missing test if (pnd == NULL)
      * unify style if (pnd == / != NULL)
      * remove goto's
      * few related fixes
      * remove if(pnd!=NULL) test on nfc_close() calls
      bece73fa
  11. 02 Mar, 2013 2 commits
  12. 01 Feb, 2013 1 commit
  13. 04 Dec, 2012 1 commit
  14. 24 Nov, 2012 1 commit
  15. 21 Oct, 2012 1 commit
  16. 17 Sep, 2012 1 commit
  17. 03 Jun, 2012 1 commit
  18. 29 May, 2012 4 commits
  19. 27 May, 2012 1 commit
  20. 01 Mar, 2012 1 commit
  21. 15 Feb, 2012 1 commit
  22. 18 Jan, 2012 3 commits
  23. 17 Jan, 2012 2 commits
  24. 15 Jan, 2012 1 commit
  25. 05 Jan, 2012 2 commits