Drop reload support from systemd unit files

Lucas Kanashirorequested to merge
kanashiro/openvpn:drop-systemd-reload-support into master

The current reload implementation (sending a SIGHUP signal to the process) fails, and the difference between reload and restart is not clear. Systemd does not require an implementation for reload.

Currently, the ExecReload= tries to send a SIGHUP signal to the process but it does not have the permission to do this. It'd need a new capability (CAP_KILL) or a + prefix to run this command with full privileges. However, after trying the mentioned solutions I noticed that actually the SIGHUP signal handling implementation does something similar to the restart process, not justifying the existence of the reload implementation. Moreover, systemd does not require a reload implementation, so I believe dropping this systemd reload support is the way to go.

For more context please take a look at this bug report:

https://bugs.launchpad.net/ubuntu/+source/openvpn/+bug/1868127

Merge request reports