Skip to content
Snippets Groups Projects

Add ostree-boot package (#824650)

Merged Felix Krull requested to merge (removed):ostree-boot into debian/experimental
1 unresolved thread

These changes enables the ostree-boot package. See here for binaries:

https://code.launchpad.net/~fkrull/+archive/ubuntu/ostree-boot

(Yes, it's technically built for Ubuntu, but Launchpad was what I had. It shouldn't make a difference.)


I ended up splitting the package further into ostree-boot and ostree-grub2; the former contains the dracut and systemd boot stuff, the latter contains only the GRUB integration. This means you can install ostree-grub2 on a regular Debian system and have the grub.cfg generation work, without also getting the boot files.

I also weakened the Depends on dracut to a Recommends. That's mostly because the initramfs generators conflict each other, but the systemd bits in ostree-boot might still be useful without dracut.


https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=824650

Edited by Felix Krull

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
179 176 - the boot loader must be one that is supported by libostree, currently
180 177 GNU GRUB 2, syslinux/extlinux or Das U-Boot
181 178
179 Package: ostree-grub2
  • Instead of splitting out the grub2 integration to a separate subpackage, can they just be conditional for x86 or something? The rest of the pieces of this package are very much for booting systems. For example, ostree-prepare-root and ostree-remount are explicitly about how ostree mounts things in early boot. I don't see how this package is useful if you're not planning to run an ostree system on your host. And if you are, then you surely want a bootloader?

    If you don't actually run grub on your host, then these are just files on disk. If you're trying to deploy to your host and ostree doesn't find grub, then it will not choose it as the bootloader. I think it was the right decision to go with a single ostree-boot package and not worry about mucking with having specific bootloader integration in separate packages.

    Edited by Dan Nicholson
  • The reasoning was sort of the other way around: say you have a Debian system that isn't OSTree, but controls the bootloader for other OSTree-based systems. On your OSTree system you need both, but if all you want is create GRUB entries for OSTree-based systems, you only need the -grub package. However, it's not a big deal to me either way, I'm perfectly fine with either option.

  • Sorry about the delay in reviewing this - my use of libostree has been entirely for Flatpak and similar non-OS deployments. Now that buster is released and unstable is not frozen, it seems like a good time to get this change into Debian via experimental.

    I think I'm inclined to go with what @dbnicholson-guest said, and keep it relatively simple, with only one extra binary package.

  • changed this line in version 5 of the diff

  • Alright, I rebased and took out the separate ostree-grub2 package.

    I haven't worked on ostree things recently, but the package itself should still work if one does the legwork to bake it into an OS.

  • Please register or sign in to reply
  • Felix Krull added 174 commits

    added 174 commits

    • b11beb17...6e099593 - 171 commits from branch debian:debian/master
    • 9572f7e4 - Enable ostree-boot package
    • 6262b20f - ostree-boot: weaken dracut Depends to Recommends
    • fd183489 - Split ostree-grub2 from ostree-bootThe GRUB2 files are useful on a non-ostree...

    Compare with previous version

  • I have a version of this that is on my queue to test soon, but it was preempted by uploading the ostree version that it was based on. Please don't spend time on this right now (unless you particularly want to).

  • Simon McVittie changed target branch from debian/master to debian/experimental

    changed target branch from debian/master to debian/experimental

  • Simon McVittie mentioned in commit e786f314

    mentioned in commit e786f314

  • Please register or sign in to reply
    Loading