* autogen.rc: Add gpg-error and libassuan prefix options.
* w32/Makefile.am (AM_CPPFLAGS): Use COMMON_FLAGS.
(pinentry_w32_LDADD): Use COMMON_LIBS.

* pinentry/pinentry-curses.c: pkg-config finds the correct include
paths so should not hard-wire the path for the ncursesw header file.

* emacs/Makefile.am (LDADD): Don't link against ../assuan/libassuan.a.
We now use the system libassuan.

* pinentry/pinentry-curses.c (dialog_input): Recognize ASCII DEL as
backspace.

--
Reported-by chdiza
GnuPG-bug-id: 2020

* configure.ac: Add --enable-pinentry-emacs and
--enable-inside-emacs option.
(BUILD_LIBPINENTRY_EMACS): New conditional.
(BUILD_PINENTRY_EMACS): New conditional.
(INSIDE_EMACS): New conditional.
* Makefile.am (pinentry_emacs): New.
(SUBDIRS): Add "emacs" subdir if PINENTRY_EMACS is set.

* pinentry/pinentry-emacs.h: New file.
* pinentry/pinentry-emacs.c: New file.
* pinentry/Makefile.am: New file.
* pinentry/pinentry.c (option_handler): Handle the allow-emacs-prompt
Assuan option.

* emacs/pinentry-emacs.c: New file.
* emacs/Makefile.am: New file.

* gnome3/pinentry-gnome3.c (main): Use gtk_init_check instead of
gtk_init.  If it fails, fallback to the curses frontend.

* pinentry/pinentry.h (pinentry_cmd_handler_t): Fix comment.

* doc/pinentry.texi (Implementation Details): Describe default-prompt.

* assuan/ChangeLog-old: Remove file.
* assuan/Makefile.am: Remove file.
* assuan/README.1st: Remove file.
* assuan/assuan-buffer.c: Remove file.
* assuan/assuan-defs.h: Remove file.
* assuan/assuan-handler.c: Remove file.
* assuan/assuan-listen.c: Remove file.
* assuan/assuan-pipe-server.c: Remove file.
* assuan/assuan-util.c: Remove file.
* assuan/assuan.h: Remove file.
* assuan/mkerrors: Remove file.

* configure.ac: Check for libgpg-error and libassuan.
(COMMON_CFLAGS): Add $GPG_ERROR_CFLAGS and $LIBASSUAN_CFLAGS.
(COMMAND_LIBS): Add $GPG_ERROR_LIBS and $LIBASSUAN_LIBS.
(GPG_ERR_ENABLE_GETTEXT_MACROS): Define this macro.
(GPG_ERR_ENABLE_ERRNO_MACROS): Likewise.
(GNUPG_LIBASSUAN_VERSION): Likewise.
(AC_CONFIG_FILES): Don't generate assuan/Makefile.
(config.h): Define GPG_ERR_SOURCE_DEFAULT.
* Makefile.am (SUBDIRS): Remove assuan.
* curses/Makefile.am (LDADD): Remove ../assuan/libassuan.a.
* gnome3/Makefile.am (AM_CPPFLAGS): Remove -I$(...

* qt4/qsecurelineedit.cpp (QSecureLineEdit::sizeHint),
(QSecureLineEdit::minimumSizeHint): Remove unused Q_D macros.
(QSecureLineEdit::setCursorPosition, QSecureLineEditPrivate::setText),
(QSecureLineEditPrivate::hasAcceptableInput): Explicitly cast length to int.
(QSecureLineEditPrivate::maskString): Use unsigned type for strIndex.
(QSecureLineEditPrivate::maskString): Remove uneccesary casts.
* qt4/secstring.cpp (toUtf8): Remove unused variable.

* gnome3/pinentry-gnome3.c (create_prompt) [HAVE_LIBSECRET]: Only show
the libsecret prompt in this case.
(gnome3_cmd_handler) [HAVE_LIBSECRET]: Set PE->MAY_CACHE_PASSWORD
according to the user's choice.

--

* secmem/secmem.c (secmem_malloc): Only clear the user memory; don't
clear beyond the end of the buffer.

* pinentry/pinentry.c (pinentry_setbufferlen): When the pin buffer is
already large enough, return the buffer instead of NULL.

--

Signed-Off-By: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Debian-Bug-Id: 787639

* configure.ac: Add GCC specific -W flags.
--

Note that --enable-maintainer-mode is required to see all warnings.

* pinentry/password-cache.c (password_cache_clear): use g_debug safely
  in case error->message is malformed.

--

Without this change, with -Werror=format-security, we see:

password-cache.c: In function ‘password_cache_clear’:
password-cache.c:153:7: error: format not a string literal and no format arguments [-Werror=format-security]
       g_debug(error->message);
       ^

--

This is probably just a workaround. Proper fix is being investigated.
See:
https://bugzilla.redhat.com/show_bug.cgi?id=589532
http://stackoverflow.com/questions/2788518/calling-activatewindow-on-qdia
--

GnuPG-bug-id: 1981

* m4/pkg.m4: Print the moule name not the variable name.
--

We now show

  checking for ncursesw... no
  checking for ncurses... yes

instead of

  checking for ncurses... no
  checking for ncurses... yes

--

qt/ was the QT3 version.

--

--

* pinentry/password-cache.c (password_cache_clear): s/debug/g_debug/.
* pinentry/pinentry-curses.c (dialog_input): Actually bail out.
(dialog_run) [!HAVE_NCURSESW]: Define alt.

* gtk+-2/pinentry-gtk-2.c (create_window): Make sure the check button
to save the passphrase externally is not checked by default.

* pinentry/password-cache.c (password_cache_clear): New function.
* pinentry/password-cache.h (password_cache_clear): New declaration.
* pinentry/pinentry.c (cmd_getinfo): New function.
(register_commands): Have the Assuan command "CLEARPASSPHRASE" call
it.

* pinentry/pinentry.c (cmd_getpin): If PINENTRY.ERROR is not NULL,
don't read the password from the cache.

* pinentry/pinentry-curses.c (MAKE_BUTTON): When creating the button
text, respect underscores.

* pinentry/pinentry-curses.c (dialog_input): Make control-l repaint
the screen.

* pinentry/pinentry-curses.c (dialog_input): Add control-h an alias
for backspace.

* m4/curses.m4: When checking for ncurses, first try using
PKG_CHECK_MODULES.

--
Patch-By: Alon Bar-Lev

* gtk+-2/pinentry-gtk-2.c (main): Use gtk_init_check instead of
gtk_init.  If gtk_init_check fails, fallback to the curses backend.

--

Reported-by: Daniel Kahn Gillmorr <dkg@fifthhorseman.net>.  Closes
issue #1982.

* pinentry/pinentry-curses.c (dialog_input): Take additional argument,
alt.  Update callers.  If passed control-u, erase the whole line.  If
passed alt-backspace or control-w, erase any white space the the
previous word.
(dialog_run): Detect when alt is pressed.

* secmem/secmem.c (secmem_malloc): In case wipememory2 gets optimized
away in secmem_free, clear the buffer before returning it.

* pinentry/pinentry-curses.c (dialog_run): NUL terminate the pin entry
buffer.