--

This extends
commit 3d02645d

* assuan/assuan.h (ASSUAN_Too_Short): New
(ASSUAN_ENOENT, ASSUAN_ENOTTY): New.
* pinentry/pinentry-curses.c: Include assuan.h.
(dialog_create, dialog_run): Set specific error codes.
* pinentry/pinentry.h (struct pinentry): Add field specific_err.
* pinentry/pinentry.c (cmd_getpin): Return specific_err.
(cmd_confirm, cmd_message): Ditto.
--

GnuPG-bug-id: 1463

* pinentry/pinentry-curses.c (dialog_run): Cleanup on dialog_create
error.
--

This may happen due to a too small tty.  We need to cleanup in this
case to keep the tty in a usable state.

GnuPG-bug-id: 1383

* pinentry/pinentry.h (struct pinentry): Add field default_pwmngr.
* pinentry/pinentry.c (option_handler): Set it.
* gtk+-2/pinentry-gtk-2.c (create_window) [HAVE_LIBSECRET]: Use new
string.

* pinentry/password-cache.c (keygrip_to_label): Don't use asprintf.

* doc/pinentry.texi: Improve description of SETKEYINFO's format.

* configure.ac (COMMON_CFLAGS): New variable.  AC_SUBST it.
(COMMON_LIBS): Likewise.  AC_SUBST it.
(LIBSECRET_CFLAGS): Likewise.
(LIBSECRET_LIBS): Likewise.
(--enable-libsecret): Add option to enable support for libsecret.  If
enabled, check for its presense.
* pinentry/password-cache.h: New field.
* pinentry/password-cache.c: New field.
* pinentry/pinentry.h (struct pinentry): Add fields pin_from_cache,
allow_external_password_cache, tried_password_cache, keyinfo, and
may_cache_password.
* pinentry/pinentry.c: Include "password-cache.h".
(pinentry): Initialize new fields.
(option_handler): Handle the "allow-external-password-cache" option.
(cmd_setkeyinfo): Implement it.
(cmd_getpin): Read the password from the cache, if appropriate.  Save
it to the cache, if appropriate.
* pinentry/Makefile.am (AM_CPPFLAGS): Add $(COMMON_CFLAGS).
(LDADD): Add $(COMMON_LIBS).
(libpinentry_a_SOURCES): Add password-cache.h
password-cache.c.
* gtk+-2/pinentry-gtk-2.c (may_save_passphrase_toggled): New function.
(create_window): Take additional parameter, the pinentry's context.
Update callers.
[HAVE_LIBSECRET]: Show a checkbox asking whether the passphrase should
be saved.
* gtk+-2/Makefile.am (AM_CPPFLAGS): Add $(COMMON_CFLAGS).
(LDADD): Add $(COMMON_LIBS).
* curses/Makefile.am (AM_CPPFLAGS): Add $(COMMON_CFLAGS).
(LDADD): Add $(COMMON_LIBS).
* tty/Makefile.am (AM_CPPFLAGS): Add $(COMMON_CFLAGS).
(LDADD): Add $(COMMON_LIBS).
* doc/pinentry.texi (Protocol): Update documentation.  Describe the
protocol and provide some justification.

* autogen.rc: Remove obsolete options.

* secmem/secmem.c (secmem_realloc): If passed a NULL pointer, then
call secmem_malloc instead of crashing.

* w32/main.c (set_bitmap): New.
(dlg_proc): Show error prompt in red.
* w32/pinentry-w32.rc: Add icons and chnage dialog.
* w32/logo-128.bmp: New.
* w32/logo-32.bmp: New.
* w32/logo-48.bmp: New.
* w32/logo-64.bmp: New.
* w32/logo-96.bmp: New.

--

The logos need some manual tweaking.  Due to the scaling a gradient is
used for the circle and Windows shows white ugly white spots.  This
can be avoided by using a a palette with less colors but I found no
easy way to do that in gimp.  When using less than 256 index the
transparency feature does not work correctly.

--

These files are not in use for more than a decade.  Their indented
purpose was to sign source files.  With GIT we have a way better
system to detect tampering of the source.

* tty/pinentry-tty.c (read_password): Use default prompt also for an
empty prompt argument.
--

strlen(prompt)-1 is used thus we need to make sure that
the length is > 0.

Improve documentation: clean up wording and add some minor
improvements to the content.

--

* tty/pinentry-tty.c (tty_cmd_handler): Add comment.

--

* tty/pinentry-tty.c (read_password): Handle backspace.

--

* tty/pinentry-tty.c (read_password): Improve prompt for pin.

--

* pinentry/pinentry-curses.c: free internally allocated local string.

* tty/pinentry-tty.c: treat the situation where no PIN is requested
  and one_button is not set as a confirmation prompt.

--

When user confirmation is requested on a dumb terminal, we use the
value of the "OK" button followed with [y/N]? as the confirmation
prompt.  User typing is echoed as normal, since a confirmation prompt
is not a password entry.

* tty/pinentry-tty.c: avoid prompting for a PIN when one was not asked
  for.

--

Before this, pinentry-tty would segfault when asked for MESSAGE or
CONFIRM:

0 dkg@alice:~$ pinentry-tty
OK Your orders please
SETDESC testing testing
OK
MESSAGE
testing testing
PIN? :
Segmentation fault
139 dkg@alice:~$

* tty/pinentry-tty.c: reorganize, wrapping read_password in tty
  open/close.

--

This patch sets the stage to simplify the subsequent fixes.

* gtk+-2/pinentry-gtk-2.c: Include gdk/gdkkeysyms.h.
(enter_callback): Pass confirm_value_t to button_clicked.
(confirm_button_clicked): Use confirm_value_t cast.
(cancel_callback): New.
(create_window): Add accelerator for the Escape key.
--

GnuPG-bug-id: 1453

Original patch slighty modified by wk.

* pinentry/pinentry.c (cmd_setkeyinfo): New.
(register_commands): Addd command.

Signed-off-by: Werner Koch <wk@gnupg.org>

--

* pinentry/pinentry.c: Do not include getopt.h.
* pinentry/pinentry-curses.c (dialog_run): Call use_default_colors
only with ncurses.

--

* pinentry/argparse.c, pinentry/argparse.h: New. Taken from GnuPG
master.
* pinentry/Makefile.am (libpinentry_a_SOURCES): Add them.
* pinentry/pinentry.c: Include argparse.h.
(usage): Remove.
(my_strusage): New.
(pinentry_parse_opts): Rewrite.  Do not return a value.  Change call
callers.
--

getopt_long is not generally available, for example it is missing on
AIX.  Instead of adding replacement code we use the option parser
from GnuPG and thus also gain a better --version and --help.

Signed-off-by: Werner Koch <wk@gnupg.org>

* pinentry/pinentry-curses.c (collect_line): Change second arg to CH.
* pinentry/pinentry.c (pinentry_utf8_to_local): Make args const.

Signed-off-by: Werner Koch <wk@gnupg.org>

    * configure.ac: Disable pinentry-qt4 or exit if moc not found.
    * m4/qt.m4: Look for and prefer moc-qt4.
    * qt4/Makefile.am: Add moc files to nodist and clean them.

--

    Files generated by MOC vary over the used Qt versions
    (even inside a Major release). Distributing them leads to
    errors if a different qt version is installed.

    GnuPG-bug-id: 1784

    * doc/gpl.texi: Use version from gcrypt.

--
   This fixes build errors with texinfo 5.2

Check if the Qt libraries have support for QT Accessibility before using
it. Otherwise it will raise error like these one:

main.cpp: In function 'int qt_cmd_handler(pinentry_t)':
main.cpp:220:51: error: 'class QAbstractButton' has no member named
'setAccessibleDescription'

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>