Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • P piuparts
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • DebianDebian
  • piuparts
  • Merge requests
  • !35

d/rules: set GO111MODULE to auto

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Athos Ribeiro requested to merge athos/piuparts:go1.16-compat into develop Jul 09, 2021
  • Overview 5
  • Commits 2
  • Pipelines 0
  • Changes 2

This will ensure pre Go 1.16 behavior is maintained once Debian migrates to Go 1.16.

piuparts will fail to build with Go 1.16 otherwise [1].

Here is the relevant bit of Go 1.16 changelog [2].

Another option here would be turning the relevant (go) helper into a module. Given its size and context here, I thought it would be better to just set the environment variable in question. Let me know if there are any issues with the current approach.

[1] https://launchpad.net/ubuntu/+source/piuparts/1.1.3/+build/21477124 [2] https://golang.org/doc/go1.16#go-command

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: go1.16-compat