@anbe, @holger I didn't want to commit directly to develop branch. I wanted to create a merge request first. Sorry. For context, see https://salsa.debian.org/samba-team/samba/-/jobs/55820 (from samba-team/samba!10)

See also the debootstrap commit message: https://salsa.debian.org/installer-team/debootstrap/commit/c997b80c064c6c1d36ec69da1850722f795f43e4. Revert if you need more discussion.

Hi Mathieu, > @anbe, @holger I didn't want to commit directly to develop branch. I wanted to create a merge request first. Sorry. thanks for explaining. even more importantly: have you tested this change? > For context, see https://salsa.debian.org/samba-team/samba/-/jobs/55820 (from samba-team/samba!10) this is a bit long for context. please explain. I see " ERROR: BAD PERMISSIONS crw-rw-rw-. 1 root root 5, 2 Oct 16 03:49 /dev/ptmx" in there but then I dont see this on https://piuparts.debian.org/sid/source/s/samba.html so for now I'm just assuming your salsa runner environment is borken. Your commit message also said "Create /dev/ptmx like debootstrap does" and you pointed me to the blob, but not the commit where this was introduced... :/ an then piuparts is using debootstrap too, so why does piuparts need that code as well? Last and least, a debian/changelog entry would have been nice and I think I will make it mandatory via the CONTRIBUTING document. Because now the work would be on me to write a meaningful changelog entry which atm I cannot do, because... see above ;) So, yes, I think I will revert these commits (also we use develop to deploy this directly to piuparts.d.o) for now and would appreciate it very much if you could resubmit them via the BTS (or a gitlab MR) while including a debian/changelog entry. And finally: thank you for your contribution (even if the above..!) :) [signature.asc](/uploads/02a43493e528ffa6495fabfde5fb9a7c/signature.asc)