debian/changelog

+piuparts (0.91) unstable; urgency=medium
+
+  * Don't use --skip-logrotatefiles-test when testing sid and buster,
+    see #582630. (Closes: #604807)
+    Keep it for stretch, jessie, wheezy, squeeze and lenny based tests.
+  * piuparts.py:
+    - Add to ignored_files:
+      + /var/lib/sreview (Closes: #905500)
+    - Add alias '--ignore-regexp' for '--ignore-regex' as the former was
+      documented since 2005 while the latter was working since then.
+      Thanks to Nicolas Braud-Santoni for reporting. (Closes: #906683)
+  * Bump standards version to 4.2.1, no changes needed.
+
+ -- Holger Levsen <holger@debian.org>  Fri, 07 Sep 2018 19:35:35 +0200
+
 piuparts (0.90) unstable; urgency=medium
 
   [ Michael Stapelberg ]

debian/control

@@ -4,7 +4,7 @@ Uploaders:
  Holger Levsen <holger@debian.org>
 Section: devel
 Priority: optional
-Standards-Version: 4.2.0
+Standards-Version: 4.2.1
 Rules-Requires-Root: no
 Build-Depends:
  asciidoc,

htdocs/index.tpl

@@ -72,6 +72,11 @@
       News
      </td>
     </tr>
+    <tr class="normalrow">
+     <td class="contentcell2">
+      <b>2018-08-28</b>: Enable the logrotate test (temporarily) again, to check whether <a href="https://bugs.debian.org/582630" target="_blank">#582630</a> really has been fixed...
+     </td>
+    </tr>
     <tr class="normalrow">
      <td class="contentcell2">
       <b>2018-04-22</b> Move git repo to <a href="https://salsa.debian.org/debian/piuparts.git">salsa.debian.org</a>. Many thanks to the alioth.debian.org admins for providing such nice services so long!

instances/piuparts.conf-template.pejacevic

 [DEFAULT]
 # these are needed always
 flags-base =
-# see https://bugs.debian.org/604807
-	--skip-logrotatefiles-test
 # restrict to problems in the package being tested
 	--warn-on-others
 # default exceptions
@@ -41,7 +39,8 @@ flags-end-buster =
 
 # common flags for tests starting in stretch
 flags-start-stretch =
-# no flags needed
+# see #604807:
+	--skip-logrotatefiles-test
 
 # common flags for tests ending in stretch
 flags-end-stretch =
@@ -51,7 +50,8 @@ flags-end-stretch =
 
 # common flags for tests starting in jessie
 flags-start-jessie =
-# no flags needed
+# see #604807:
+	--skip-logrotatefiles-test
 
 # common flags for tests ending in jessie
 flags-end-jessie =
@@ -65,7 +65,8 @@ flags-end-jessie =
 
 # common flags for tests starting in wheezy
 flags-start-wheezy =
-# no flags needed
+# see #604807:
+	--skip-logrotatefiles-test
 
 # common flags for tests ending in wheezy
 flags-end-wheezy =
@@ -81,6 +82,8 @@ flags-start-squeeze =
 # up to squeeze a non-empty /etc/shells was shipped, actually installing
 # and removing a shell would remove its entry from /etc/shells
 	-i /etc/shells
+# see #604807:
+	--skip-logrotatefiles-test
 # squeeze has been archived
 	--no-check-valid-until
 
@@ -88,6 +91,8 @@ flags-start-squeeze =
 flags-end-squeeze =
 # extra fake-essential packages for successfully purging in squeeze
 	--scriptsdir /etc/piuparts/scripts-squeeze
+# see #604807:
+	--skip-logrotatefiles-test
 # squeeze has been archived
 	--warn-on-debsums-errors
 	--warn-on-install-over-symlink
@@ -99,6 +104,8 @@ flags-start-lenny =
 # up to squeeze a non-empty /etc/shells was shipped, actually installing
 # and removing a shell would remove its entry from /etc/shells
 	-i /etc/shells
+# see #604807:
+	--skip-logrotatefiles-test
 # lenny has been archived
 	--no-check-valid-until
 

piuparts.py

@@ -2,7 +2,7 @@
 # -*- coding: utf-8 -*-
 #
 # Copyright 2005 Lars Wirzenius (liw@iki.fi)
-# Copyright © 2007-2017 Holger Levsen (holger@layer-acht.org)
+# Copyright © 2007-2018 Holger Levsen (holger@layer-acht.org)
 # Copyright © 2010-2017 Andreas Beckmann (anbe@debian.org)
 #
 # This program is free software; you can redistribute it and/or modify it
@@ -337,6 +337,7 @@ class Settings:
             "/var/lib/onioncat/",       # onioncat
             "/var/lib/pkcs11proxyd/",   # caml-crush-server (#810703)
             "/var/lib/rbldns/",
+            "/var/lib/sreview/",        # sreview (#905500)
             "/var/spool/powerdns/",     # pdns-server (#531134), pdns-recursor (#531135)
             # work around broken symlinks
             "/etc/modules-load.d/modules.conf",  # -> ../modules (target obsoleted by modules-load.d)
@@ -2726,7 +2727,7 @@ def parse_command_line():
                            "ignored when comparing changes to chroot."
                            "FILENAMES prefixed with ':' will be reported verbosely.")
 
-    parser.add_option("-I", "--ignore-regex", action="append",
+    parser.add_option("-I", "--ignore-regex", "--ignore-regexp", action="append",
                       metavar="REGEX", default=[],
                       help="Add REGEX to list of Perl compatible regular " +
                            "expressions for filenames to be " +