CONTRIBUTING

@@ -24,6 +24,18 @@ One possible workflow:
   reportbug piuparts
   <describe the issue, attach the patch>
 
+
+Does and don'ts
+---------------
+
+Please do *not* push to the develop or master branch directly, unless
+explicitly asked for!
+
+Please always *do* include a debian/changelog entry with your patches.
+
+Please always *do* test your patches and state that you tested them.
+
+
 Contributing bugs to other projects
 -----------------------------------
 Another very useful type of contributions are filing bug reports based

Makefile

@@ -28,8 +28,8 @@ DOCS_GENERATED		 = piuparts.1 piuparts.1.html piuparts_slave_run.8 piuparts_slav
 define placeholder_substitution
 	sed -r \
 	-e 's/__PIUPARTS_VERSION__/$(version)/g' \
-	-e 's%@sharedir@%$(sharedir)%g' \
 	-e 's%@libdir@%$(libdir)%g' \
+	-e 's%@sharedir@%$(sharedir)%g' \
 	$< > $@
 endef
 

TODO

@@ -124,8 +124,6 @@ More ideas for even later:
 - make it possible to call aptitude (or similar) instead of apt-get and allow to
   override the commandline arguments.
 
-- rewrite piuparts-analyze to run over all sections and cache BTS responses
-
 - "decorate" (strike-through) bug links generated by piuparts-analyze to
   indicate resolved state (take package version into account!)
 

bug-templates/logrotate_exits_with_error_after_package_removal.mail

+To: submit@bugs.debian.org
+Subject: logrotate exits with error after package removal
+
+Package:
+Version:
+Severity: important
+User: debian-qa@lists.debian.org
+Usertags: piuparts
+
+Hi,
+
+during a test with piuparts I noticed your package's logrotate
+configuration causes logrotate to exit with an error after
+the package has been removed.
+
+From the attached log (scroll to the bottom...):
+
+
+
+cheers,

conf/crontab-master.in

@@ -10,7 +10,7 @@ PYTHONPATH=@libdir@/python2.7/dist-packages
 @reboot master_cleanup
 
 #
-# generate reports twice a day
+# generate reports twice or three times a day
 #  (dinstall runs 1|7|13|19:52, so this is long after mirror pushes...)
 #
 0  4-23/12 * * * piuparts-analyze
@@ -24,7 +24,7 @@ PYTHONPATH=@libdir@/python2.7/dist-packages
 0  3,15 * * * reschedule_oldest_logs
 
 #
-# monitor for problems once a day
+# monitor for problems several times day
 # - these may result in packages being retested
 # - if that's not the case, run them from within generate_daily_report
 #

custom-scripts/scripts-leftovers/pre_remove_preseed_cleanup

@@ -33,7 +33,8 @@ case ${PIUPARTS_OBJECTS%%=*} in
 		log_debug
 		echo "ifetch-tools ifetch-tools/purge boolean true" | debconf-set-selections
 		;;
-	mlmmj)  #668752
+	mlmmj)
+		#668752
 		log_debug
 		echo "mlmmj mlmmj/remove-on-purge boolean true" | debconf-set-selections
 		;;
@@ -41,6 +42,12 @@ case ${PIUPARTS_OBJECTS%%=*} in
 		log_debug
 		echo "pluxml pluxml/system/purgedata boolean true" | debconf-set-selections
 		;;
+	sympa)
+		#673972
+		log_debug
+		echo "sympa sympa/remove_spool boolean true" | debconf-set-selections
+		;;
+	####################################################################
 	ironic-common)
 		dbconfig_enable_purge ironic-common
 		;;

custom-scripts/scripts-lenny/post_remove_exceptions_lenny

@@ -11,6 +11,11 @@ case "$PIUPARTS_DISTRIBUTION" in
 esac
 
 case ${PIUPARTS_OBJECTS%%=*} in
+	apt-xapian-index)
+		# wait for update-apt-xapian-index in the background to finish
+		log_debug
+		sleep 30
+		;;
 	postgis)
 		#560409: postgis can't be purged if postgresql is no longer installed
 	        # (fails due to a missing directory)

custom-scripts/scripts-lenny/post_setup_lenny-fake-essential

@@ -17,6 +17,9 @@ case ${PIUPARTS_OBJECTS%%=*} in
 		# allow testing of the fake essential packages
 		exit 0
 		;;
+	console-log|systraq)
+		USED_DURING_PURGE="$USED_DURING_PURGE perl-modules"
+		;;
 	docbookwiki)
 		USED_DURING_PURGE="$USED_DURING_PURGE mysql-client"
 		;;

custom-scripts/scripts/is_testable_uninstallable

@@ -108,6 +108,7 @@ case ${PIUPARTS_OBJECTS%%=*}@${PIUPARTS_DISTRIBUTION} in
 	fossology-scheduler@squeeze|\
 	fossology-web@squeeze|\
 	fossology-web-single@squeeze)
+		# removed after squeeze
 		skip_distupgrade "#595593: fails to install"
 		;;
 	gclcvs@squeeze)

custom-scripts/scripts/post_chroot_unpack_allow_unauthenticated

+#!/bin/sh
+
+if [ "$PIUPARTS_DISTRIBUTION" = "lenny" ]; then
+	echo "Creating /etc/apt/apt.conf.d/unauthenticated-lenny ..."
+	# apt/lenny does not like comments ...
+	tee /etc/apt/apt.conf.d/unauthenticated-lenny <<EOF
+APT::Get::AllowUnauthenticated "true";
+Acquire::Check-Valid-Until "false";
+EOF
+fi
+
+if [ "$PIUPARTS_DISTRIBUTION" = "squeeze" ]; then
+	echo "Creating /etc/apt/apt.conf.d/unauthenticated-squeeze ..."
+	tee /etc/apt/apt.conf.d/unauthenticated-squeeze <<EOF
+# The squeeze signing key has expired.
+APT::Get::AllowUnauthenticated "true";
+# The Release file is not getting updated.
+Acquire::Check-Valid-Until "false";
+EOF
+fi

custom-scripts/scripts/post_distupgrade_base_cleanup

@@ -76,6 +76,14 @@ if	[ "$PIUPARTS_DISTRIBUTION" = "stretch" ] || \
 
 fi
 
+if	[ "$PIUPARTS_DISTRIBUTION" = "buster" ] || \
+	[ "$PIUPARTS_DISTRIBUTION" = "buster-proposed" ] ; then
+
+	mark_for_purge libcryptsetup4
+	mark_for_purge libprocps6
+
+fi
+
 if [ -n "$PURGE" ]; then
 	echo "Removing packages from base system:$PURGE"
 	apt-get -y remove --purge $PURGE

custom-scripts/scripts/post_setup_forbid_home

@@ -17,7 +17,11 @@ esac
 if [ -d /home ]; then
 	echo "Disabling /home"
 	mv /home /home.distrib
-	dpkg-divert /home
+	if dpkg-divert --help | grep -q -e --no-rename ; then
+		dpkg-divert --no-rename /home
+	else
+		dpkg-divert /home
+	fi
 	echo "This is a dummy file to prevent creating directories in /home" > /home
 	chmod 000 /home
 fi

custom-scripts/scripts/pre_distupgrade_allow_unauthenticated

+#!/bin/sh
+set -e
+
+if [ "$PIUPARTS_DISTRIBUTION_NEXT" = "squeeze" ]; then
+	rm -fv /etc/apt/apt.conf.d/unauthenticated-lenny
+fi
+
+if [ -e /etc/apt/apt.conf.d/unauthenticated-lenny ]; then
+	echo "FAIL: /etc/apt/apt.conf.d/unauthenticated-lenny exists"
+	exit 1
+fi
+
+if [ "$PIUPARTS_DISTRIBUTION_NEXT" = "wheezy" ]; then
+	rm -fv /etc/apt/apt.conf.d/unauthenticated-squeeze
+fi
+
+if [ "$PIUPARTS_DISTRIBUTION_NEXT" = "squeeze" ]; then
+	echo "Creating /etc/apt/apt.conf.d/unauthenticated-squeeze ..."
+	# apt/lenny does not like comments ...
+	tee /etc/apt/apt.conf.d/unauthenticated-squeeze <<EOF
+APT::Get::AllowUnauthenticated "true";
+Acquire::Check-Valid-Until "false";
+EOF
+elif [ "$PIUPARTS_DISTRIBUTION_NEXT" = "squeeze-backports" ]; then
+	:
+elif [ -e /etc/apt/apt.conf.d/unauthenticated-squeeze ]; then
+	echo "FAIL: /etc/apt/apt.conf.d/unauthenticated-squeeze exists"
+	exit 1
+fi

custom-scripts/scripts/pre_distupgrade_zz_database-server

@@ -136,10 +136,10 @@ case "${PIUPARTS_DISTRIBUTION}:${PIUPARTS_DISTRIBUTION_NEXT}" in
 		upgrade_pg_cluster 9.4 9.6
 		;;
 	stretch:buster)
-		upgrade_pg_cluster 9.6 10
+		upgrade_pg_cluster 9.6 11
 		;;
 	stretch:sid)
-		upgrade_pg_cluster 9.6 10
+		upgrade_pg_cluster 9.6 11
 		;;
 esac
 

custom-scripts/scripts/pre_install_exceptions

@@ -8,7 +8,12 @@ log_debug() {
 case ${PIUPARTS_OBJECTS%%=*} in
 	file-rc)
 		case "$PIUPARTS_DISTRIBUTION" in
-			lenny|squeeze*|stretch*|sid)
+			lenny)
+				# force installation and removal of essential package sysv-rc
+				log_debug
+				echo 'Yes, do as I say!' | apt-get -y --force-yes install file-rc
+				;;
+			squeeze*|stretch*|sid)
 				# force installation and removal of essential package sysv-rc
 				log_debug
 				yes 'Yes, do as I say!' | apt-get -y --force-yes install file-rc
@@ -36,10 +41,6 @@ case ${PIUPARTS_OBJECTS%%=*} in
 		# switch init to upstart before installation
 		apt-get install upstart
 		;;
-	sympa)
-		# force removal of spool directories
-		echo "sympa sympa/remove_spool boolean true" | debconf-set-selections
-		;;
 	systemd-sysv)
 		case "$PIUPARTS_DISTRIBUTION" in
 			wheezy*)
@@ -75,12 +76,6 @@ case ${PIUPARTS_OBJECTS%%=*} in
 			log_debug
 			echo "auctex auctex/doauto select Foreground" | debconf-set-selections
 			;;
-	samhain)
-			# work around #749602
-			log_debug
-			mkdir -p /var/state/samhain/
-			touch /var/state/samhain/samhain_file
-			;;
 	bugzilla3)
 			# checksetup.pl goes into infinite loop asking for them
 			log_debug
@@ -88,6 +83,18 @@ case ${PIUPARTS_OBJECTS%%=*} in
 			echo "bugzilla3 bugzilla3/bugzilla_admin_real_name string Bz" | debconf-set-selections
 			echo "bugzilla3 bugzilla3/bugzilla_admin_pwd password bzbzbzbz" | debconf-set-selections
 			;;
+	msttcorefonts|\
+	ttf-mscorefonts-installer)
+			# Recommends: ca-certificates
+			log_debug
+			apt-get -y install ca-certificates
+			;;
+	samhain)
+			# work around #749602
+			log_debug
+			mkdir -p /var/state/samhain/
+			touch /var/state/samhain/samhain_file
+			;;
 esac
 
 if [ "$PIUPARTS_DISTRIBUTION" = "wheezy" ]; then
@@ -220,10 +227,6 @@ if [ "$PIUPARTS_DISTRIBUTION" = "lenny" ]; then
 			log_debug
 			apt-get -y install defoma
 			;;
-		ttf-mscorefonts-installer|msttcorefonts)
-			log_debug
-			apt-get -y install ca-certificates
-			;;
 	esac
 
 	# prefer inn over cnews (bad version number cr.g7-40.4)

custom-scripts/scripts/pre_remove_40_find_missing_md5sums

@@ -31,7 +31,7 @@ do
 
 	f2=/var/run/f2.$$
 	>$f2
-	dpkg -L "$pkg" | sed 's,\\,\\\\,' | sort | \
+	dpkg -L "$pkg" | sed 's,\\,\\\\,g' | sort | \
 	while read f ; do
 		if [ "$f" != "${f#package diverts others to: }" ]; then
 			: # skip diversion information

custom-scripts/scripts/pre_remove_exceptions

@@ -6,11 +6,21 @@ log_debug() {
 }
 
 case ${PIUPARTS_OBJECTS%%=*} in
+	apt-listbugs)
+		# cleanup from post_install_exceptions
+		log_debug
+		rm -f /usr/sbin/apt-listbugs
+		dpkg-divert --remove --rename /usr/sbin/apt-listbugs
+		;;
 	file-rc)
+		# removal won't work if sysv-rc isn't reinstalled
 		case "$PIUPARTS_DISTRIBUTION" in
-			lenny|squeeze*)
+			lenny)
+				log_debug
+				echo 'Yes, do as I say!' | apt-get -y --force-yes install sysv-rc
+				;;
+			squeeze*)
 				log_debug
-				# removal won't work if sysv-rc isn't reinstalled
 				yes 'Yes, do as I say!' | apt-get -y --force-yes install sysv-rc
 				;;
 		esac
@@ -22,22 +32,28 @@ case ${PIUPARTS_OBJECTS%%=*} in
 			rm -fv /etc/isdn/*
 		fi
 		;;
-	apt-listbugs)
-		# cleanup from post_install_exceptions
-		log_debug
-		rm -f /usr/sbin/apt-listbugs
-		dpkg-divert --remove --rename /usr/sbin/apt-listbugs
+	original-awk)
+		case "$PIUPARTS_DISTRIBUTION" in
+			lenny)
+				log_debug
+				# apt considers this as essential
+				echo 'Yes, do as I say!' | apt-get -y --force-yes remove original-awk
+		esac
 		;;
 esac
 
 case "$PIUPARTS_DISTRIBUTION" in
 
-	stretch*|buster*|sid)
+	lenny*|squeeze*|wheezy*|jessie*)
+		# --allow-remove-essential was added in apt 1.1 (stretch)
+		;;
+	*)
 		case ${PIUPARTS_OBJECTS%%=*} in
 			init|\
 			education-thin-client|\
 			ltsp-client|\
-			ltsp-client-core)
+			ltsp-client-core|\
+			ltsp-client-core-dbgsym)
 				log_debug
 				# requires removal of essential packages
 				if [ ! -f /etc/apt/apt.conf.d/piuparts-allow-remove-essential ]

debian/changelog

+piuparts (0.93) unstable; urgency=medium
+
+  [ Andreas Beckmann ]
+  * piuparts.py:
+    - Report the package that owns a broken symlink.
+    - --allow-database now also enables firebird3.0.
+  * piuparts.conf: Disable rescheduling tests that end in wheezy.
+  * piuparts.conf.anbe: Add some more example sections.
+  * piupartslib/packagesdb.py:
+    - Add methods Package.source(), Package.source_version().
+    - Remove method PackagesDB.get_source().
+  * piuparts-report.py:
+    - Postpone deletion of old logs after the html pages possibly referencing
+      them have been updated, avoiding error 404 while processing a section.
+    - Generate missing/outdated .kpr files.
+    - Simplify known problem report generation.
+    - Mark logs of packages built from an outdated source version as [cruft].
+  * scripts/{post_chroot_unpack,pre_distupgrade}_allow_unauthenticated: New
+    scripts to handle installation from archived releases with expired signing
+    keys (lenny, squeeze). Drop the --no-check-valid-until from *.conf since
+    that is active for all steps in a distupgrade test while the new scripts
+    only enable it for the distros that actually need it.
+  * scripts/post_setup_forbid_home: Use dpkg-divert --no-rename (dpkg 1.19.1).
+  * scripts/pre_distupgrade_zz_database-server: sid/buster has postgresql 11.
+  * scripts/post_distupgrade_base_cleanup: Remove libcryptsetup4, libprocps6
+    from the buster reference chroot.
+  * Overhaul some exceptions.
+  * Add bug template for logrotate errors after package removal.
+
+  [ Holger Levsen ]
+  * piuparts-report.py:
+    - Add new page: overview.html
+    - Split index.html into about (index.html) and news.html.
+    - Shuffle some entries on index.html, explain that piuparts.debian.org
+      exists since 2005 (even though that FQDN is younger).
+    - Move suite "by uploaders" and "by source packages" links further up in
+      navigation menu. Improve structure and headings in navigation menu.
+    - Link mail templates for filings from navigation menu.
+    - Drop references to "PTS" and use "tracker.d.o" instead.
+    - Add link to piuparts source package pages from known problem pages.
+    - Minor cleanups.
+  * htdocs/bug_howto.tpl: some improvements, it's been some years.
+  * htdocs/news.tpl: confirm #582630 has been fixed.
+  * Use the new debhelper-compat(=11) notation and drop d/compat.
+  * CONTRIBUTING: explain never to directly push to the develop nor master
+    branch. Explain to always include a debian/changelog entry with patches.
+    Explain to always test patches and to explain that testing has happened.
+
+ -- Holger Levsen <holger@debian.org>  Sun, 21 Oct 2018 13:24:09 +0200
+
 piuparts (0.92) unstable; urgency=medium
 
   [ Simon McVittie ]

debian/compat

-11

debian/control

@@ -8,7 +8,7 @@ Standards-Version: 4.2.1
 Rules-Requires-Root: no
 Build-Depends:
  asciidoc,
- debhelper (>= 11~),
+ debhelper-compat (= 11),
  dh-python,
  python (>= 2.7),
  python-debian,