Fix CGI::param error in collection3 (!6) · Merge requests · Debian / pkg-collectd

Kentaro Hayashi requested to merge kenhys/pkg-collectd:apply-cgi-param-error into master Feb 10, 2021

When using collection3 as a CGI, the following error is sent to logs repeatedly. This MR fixes it:

FastCGI sent in stderr: "CGI::param called in list context from /usr/share/doc/collectd-core/examples/collection3/lib/Collectd/Graph/Common.pm line 529, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 412"

This is caused by inappropriate usage of param(), it should be handled as a scalar or should be treated by multi_param() explicitly.

ref. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=982294

Fix CGI::param error in collection3

Merge request reports