Commit c99b4e75 authored by Nicholas Breen's avatar Nicholas Breen

Address first batch of test suite failures: i386 Gaussian, many architectures hwloc

parent 41cc8c34
gromacs (2016~beta2-2) experimental; urgency=medium
* Two patches to address test suits failures:
- numerically-unstable-gaussian-test.patch: Backport a fix from git
master branch to address Gaussian test failures on all i386
platforms. (http://redmine.gromacs.org/issues/1986)
- disable-hardware-topology-tests.patch: Two CPU info tests cause hard
failures that should probably just be warnings, so disable those tests
for now. (http://redmine.gromacs.org/issues/1987)
-- Nicholas Breen <nbreen@debian.org> Fri, 17 Jun 2016 06:40:18 -0700
gromacs (2016~beta2-1) experimental; urgency=low
* Beta for major new upstream release. New date-based versioning system.
......
Description: Disable hwloc CPU tests
Certain tests for hardwre topology fail on less-common architectures where
the expected values are not available. This should probably be a configure
time warning instead of a fatal test failure. Temporarily disable these
tests pending a fix acceptable upstream.
Author: Nicholas Breen
Bug: http://redmine.gromacs.org/issues/1987
Last-Update: 2016-06-17
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
Index: gromacs-2016~beta2/src/gromacs/hardware/tests/hardwaretopology.cpp
===================================================================
--- gromacs-2016~beta2.orig/src/gromacs/hardware/tests/hardwaretopology.cpp
+++ gromacs-2016~beta2/src/gromacs/hardware/tests/hardwaretopology.cpp
@@ -76,7 +76,8 @@ TEST(HardwareTopologyTest, Execute)
<< "Please mail gmx-developers@gromacs.org so we can try to fix it.";
}
-#if GMX_HWLOC
+#if TEST_DISABLED_DEBIAN_PATCH____GMX_HWLOC
+// http://redmine.gromacs.org/issues/1987
TEST(HardwareTopologyTest, HwlocExecute)
{
#ifdef __linux__
Index: gromacs-2016~beta2/src/gromacs/hardware/tests/CMakeLists.txt
===================================================================
--- gromacs-2016~beta2.orig/src/gromacs/hardware/tests/CMakeLists.txt
+++ gromacs-2016~beta2/src/gromacs/hardware/tests/CMakeLists.txt
@@ -33,5 +33,8 @@
# the research papers on the package. Check out http://www.gromacs.org.
gmx_add_unit_test(HardwareUnitTests hardware-test
- cpuinfo.cpp
hardwaretopology.cpp)
+
+# cpuinfo.cpp disabled in Debian patch pending resolution of
+# http://redmine.gromacs.org/issues/1987
+
Description: Fix numerically unstable Gaussian test
Author: Roland Schulz
Bug: http://redmine.gromacs.org/issues/1986
Last-Update: 2016-06-13
diff --git a/src/gromacs/random/tests/tabulatednormaldistribution.cpp b/src/gromacs/random/tests/tabulatednormaldistribution.cpp
index a4e8fc6..6b48aa6 100644
--- a/src/gromacs/random/tests/tabulatednormaldistribution.cpp
+++ b/src/gromacs/random/tests/tabulatednormaldistribution.cpp
@@ -100,6 +100,7 @@
{
result.push_back(dist(rng));
}
+ checker.setDefaultTolerance(test::ulpTolerance(15)); //compiler usage of FMA in makeTable can cause higher difference
checker.checkSequence(result.begin(), result.end(), "TabulatedNormalDistributionDouble14");
}
......@@ -2,3 +2,5 @@ readme.patch
copyright-file.patch
reproducible-builds.patch
doxygen.patch
numerically-unstable-gaussian-test.patch
disable-hardware-topology-tests.patch
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment