1. 11 Jan, 2019 1 commit
  2. 21 Dec, 2018 1 commit
  3. 04 Dec, 2018 1 commit
  4. 03 Dec, 2018 2 commits
  5. 21 Nov, 2018 1 commit
  6. 20 Nov, 2018 2 commits
  7. 12 Jun, 2018 1 commit
  8. 11 May, 2018 2 commits
  9. 03 May, 2018 1 commit
  10. 02 May, 2018 1 commit
  11. 12 Mar, 2018 1 commit
  12. 05 Mar, 2018 4 commits
  13. 23 Feb, 2018 1 commit
  14. 21 Feb, 2018 1 commit
  15. 13 Feb, 2018 1 commit
  16. 12 Feb, 2018 2 commits
  17. 09 Feb, 2018 1 commit
  18. 07 Feb, 2018 1 commit
  19. 12 Jan, 2018 1 commit
  20. 10 Jan, 2018 1 commit
  21. 08 Jan, 2018 1 commit
  22. 04 Jan, 2018 1 commit
  23. 21 Dec, 2017 1 commit
  24. 20 Dec, 2017 1 commit
  25. 13 Dec, 2017 1 commit
  26. 12 Dec, 2017 2 commits
  27. 22 Nov, 2017 1 commit
  28. 10 Nov, 2017 1 commit
  29. 03 Nov, 2017 1 commit
  30. 02 Nov, 2017 1 commit
  31. 22 Oct, 2017 1 commit
    • Remi Gacogne's avatar
      Fix a linking issue in stubby when libbsd is present · 8e12d86f
      Remi Gacogne authored
      When libbsd is found on the system during the configure, the result
      of `pkg-config --cflags libbsd-overlay` is added to `CFLAGS`:
      
      `-DLIBBSD_OVERLAY -isystem /usr/include/bsd`
      
      The result of `pkg-config --libs libbsd-overlay` is added to `LIBS`,
      but not to `STUBBY_LIBS`, which is used when linking stubby.
      
      Because of the new `CFLAGS`, the preprocessor replaces the call to
      `getopt()` in stubby.c with a call to `bsd_getop()`:
      
      ```
       #ifdef LIBBSD_OVERLAY
       #undef getopt
       #define getopt(argc, argv, optstr) bsd_getopt(argc, argv, optstr)
       #endif
      ```
      
      But since `-lbsd` has not been added to `STUBBY_LIBS`, the linking of
      stubby fails with an unresolved symbol:
      
      ```
      ../libtool --tag=CC --mode=link gcc -o stubby stubby.lo convert_yaml_to_json.lo gbuffer.lo -lyaml  libgetdns.la
      libtool: link: gcc -o .libs/stubby .libs/stubby.o .libs/convert_yaml_to_json.o .libs/gbuffer.o  -lyaml ./.libs/libgetdns.so
      /usr/bin/ld: .libs/stubby.o: undefined reference to symbol 'bsd_getopt@@LIBBSD_0.0'
      /usr/lib/libbsd.so.0: error adding symbols: DSO missing from command line
      collect2: error: ld returned 1 exit status
      ```
      
      Simply adding the result of `pkg-config --libs libbsd-overlay` to
      `STUBBY_LIBS` in addition to `LIBS` fixes the issue.
      8e12d86f
  32. 05 Oct, 2017 1 commit