Commit 6983fb5b authored by Arnaud Rebillout's avatar Arnaud Rebillout

Dont clean engine/pkg/chrootarchive/archive_test.go

The file 'archive_test.go' doesn't define only tests, it also defines
functions that might be needed by other tests.

In particular, it has an important init function:

    func init() {
            reexec.Init()
    }

All tests that rely on reexec need this func. The tests added by
CVE-2018-15664 need it as well. Without this, the tests cause fork bomb.

(Thanks to zhsj for figure this one out ;)

The tests defined in archive_test.go are already disabled for non-root
users, so I don't see any reason to remove this file.
Signed-off-by: Arnaud Rebillout's avatarArnaud Rebillout <arnaud.rebillout@collabora.com>
parent 7bd3f01b
......@@ -22,5 +22,4 @@ engine/builder/remotecontext/tarsum_test.go
engine/daemon/graphdriver/devmapper/devmapper_test.go
engine/daemon/graphdriver/quota/projectquota_test.go
engine/daemon/graphdriver/vfs/vfs_test.go
engine/pkg/chrootarchive/archive_test.go
engine/plugin/manager_linux_test.go
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment