1. 07 Aug, 2017 1 commit
  2. 26 Jul, 2016 1 commit
  3. 30 Jun, 2015 1 commit
  4. 29 Jun, 2015 1 commit
  5. 01 Oct, 2014 1 commit
  6. 21 Sep, 2014 1 commit
    • Peter Jones's avatar
      Generate a sane PE header on shim, fallback, and MokManager. · 2c59a1a0
      Peter Jones authored
      It turns out a7249a65 was masking a second problem - on some binaries,
      when we actually don't have any base relocations at all, binutils'
      "objcopy --target efi-app-x86_64" is generating a PE header with a base
      relocations pointer that happily points into the middle of our text
      section.  So with shim processing base relocations correctly, it refuses
      to load those binaries.
      
      For example, on one binary I just built:
      
      00000130  00 a0 00 00 0a 00 00 00  00 00 00 00 00 00 00 00 |................|
      
      which says there's a Base Relocation Table at 0xa000 that's 0xa bytes long.
      That's here:
      
      0000a000  58 00 29 00 00 00 00 00  48 00 44 00 28 00 50 00 |X.).....H.D.(.P.|
      0000a010  61 00 72 00 74 00 25 00  64 00 2c 00 53 00 69 00 |a.r.t.%.d.,.S.i.|
      0000a020  67 00 25 00 67 00 29 00  00 00 00 00 00 00 00 00 |g.%.g.).........|
      0000a030  48 00 44 00 28 00 50 00  61 00 72 00 74 00 25 00 |H.D.(.P.a.r.t.%.|
      
      So the table is:
      
      0000a000  58 00 29 00 00 00 00 00  48 00                   |X.).....H.      |
      
      That wouldn't be so bad, except those binaries are MokManager.efi,
      fallback.efi, and shim.efi, and sometimes they're .reloc, which we're
      actually trying to handle correctly now because grub builds with a real
      and valid .reloc table.  So though I didn't think there was any hair
      left on this yak, more shaving ensues.
      
      With this change, instead of letting objcopy do whatever it likes, we
      switch to "-O binary" and merely link in a header that's appropriate for
      our binaries.  This is the same method Ard wrote for aarch64, and it
      seems to work fine in either place (modulo some minor changes.)
      
      At some point this should be merged into gnu-efi instead of carrying our
      own crt0-efi-x86_64.S, but that's a less immediate problem.
      
      I did not need this problem.
      Signed-off-by: default avatarPeter Jones <pjones@redhat.com>
      2c59a1a0
  7. 10 Jun, 2013 1 commit
    • Peter Jones's avatar
      Move embedded certificates to their own section. · c682b514
      Peter Jones authored
      With this change, the embedded certificate and dbx lists (vendor_cert,
      vendor_cert_size, vendor_dbx, and vendor_dbx_size) wind up being in a
      section named .vendor_cert, and so will look something like:
      ------
      fenchurch:~/devel/github.com/shim$ objdump -h shim.efi
      
      shim.efi:     file format pei-x86-64
      
      Sections:
      Idx Name          Size      VMA               LMA               File off  Algn
        0 .eh_frame     000174a8  0000000000005000  0000000000005000  00000400  2**3
                        CONTENTS, ALLOC, LOAD, READONLY, DATA
        1 .text         000aa7e1  000000000001d000  000000000001d000  00017a00  2**4
                        CONTENTS, ALLOC, LOAD, READONLY, CODE
        2 .reloc        0000000a  00000000000c8000  00000000000c8000  000c2200  2**0
                        CONTENTS, ALLOC, LOAD, READONLY, DATA
        3 .data         00031228  00000000000c9000  00000000000c9000  000c2400  2**5
                        CONTENTS, ALLOC, LOAD, DATA
        4 .vendor_cert  00000375  00000000000fb000  00000000000fb000  000f3800  2**0
                        CONTENTS, READONLY
        5 .dynamic      000000f0  00000000000fc000  00000000000fc000  000f3c00  2**3
                        CONTENTS, ALLOC, LOAD, DATA
        6 .rela         0002afa8  00000000000fd000  00000000000fd000  000f3e00  2**3
                        CONTENTS, ALLOC, LOAD, READONLY, DATA
        7 .dynsym       0000f1f8  0000000000128000  0000000000128000  0011ee00  2**3
                        CONTENTS, ALLOC, LOAD, READONLY, DATA
      ------
      
      This simplifies a security audit, because it means that different
      versions of shim with substantially the same code with different keys
      will be more easily comperable, and therefore logic differences may be
      more easily identified.
      
      This also means that if there's a trusted build you want to use, you can
      remove the certificates, implant new ones, and have it signed, and the
      code sections won't change.
      Signed-off-by: default avatarPeter Jones <pjones@redhat.com>
      c682b514