Commit 4555f5d5 authored by Chris Michael's avatar Chris Michael

edje: Fix unchecked return value

Coverity reports that we call _circular_dependency_find here without
checking the return value

Fixes Coverity CID1349867

@fix
Signed-off-by: default avatarChris Michael <cp.michael@samsung.com>
parent 3bc6e30d
......@@ -3923,18 +3923,22 @@ _edje_part_recalc(Edje *ed, Edje_Real_Part *ep, int flags, Edje_Calc_Params *sta
Eina_List *l = NULL;
char *part_name;
char depends_path[PATH_MAX] = "";
_circular_dependency_find(ed, ep, NULL, &clist);
strncat(depends_path, ep->part->name,
sizeof(depends_path) - strlen(depends_path) - 1);
EINA_LIST_FOREACH(clist, l, part_name)
if (_circular_dependency_find(ed, ep, NULL, &clist))
{
strncat(depends_path, " -> ",
sizeof(depends_path) - strlen(depends_path) - 1);
strncat(depends_path, part_name,
strncat(depends_path, ep->part->name,
sizeof(depends_path) - strlen(depends_path) - 1);
EINA_LIST_FOREACH(clist, l, part_name)
{
strncat(depends_path, " -> ",
sizeof(depends_path) - strlen(depends_path) - 1);
strncat(depends_path, part_name,
sizeof(depends_path) - strlen(depends_path) - 1);
}
ERR("Circular dependency in the group '%s' : %s",
ed->group, depends_path);
eina_list_free(clist);
}
ERR("Circular dependency in the group '%s' : %s", ed->group, depends_path);
eina_list_free(clist);
#endif
return;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment