Commit b938e2b5 authored by Umesh Tanwar's avatar Umesh Tanwar Committed by Amitesh Singh

ecore_animator: improve comparision check for stopping animator.

Summary:
Time cmparision does not ensure the corrctness of posotion.
It is beacuse of double number calculation. Double number calculation
are not convertable.for example:
   1/39 = 0.02564102564;
   but 0.02564102564 * 39 = 0.99999999996 != 1;

The addition check for pos ensure the pos to be reached at its correct
position.

@fix
Signed-off-by: 's avatarUmesh Tanwar <umesh.tanwar@samsung.com>

Reviewers: cedric, singh.amitesh, jpeg, raster

Reviewed By: raster

Subscribers: atulfokk, cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D4709Signed-off-by: 's avatarAmitesh Singh <amitesh.sh@samsung.com>
parent c68a4098
......@@ -983,7 +983,7 @@ _ecore_animator_run(void *data)
pos = 0.0;
}
run_ret = animator->run_func(animator->run_data, pos);
if (t >= (animator->start + animator->run)) run_ret = EINA_FALSE;
if (t >= (animator->start + animator->run) && (pos >= 1.0)) run_ret = EINA_FALSE;
return run_ret;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment