Commit de173007 authored by Jonas Bernoulli's avatar Jonas Bernoulli

magit-push-current-to-pushremote: allow setting the default

If `magit-push-current-set-remote-if-missing's value
is `default', then offer to set `remote.pushDefault'
instead of `branch.NAME.pushRemote'.
parent 3f7a82df
......@@ -20,6 +20,12 @@ Updates since v2.5.0
* Added new command `magit-reset-popup' featuring all the available
reset variants.
* If `magit-push-current-set-remote-if-missing's value is `default',
then the command `magit-push-current-to-pushremote' now offers to
set `remote.pushDefault' unless the push-remote is already set in
some way. Previously this command offered to set the local value
`branch.NAME.pushRemote' for all non-nil values of the option.
* When washing the diff that is to be displayed while writing a
commit message takes too long, then it is now possible to abort that
by pressing `C-g'. Previously that would have aborted the commit.
......@@ -401,9 +401,11 @@ available in the popup. If the value is t, then that argument is
redundant. But note that changing the value of this option does
not take affect immediately, the argument will only be added or
removed after restarting Emacs."
:package-version '(magit . "2.4.0")
:package-version '(magit . "2.5.1")
:group 'magit-commands
:type 'boolean)
:type '(choice (const :tag "don't set" nil)
(const :tag "set branch.<name>.pushRemote" t)
(const :tag "set remote.pushDefault" default)))
;;;###autoload (autoload 'magit-push-popup "magit-remote" nil t)
(magit-define-popup magit-push-popup
......@@ -452,14 +454,20 @@ the push-remote can be changed before pushed to it."
(list (magit-push-arguments)
(and (magit--push-current-set-pushremote-p current-prefix-arg)
(magit-read-remote (format "Set push-remote of %s and push there"
(if (eq magit-push-current-set-remote-if-missing 'default)
"Set `remote.pushDefault' and push there"
(format "Set `branch.%s.pushRemote' and push there"
(--if-let (magit-get-current-branch)
(progn (when push-remote
(magit-call-git "config"
(format "branch.%s.pushRemote"
(if (eq magit-push-current-set-remote-if-missing 'default)
(format "branch.%s.pushRemote"
(-if-let (remote (magit-get-push-remote it))
(if (member remote (magit-list-remotes))
(magit-git-push it (concat remote "/" it) args)
......@@ -477,8 +485,12 @@ the push-remote can be changed before pushed to it."
(--if-let (magit-get-push-branch)
(concat (magit-branch-set-face it) "\n")
(and (magit--push-current-set-pushremote-p)
(concat (propertize "pushRemote" 'face 'bold)
", after setting that\n"))))
(propertize (if (eq magit-push-current-set-remote-if-missing 'default)
'face 'bold)
", after setting that\n"))))
(defun magit-push-current-to-upstream (args &optional upstream)
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment