• Kyle Meyer's avatar
    magit-repolist-column-dirty: fix 801cbfd8 · 991aa241
    Kyle Meyer authored
    Despite its name, magit-unstaged-files [1] lists both staged and
    unstaged changes because it's based on a "git diff-index HEAD" call.
    As a result, magit-repolist-column-dirty's last condition in 801cbfd8
    is unreachable.  Use magit-modified-files instead, which is based on a
    "git diff-files" call and is restricted to files with unstaged
    changes.
    
    With the above issue fixed, the last condition can be reached, but the
    return value for this condition is wrong.  Correct the
    magit-staged-files call so that "S" is returned rather than passed as
    an argument to magit-staged-files.
    
    [1] magit-unstaged-files was added in 65867b5d (magit-unstaged-files:
        new function, 2015-12-15) and has never been used for anything
        until its use in magit-repolist-column-dirty.  I don't know how it
        was supposed to differ from magit-modified-files.
    991aa241
Name
Last commit
Last update
Documentation Loading commit data...
lisp Loading commit data...
t Loading commit data...
.gitignore Loading commit data...
.mailmap Loading commit data...
.travis.yml Loading commit data...
CONTRIBUTING.md Loading commit data...
COPYING Loading commit data...
ISSUE_TEMPLATE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
default.mk Loading commit data...