TODO 19.1 KB
Newer Older
James Troup's avatar
James Troup committed
1 2 3 4 5
				 TODO
				 ====

[NB: I use this as a thought record/scribble, not everything on here
     makes sense and/or is actually ever going to get done, so IIWY I
6
     wouldn't use it as gospel for the future of dak or as a TODO
James Troup's avatar
James Troup committed
7 8 9 10 11 12
     list for random hacking.]

================================================================================

Others
------
James Troup's avatar
James Troup committed
13

14 15
  o 'dak check-overrides' should remove the src-only override when a
    binary+source override exists
16

James Troup's avatar
James Troup committed
17 18
  o reject on > or < in a version constraint

19
23:07 < aba> elmo: and, how about enhancing 'dak cruft-report' to spot half-dropped
James Troup's avatar
James Troup committed
20 21 22
   binaries on one arch (i.e. package used to build A and B, but B is
   no longer built on some archs)?

James Troup's avatar
James Troup committed
23 24
  o tabnanny the source

James Troup's avatar
James Troup committed
25 26
  o drop map-unreleased

James Troup's avatar
James Troup committed
27 28 29 30 31 32
  o check email only portions of addresses match too, iff the names
  don't, helps with the "James Troup <james@nocrew.org>"
  vs. "<james@nocrew.org>" case.

  o ensure .dsc section/prio match .changes section/prio

33 34
  o 'dak clean-suites' performance is kind of crap when asked to
     remove a lot of files (e.g. 2k or so).
James Troup's avatar
James Troup committed
35

36
  o we don't handle the case where an identical orig.tar.gz is
37 38
    mentioned in the .changes, but not in unchecked; but should we
    care?
39

40 41
  o 'dak ls' could do better sanity checking for -g/-G (e.g. not more
    than one suite, etc.)
42 43

  o use python2.2-tarfile (once it's in stable?) to check orig.tar.gz
44
    timestamps too.
45

46 47 48 49 50
  o need to decide on whether we're tying for most errors at once.. if
    so (probably) then make sure code doesn't assume variables exist and
    either way do something about checking error code of check_dsc and
    later functions so we skip later checks if they're bailing.

51
  o the .dak stuff is fundamentally braindamaged, it's not versioned
52 53 54 55 56 57
    so there's no way to change the format, yay me.  need to fix.
    probably by putting a version var as the first thing and checking
    that.. auto-upgrade at least from original format would be good.
    might also be a good idea to put everything in one big dict after
    that?

58 59 60
  o [?, wishlist, distant future] RFC2047-ing should be extended to
    all headers of mails sent out.

James Troup's avatar
James Troup committed
61 62
  o reject sparc64 binaries in a non '*64*' package.

63 64
  o queue.py(source_exists): a) we take arguments as parameters that
    we could figure out for ourselves (we're part of the Upload class
James Troup's avatar
James Troup committed
65 66 67
    after all), b) we have this 3rd argument which defaults to "any"
    but could in fact be dropped since no one uses it like that.

68 69 70 71
  o 'dak process-unchecked': doesn't handle bin-only NMUs of stuff
    still in NEW, BYHAND or ACCEPTED (but not the pool) - not a big
    deal, upload can be retried once the source is in the archive, but
    still.
James Troup's avatar
James Troup committed
72 73

  o security global mail overrides should special case buildd stuff so
74
    that buildds get ACCEPTED mails (or maybe 'dak security-install' (?)), that way
James Troup's avatar
James Troup committed
75 76
    upload-security doesn't grow boundlessly.

77 78 79 80
  o 'dak security-install' should upload sourceful packages first,
     otherwise with big packages (e.g. X) and esp. when source is !i386,
     half the arches can be uploaded without source, get copied into
     queue/unaccepted and promptly rejected.
James Troup's avatar
James Troup committed
81

82 83 84
  o 'dak cruft-report's NVIU check doesn't catch cases where source
     package changed name, should check binaries
     too. [debian-devel@l.d.o, 2004-02-03]
James Troup's avatar
James Troup committed
85

86
  o cnf[Rm::logfile] is misnamed...
James Troup's avatar
James Troup committed
87

James Troup's avatar
James Troup committed
88 89 90 91 92
<aj> i'd be kinda inclined to go with insisting the .changes file take
   the form ---- BEGIN PGP MESSAGE --- <non -- BEGIN/END lines> --
   BEGIN PGP SIG -- END PGP MESSAGE -- with no lines before or after,
   and rejecting .changes that didn't match that

93
  o 'dak cruft-report' should check for source packages not building any binaries
James Troup's avatar
James Troup committed
94

95
  o 'dak control-suite' should have a diff mode that accepts diff output!
James Troup's avatar
James Troup committed
96

97 98
  o 'dak clean-proposed-updates' doesn't deal with 'dak rm'-d
     packages, partial replacements etc. and more.
James Troup's avatar
James Troup committed
99

100 101 102
  o 'dak reject-proposed-updates' blindly deletes with no check that
    the delete failed which it might well given we only look for
    package/version, not package/version _in p-u_.  duh.
James Troup's avatar
James Troup committed
103

104 105
  o 'dak rm' should remove obsolete changes when removing from p-u, or
    at least warn.  or 'dak reject-proposed-updates' should handle it.
James Troup's avatar
James Troup committed
106

James Troup's avatar
James Troup committed
107 108
  o need a testsuite _badly_

109 110
  o 'dak process-unchecked' crashes if run as a user in -n mode when
    orig.tar.gz is in queue/new...
James Troup's avatar
James Troup committed
111

112 113 114
<elmo_home> [<random>maybe I should reject debian packages with a non-Debian origin or bugs field</>]
<Kamion> [<random>agreed; dunno what origin does but non-Debian bugs fields would be bad]

115 116 117
  o 'dak clean-suites' should make use of select..except select, temporary tables
    etc. rather than looping and calling SQL every time so we can do
    suite removal sanely (see potato-removal document)
James Troup's avatar
James Troup committed
118

119
  o 'dak rm' will happily include packages in the Cc list that aren't
James Troup's avatar
James Troup committed
120 121
    being removed...

122
  o 'dak rm' doesn't remove udebs when removing the source they build from
123

James Troup's avatar
James Troup committed
124 125 126
  o check_dsc_against_db's "delete an entry from files while you're
    not looking" habit is Evil and Bad.

127 128
  o 'dak process-new' allows you to edit the section and change the
    component, but really shouldn't.
James Troup's avatar
James Troup committed
129

130
  o 'dak rm' needs to, when not sending bug close mails, promote Cc: to
James Troup's avatar
James Troup committed
131 132
    To: and send the mail anyways.

James Troup's avatar
James Troup committed
133 134
  o the lockfile (Archive_Maintenance_In_Progress) should probably be in a conf file

135 136
  o 'dak ls' should cross-check the b.source field and if it's not
    null and s.name linked from it != the source given in
James Troup's avatar
James Troup committed
137
    -S/--source-and-binary ignore.
James Troup's avatar
James Troup committed
138

139 140 141 142
  o 'dak reject-proposed-updates' sucks; it should a) only spam d-i
   for sourceful rejections, b) sort stuff so it rejects sourceful
   stuff first.  the non-sourceful should probably get a form mail, c)
   automate the non-sourceful stuff (see b).
James Troup's avatar
James Troup committed
143

144
  o 'dak process-unchecked' should do q-d stuff for faster AA [ryan]
James Troup's avatar
James Troup committed
145

James Troup's avatar
James Troup committed
146 147 148 149 150
  o split the morgue into source and binary so binaries can be purged first!

  o per-architecture priorities for things like different arch'es
    gcc's, silly BSD libftw, palo, etc.

James Troup's avatar
James Troup committed
151 152
  o use postgres 7.2's built-in stat features to figure out how indices are used etc.

153
  o 'dak init-archive' shouldn't be using location, it should run down suites instead
James Troup's avatar
James Troup committed
154

155
  o 'dak clean-proposed-updates' needs to know about udebs
James Troup's avatar
James Troup committed
156

157 158
  o by default hamstring dak's mail sending so that it won't send
    anything until someone edits a script; it's been used far too
James Troup's avatar
James Troup committed
159 160
    much to send spam atm :(

161
  o $ftpdir/indices isn't created by 'dak init-dir' because it's not in dak.conf
James Troup's avatar
James Troup committed
162 163 164 165

  o sanity check depends/recommends/suggests too?  in fact for any
    empty field?

166 167 168
[minor] 'dak process-accepted's copychanges, copydotdak handling
        sucks, the per-suite thing is static for all packages, so work out
        in advance dummy.
James Troup's avatar
James Troup committed
169

170 171
[dak ls] # filenames ?
[dak ls] # maintainer, component, install date (source only?), fingerprint?
James Troup's avatar
James Troup committed
172

James Troup's avatar
James Troup committed
173
  o UrgencyLog stuff should minimize it's bombing out(?)
James Troup's avatar
James Troup committed
174
  o Log stuff should open the log file
James Troup's avatar
James Troup committed
175

176 177 178
  o 'dak queue-report' should footnote the actual notes, and also *
    the versions with notes so we can see new versions since being
    noted...
James Troup's avatar
James Troup committed
179

180
  o 'dak queue-report' should have alternative sorting options, including reverse
James Troup's avatar
James Troup committed
181 182
    and without or without differentiaion.

183
  o 'dak import-users-from-passwd' should sync debadmin and ftpmaster (?)
James Troup's avatar
James Troup committed
184

James Troup's avatar
James Troup committed
185
  o <drow> Can't read file.:
186
  /org/security.debian.org/queue/accepted/accepted/apache-perl_1.3.9-14.1-1.21.20000309-1_sparc.dak.
James Troup's avatar
James Troup committed
187 188
  You assume that the filenames are relative to accepted/, might want
  to doc or fix that.
James Troup's avatar
James Troup committed
189

James Troup's avatar
James Troup committed
190 191 192
  o <neuro> the orig was in NEW, the changes that caused it to be NEW
    were pulled out in -2, and we end up with no orig in the archive
    :(
James Troup's avatar
James Troup committed
193

194 195 196 197 198
  o SecurityQueueBuild doesn't handle the case of foo_3.3woody1 with a
   new .orig.tar.gz followed by a foo_3.3potato1 with the same
   .orig.tar.gz; 'dak process-unchecked' sees it and copes, but the AA
   code doesn't and can't really easily know so the potato AA dir is
   left with no .orig.tar.gz copy.  doh.
James Troup's avatar
James Troup committed
199 200 201

  o orig.tar.gz in accepted not handled properly (?)

202
  o 'dak security-install' doesn't include .orig.tar.gz but it should
James Troup's avatar
James Troup committed
203

James Troup's avatar
James Troup committed
204 205
  o permissions (paranoia, group write, etc.) configurability and overhaul

206
  o remember duplicate copyrights in 'dak process-new' and skip them, per package
James Troup's avatar
James Troup committed
207

208
  o <M>ove option for 'dak process-new' byhand proecessing
James Troup's avatar
James Troup committed
209

210
  o 'dak cruft-report' could do with overrides
James Troup's avatar
James Troup committed
211

212
  o database.get_location_id should handle the lack of archive_id properly
James Troup's avatar
James Troup committed
213

James Troup's avatar
James Troup committed
214 215
  o the whole versioncmp thing should be documented

216
  o 'dak process-new' doesn't do the right thing with -2 and -1 uploads, as you can
James Troup's avatar
James Troup committed
217 218
    end up with the .orig.tar.gz not in the pool

219
  o 'dak process-new' exits if you check twice (aj)
James Troup's avatar
James Troup committed
220

221
  o 'dak process-new' doesn't trap signals from 'dak examine-package' properly
James Troup's avatar
James Troup committed
222

James Troup's avatar
James Troup committed
223
  o queued and/or perl on sparc stable sucks - reimplement it.
James Troup's avatar
James Troup committed
224 225 226

  o aj's bin nmu changes

227
  o 'dak process-new':
228 229
    * priority >> optional
    * arch != {any,all}
230
    * build-depends wrong (via 'dak compare-suites')
231
    * suid
232
    * conflicts
233
    * notification/stats to admin daily
234
    o trap 'dak examine-package' exiting
James Troup's avatar
James Troup committed
235 236 237
    o distinguish binary only versus others (neuro)

  o cache changes parsed from ordering (careful tho: would be caching
James Troup's avatar
James Troup committed
238
    .changes from world writable incoming, not holding)
James Troup's avatar
James Troup committed
239

240
  o dak doesn't recognise binonlyNMUs correctly in terms of telling
James Troup's avatar
James Troup committed
241 242 243
    who their source is; source-must-exist does, but the info is not
    propogated down.

244
  o Fix BTS vs. dak sync issues by queueing(via BSMTP) BTS mail so
James Troup's avatar
James Troup committed
245 246
    that it can be released on deman (e.g. ETRN to exim).

James Troup's avatar
James Troup committed
247 248
  o maintainers file needs overrides

James Troup's avatar
James Troup committed
249 250
    [ change override.maintainer to override.maintainer-from +
      override.maintainer-to and have them reference the maintainers
251
      table.  Then fix 'dak make-maintainers' to use them and write some scripting
James Troup's avatar
James Troup committed
252
      to handle the Santiago situation. ]
James Troup's avatar
James Troup committed
253

James Troup's avatar
James Troup committed
254
  o Validate Depends (et al.) [it should match  \(\s*(<<|<|<=|=|>=|>|>>)\s*<VERSIONREGEXP>\)]
James Troup's avatar
James Troup committed
255

256 257 258 259 260 261
  o Clean up DONE; archive to tar file every 2 weeks, update tar tvzf INDEX file.

  o testing-updates suite: if binary-only and version << version in
    unstable and source-ver ~= source-ver in testing; then map
    unstable -> testing-updates ?

James Troup's avatar
James Troup committed
262
  o hooks or configurability for debian specific checks (e.g. check_urgency, auto-building support)
263 264 265

  o morgue needs auto-cleaning (?)

266 267 268 269
  o dak stats: two modes, all included, seperate
  o dak stats: add non-US
  o dak stats: add ability to control components, architectures, archives, suites
  o dak stats: add key to expand header
James Troup's avatar
James Troup committed
270

271 272
================================================================================

James Troup's avatar
James Troup committed
273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289
queue/approved
--------------

 o What to do with multi-suite uploads?  Presumably hold in unapproved
   and warn?  Or what?  Can't accept just for unstable or reject just
   from stable.

 o Whenever we check for anything in accepted we also need to check in
   unapproved.

 o non-sourceful uploads should go straight through if they have
   source in accepted or the archive.

 o security uploads on auric should be pre-approved.

================================================================================

James Troup's avatar
James Troup committed
290 291 292
Less Urgent
-----------

James Troup's avatar
James Troup committed
293 294
  o change utils.copy to try rename() first

James Troup's avatar
James Troup committed
295
  o [hard, long term] unchecked -> accepted should go into the db, not
296 297
    a suite, but similar.  this would allow dak to get even faster,
    make 'dak ls' more useful, decomplexify specialacceptedautobuild
James Troup's avatar
James Troup committed
298 299 300 301
    and generally be more sane.  may even be helpful to have e.g. new
    in the DB, so that we avoid corner cases like the .orig.tar.gz
    disappearing 'cos the package has been entirely removed but was
    still on stayofexecution when it entered new.
James Troup's avatar
James Troup committed
302

303
  o Logging [mostly done] (todo: 'dak clean-suites' (hard), .. ?)
James Troup's avatar
James Troup committed
304

305
  o 'dak process-unchecked': the tar extractor class doesn't need to be redone for each package
James Troup's avatar
James Troup committed
306

307
  o reverse of source-must-exist; i.e. binary-for-source-must-not-exist
308 309
  o REJECT reminders in 'dak clean-queues'.
  o 'dak examine-package' should check for conflicts and warn about them visavis priority [rmurray]
310 311
  o store a list of removed/files versions; also compare against them.
    [but be careful about scalability]
James Troup's avatar
James Troup committed
312

313
  o dak examine-package: print_copyright should be a lot more intelligent
314 315 316 317 318 319 320 321 322 323 324 325 326 327
     @ handle copyright.gz
     @ handle copyright.ja and copyright
     @ handle (detect at least) symlinks to another package's doc directory
     @ handle and/or fall back on source files (?)

  o To incorporate from utils:
     @ unreject

  o auto-purge out-of-date stuff from non-free/contrib so that testing and stuff works
  o doogie's binary -> source index
  o jt's web stuff, matt's changelog stuff (overlap)

  o [Hard] Need to merge non-non-US and non-US DBs.

328 329
  o experimental needs to auto clean (relative to unstable) [partial:
   'dak cruft-report' warns about this]
330 331 332 333 334

  o Do a checkpc(1)-a-like which sanitizes a config files.
  o fix parse_changes()/build_file_list() to sanity check filenames
  o saftey check and/or rename debs so they match what they should be

335
  o Improve 'dak compare-suites'.
336
  o Need to optimize all the queries by using EXAMINE and building some INDEXs.
James Troup's avatar
James Troup committed
337
    [postgresql 7.2 will help here]
338
  o Need to enclose all the setting SQL stuff in transactions (mostly done).
339
  o Need to finish 'dak init-db' (a way to sync dak.conf and the DB)
340 341 342
  o Need the ability to rebuild all other tables from dists _or_ pools (in the event of disaster) (?)
  o Make the --help and --version options do stuff for all scripts

343
  o 'dak make-maintainers' can't handle whitespace-only lines (for the moment, this is feature)
344 345 346 347 348 349 350 351 352 353

  o generic way of saying isabinary and isadsc. (?)

  o s/distribution/suite/g

  o cron.weekly:
     @ weekly postins to d-c (?)
     @ backup of report (?)
     @ backup of changes.tgz (?)

354
  o --help doesn't work without /etc/dak/dak.conf (or similar) at
James Troup's avatar
James Troup committed
355 356
    least existing.

357
  o rename 'dak compare-suites' (clashes with existing 'dak compare-suites')...
James Troup's avatar
James Troup committed
358

359
 * Harder:
James Troup's avatar
James Troup committed
360

361
    o interrupting of stracing 'dak process-unchecked' causes exceptions errors from apt_inst calls
James Troup's avatar
James Troup committed
362
    o dependency checking (esp. stable) (partially done)
James Troup's avatar
James Troup committed
363 364 365 366
    o override checks sucks; it needs to track changes made by the
      maintainer and pass them onto ftpmaster instead of warning the
      maintainer.
    o need to do proper rfc822 escaping of from lines (as opposed to s/\.//g)
367
    o Revisit linking of binary->source in install() in dak.
James Troup's avatar
James Troup committed
368 369
    o Fix component handling in overrides (aj)
    o Fix lack of entires in source overrides (aj)
James Troup's avatar
James Troup committed
370
    o direport misreports things as section 'devel' (? we don't use direport)
James Troup's avatar
James Troup committed
371 372 373 374 375 376 377
    o vrfy check of every Maintainer+Changed-By address; valid for 3 months.
    o binary-all should be done on a per-source, per-architecture package
      basis to avoid, e.g. the perl-modules problem.
    o a source-missing-diff check: if the version has a - in it, and it
      is sourceful, it needs orig and diff, e.g. if someone uploads
      esound_0.2.22-6, and it is sourceful, and there is no diff ->
      REJECT (version has a dash, therefore not debian native.)
James Troup's avatar
James Troup committed
378
    o check linking of .tar.gz's to .dsc's.. see proftpd 1.2.1 as an example
James Troup's avatar
James Troup committed
379 380
    o archive needs md5sum'ed regularly, but takes too long to do all
      in one go; make progressive or weekly.
381 382 383
    o something needs to clear out .changes files from p-u when
      removing stuff superseded by newer versions.  [but for now we have
      'dak clean-proposed-updates']
James Troup's avatar
James Troup committed
384
    o test sig checking stuff in test/ (stupid thing is not modularized due to global abuse)
385
    o when encountering suspicous things (e.g. file tainting) do something more drastic
James Troup's avatar
James Troup committed
386

James Troup's avatar
James Troup committed
387
 * Easy:
James Troup's avatar
James Troup committed
388

James Troup's avatar
James Troup committed
389 390
    o suite mapping and component mapping are parsed per changes file,
      they should probably be stored in a dictionary created at startup.
James Troup's avatar
James Troup committed
391
    o don't stat/md5sum files you have entries for in the DB, moron
392 393 394
      boy (Dak.check_source_blah_blah)
    o promote changes["changes"] to mandatory in dak.py(dump_vars)
      after a month or so (or all .dak files contain in the queue
395
      contain it).
396
    o 'dak rm' should behave better with -a and without -b; see
James Troup's avatar
James Troup committed
397 398
      gcc-defaults removal for an example.
    o Reject on misconfigured kernel-package uploads
James Troup's avatar
James Troup committed
399
    o utils.extract_component_from_section: main/utils -> main/utils, main rather than utils, main
400 401
    o Fix 'dak process-unchecked' to warn if run when not in incoming or p-u
    o dak should validate multi-suite uploads; only possible valid one
James Troup's avatar
James Troup committed
402 403
      is "stable unstable"
    o cron.daily* should change umask (aj sucks)
404 405 406
    o 'dak cruft-report' doesn't look at debian-installer but should.
    o 'dak cruft-report' needs to check for binary-less source packages.
    o 'dak cruft-report' could accept a suite argument (?)
James Troup's avatar
James Troup committed
407
    o byhand stuff should send notification
408 409
    o 'dak poolize' should udpate db; move files, not the other way around [neuro]
    o 'dak rm' should update the stable changelog [joey]
410
    o update tagdb.dia
James Troup's avatar
James Troup committed
411

412
 * Bizzare/uncertain:
James Troup's avatar
James Troup committed
413

James Troup's avatar
James Troup committed
414
    o drop rather dubious currval stuff (?)
James Troup's avatar
James Troup committed
415
    o rationalize os.path.join() usage
416
    o 'dak cruft-report' also doesn't seem to warn about missing binary packages (??)
417
    o logging: hostname + pid ?
418 419
    o ANAIS should be done in dak (?)
    o Add an 'add' ability to 'dak rm' (? separate prog maybe)
420 421
    o Replicate old dinstall report stuff (? needed ?)
    o Handle the case of 1:1.1 which would overwrite 1.1 (?)
422
    o maybe drop -r/--regex in 'dak ls', make it the default and
James Troup's avatar
James Troup committed
423
      implement -e/--exact (a la joey's "elmo")
424 425
    o dsc files are not checked for existence/perms (only an issue if
      they're in the .dsc, but not the .changes.. possible?)
James Troup's avatar
James Troup committed
426 427 428

 * Cleanups & misc:

James Troup's avatar
James Troup committed
429 430 431
    o db_access' get_files needs to use exceptions not this None, > 0, < 0 return val BS (?)
    o The untouchable flag doesn't stop new packages being added to ``untouchable'' suites

432
================================================================================
James Troup's avatar
James Troup committed
433

James Troup's avatar
James Troup committed
434 435
Packaging
---------
James Troup's avatar
James Troup committed
436

James Troup's avatar
James Troup committed
437
  o Fix stuff to look in sensible places for libs and config file in debian package (?)
James Troup's avatar
James Troup committed
438

439
================================================================================
James Troup's avatar
James Troup committed
440

441
                          --help      manpage
James Troup's avatar
James Troup committed
442
-----------------------------------------------------------------------------
443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472
check-archive	          X
check-overrides           X		 X
check-proposed-updates    X
clean-proposed-updates    X
clean-queues  	          X
clean-suites  	          X		 X
compare-suites	          X
control-overrides         X		 X
control-suite             X		 X
cruft-report    	  X
decode-dot-dak            X
examine-package           X
generate-releases	  X
import-archive            X
import-users-from-passwd  X		 X
init-db	                  X
init-dirs    	          X
ls                        X		 X
make-maintainers          X		 X
make-overrides            X
make-suite-file-list      X
poolize                   X		 X
process-accepted          X		 X
process-new               X		 X
process-unchecked         X
queue-report              X
rm	                  X		 X
security-install          X
stats 	                  X
symlink-dists             X
James Troup's avatar
James Troup committed
473

James Troup's avatar
James Troup committed
474

James Troup's avatar
James Troup committed
475
================================================================================
James Troup's avatar
James Troup committed
476

James Troup's avatar
James Troup committed
477 478
Random useful-at-some-point SQL
-------------------------------
James Troup's avatar
James Troup committed
479

James Troup's avatar
James Troup committed
480 481 482
UPDATE files SET last_used = '1980-01-01'
  FROM binaries WHERE binaries.architecture = <x> 
                  AND binaries.file = files.id;
James Troup's avatar
James Troup committed
483

James Troup's avatar
James Troup committed
484 485 486 487
DELETE FROM bin_associations 
 WHERE EXISTS (SELECT id FROM binaries 
                WHERE architecture = <x> 
                  AND id = bin_associations.bin);
James Troup's avatar
James Troup committed
488

James Troup's avatar
James Troup committed
489
================================================================================