That should fix previously unseen test failure because Salsa CI and I
did not use "dpkg-buildpackage -A" that buildd does for the "all"
architecture.

It can be triggered when mimeapps.list in the "[Default Applications]" section
refers to a valid .desktop file with both dashes and spaces.

Closes: #809877
Upstream: https://gitlab.freedesktop.org/xdg/xdg-utils/-/issues/182

LP: #342584

Currently if the tool that was taken out of .desktop file Exec field
will exit with non-zero exit code, xdg-open will then fallback to
open_generic() from search_desktop_file(), which will lead to opening
again the same file with the same tool and ending on opening the file
with web browser.

This may lead to situation when for example text editor that fails to
write file on exit, will open the unchanged file with web browsr.

Another real life example is if one were to exit from mpv with
control-C, xdg-open will again start mpv, then it will try to start
x-web-browser and ending with starting a browser from list -- firefox in
my case.

This must be a bug as it's not docummented anywhere. If we got to the
point where we exec $command_exec then xdg-open must exit even if
whatever was executed by $command_exec returned non-zero exit status.

Origin: https://gitlab.freedesktop.org/xdg/xdg-utils/-/merge_requests/13/diffs?commit_id=0ad418b2543b532ec82298ac2660d3f222f10882

See also: https://www.gnu.org/software/autoconf/manual/autoconf-2.70/html_node/Changed-Directory-Variables.html

Dash seems to not use $PATH to find executable of first parameter.
So we pass name of entry script to "exec" command.

A terminal emulator is launched if .desktop file contains "Terminal=true"
statement and there is no control terminal assigned to our process. The
terminal emulator can be set via $TERMINAL environment variable that should
contain either its name or a command line to launch the terminal. In case this
variable is unset, Debian specific x-terminal-emulator is used.

Closes: #964877

Closes: #847164

Closes: #975228

Closes: #970203

Remove obsolete field Name from debian/upstream/metadata (already present in machine-readable debian/copyright).

Closes: #652038

Andrea Tarocchi authored Feb 20, 2020 and Nicholas Guriev committed Mar 13, 2020

(cherry picked from commit 9816ebb3e6fd9f23e993b8b7fcbd56f92d9c9197)
Signed-off-by: Nicholas Guriev <guriev-ns@ya.ru>

Iain Lane authored Oct 02, 2018 and Nicholas Guriev committed Mar 13, 2020

libdbus expects string arguments to be valid UTF-8. If they are not,
then it aborts, which causes our backgrounded command to terminate
abnormally.

Signed-off-by: Simon Lees <sflees@suse.de>
(cherry picked from commit 455d066182546b37984e6b9719bde2347bf6fa94)
Signed-off-by: Nicholas Guriev <guriev-ns@ya.ru>

mvdlinde authored Mar 03, 2019 and Nicholas Guriev committed Mar 13, 2020

(cherry picked from commit 7f5349ea485fa9e0a4cb69dc645fbaf9ce3cec2e)
Signed-off-by: Nicholas Guriev <guriev-ns@ya.ru>

Rex Dieter authored Sep 13, 2018 and Nicholas Guriev committed Mar 13, 2020

Reverts a small part of prior commit
56991bc165577f011f9ad7ca721c5a5134710e33

(cherry picked from commit 74776910981b60877d25b1ab9587e5928af1e9c4)
Signed-off-by: Nicholas Guriev <guriev-ns@ya.ru>

Alberto Salvia Novella authored Sep 11, 2018 and Nicholas Guriev committed Mar 13, 2020

(cherry picked from commit 56991bc165577f011f9ad7ca721c5a5134710e33)
Signed-off-by: Nicholas Guriev <guriev-ns@ya.ru>

Rex Dieter authored May 24, 2018 and Nicholas Guriev committed Mar 13, 2020

(cherry picked from commit 31525d3855f876ddf2e29091b2e8d376f923e09e)
Signed-off-by: Nicholas Guriev <guriev-ns@ya.ru>

This separates the header itself and the patch content.

Fixes lintian: no-dep5-copyright
See https://lintian.debian.org/tags/no-dep5-copyright.html for more details.

Fixes lintian: out-of-date-standards-version
See https://lintian.debian.org/tags/out-of-date-standards-version.html for more details.

Fixes lintian: override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS
See https://lintian.debian.org/tags/override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS.html for more details.

Fixes lintian: rules-requires-root-missing
See https://lintian.debian.org/tags/rules-requires-root-missing.html for more details.

Fixes lintian: debian-news-entry-uses-asterisk
See https://lintian.debian.org/tags/debian-news-entry-uses-asterisk.html for more details.