pagekite: Simplify and fix several issues

Sunil Mohan Adaparequested to merge
sunilmohan/freedombox:pagekite-simplification into master

Closes: #1789 (closed).

  • Tests performed:
    • DONE: Without pagekite enabled, no domain is added and names shows empty list of domain of type pagekite.
    • DONE: Disabling to stop and enabling should start.
    • DONE: Fresh installing should not lead to error.
    • DONE: First configuration should restart the daemon.
    • DONE: Current configuration should reflect properly in the form.
    • DONE: Setting all four parameters should reflect.
    • DONE: Submit without changing values should show 'settings unchanged'.
    • DONE: Blanking needed parameters should fail to submit form.
    • DONE: Adding custom service should reflect. Try all protocols.
    • DONE: Remove custom service should reflect.
    • DONE: Custom services should list the protocol, subdomains, frontend domain, port and backend port properly.
    • DONE: Custom services should not list default services.
    • DONE: Adding custom service similar to default service should result in error.
    • DONE: All default services should be configured on setup.
    • DONE: Pagekite should get restart properly after each setup update.
    • DONE: When Pagekite is not installed, no domain should be added. Visit the names page.
    • DONE: With app enabled, starting the fbx should setup the domain. Visible in names app. Clicking configure sends to pagekite app.
    • DONE: With app disabled, starting the fbx should not add the domain. Not visible in names app.
    • DONE: When app is enabled, the domain should be removed.
    • DONE: When app is disabled, the domain should be removed.
    • DONE: When domain is changed, old domain should get removed and new domain should get added.
    • DONE: When some configuration is not available, the page should load properly with corresponding fields empty.
    • DONE: Unit/functional tests should run properly.
    • DONE: Diagnostics should work.
    • DONE: App title, page title, enabled status, description etc. should be proper on the app page and add custom service page.
    • DONE: default port should be 80, default frontend should be pagekite.net
    • DONE: Setup and disable with old code, when enabled with new code, things should work.

Merge request reports