Skip to content

Wrong workspace listed in task-configuration-inspector

Right now https://debusine.debian.net/debian/developers/task-configuration-inspector/ shows "default in debian/developers" twice: image

However if you click on the second line, you get to see "Collection default in debian/base".

I think we intended to list all task-configurations available in the inheritance chain and that's why we have two entries shown. However we should make sure to display the correct workspace for collections coming from other workspaces, otherwise it's pretty confusing.

I believe it's just a matter of changing this:

diff --git a/debusine/web/templates/web/task-configuration-inspector.html b/debusine/web/templates/web/task-configuration-inspector.html
index c0251f7b..06c36875 100644
--- a/debusine/web/templates/web/task-configuration-inspector.html
+++ b/debusine/web/templates/web/task-configuration-inspector.html
@@ -10,7 +10,7 @@
                 <div class="list-group list-group-flush" id="collection-selector">
                     {% for collection in collections %}
                         <a class="list-group-item list-group-item-action"
-                           href="?collection={{ collection.id }}">{{ collection.name }} in {{ workspace }}</a>
+                           href="?collection={{ collection.id }}">{{ collection.name }} in {{ collection.workspace }}</a>
                     {% endfor %}
                 </div>
             {% else %}
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information