1. 05 May, 2018 1 commit
  2. 10 Apr, 2018 1 commit
  3. 23 Mar, 2018 2 commits
  4. 13 Mar, 2018 2 commits
  5. 12 Mar, 2018 1 commit
  6. 06 Mar, 2018 1 commit
    • Gerald Combs's avatar
      Transition from GeoIP Legacy to MaxMindDB. · a1da75c5
      Gerald Combs authored
      MaxMind is discontinuing its legacy databases in April in favor of
      GeoIP2, which use a newer database format (MaxMind DB). The reference C
      library (libmaxminddb) is available under the Apache 2.0 license which
      isn't quite compatible with ours.
      
      Add mmdbresolve, a utility that reads IPv4 and IPv6 addresses on stdin
      and prints resolved information on stdout. Place it under a liberal
      license (MIT) so that we can keep libmaxminddb at arm's length. Add
      epan/maxmind_db.[ch], which spawns mmdbresolve and communicates with it
      via stdio.
      
      Migrate the preferences and documentation to MaxMindDB.
      
      Change the IPv4 and IPv6 asnum fields to FT_UINT32s. Change the
      geographic coordinate fields to FT_DOUBLEs.
      
      Bug: 10658
      Change-Id: I24aeed637bea1b41d173270bda413af230f4425f
      Reviewed-on: https://code.wireshark.org/review/26214
      Petri-Dish: Gerald Combs <gerald@wireshark.org>
      Tested-by: Petri Dish Buildbot
      Reviewed-by: 's avatarGerald Combs <gerald@wireshark.org>
      a1da75c5
  7. 02 Mar, 2018 1 commit
  8. 09 Jan, 2018 1 commit
  9. 08 Jan, 2018 1 commit
  10. 10 Dec, 2017 1 commit
    • Gerald Combs's avatar
      Win32: Add checks for _WIN32_WINNT and NTDDI_VERSION. · d0d1eaad
      Gerald Combs authored
      Check to see if we're the source of truth for _WIN32_WINNT and
      NTDDI_VERSION in config.h and emit a compiler error if we aren't.
      
      Rearrange the #includes in ui/qt/data_printer.cpp so that config.h is
      included first. This fixes the following:
      
         136>C:\buildbot\wireshark\wireshark-master-64\windows-2016-x64\build\cmbuild\config.h(411): warning C4005: 'NTDDI_VERSION': macro redefinition (compiling source file C:\buildbot\wireshark\wireshark-master-64\windows-2016-x64\build\ui\qt\utils\data_printer.cpp) [C:\buildbot\wireshark\wireshark-master-64\windows-2016-x64\build\cmbuild\ui\qt\qtui.vcxproj]
               C:\Program Files (x86)\Windows Kits\10\Include\10.0.15063.0\shared\sdkddkver.h(223): note: see previous definition of 'NTDDI_VERSION' (compiling source file C:\buildbot\wireshark\wireshark-master-64\windows-2016-x64\build\ui\qt\utils\data_printer.cpp)
         136>C:\buildbot\wireshark\wireshark-master-64\windows-2016-x64\build\cmbuild\config.h(412): warning C4005: '_WIN32_WINNT': macro redefinition (compiling source file C:\buildbot\wireshark\wireshark-master-64\windows-2016-x64\build\ui\qt\utils\data_printer.cpp) [C:\buildbot\wireshark\wireshark-master-64\windows-2016-x64\build\cmbuild\ui\qt\qtui.vcxproj]
               C:\Program Files (x86)\Windows Kits\10\Include\10.0.15063.0\shared\sdkddkver.h(213): note: see previous definition of '_WIN32_WINNT' (compiling source file C:\buildbot\wireshark\wireshark-master-64\windows-2016-x64\build\ui\qt\utils\data_printer.cpp)
      
      Change-Id: I90886cb9450463d768d6529ccd678ca11508cde2
      Reviewed-on: https://code.wireshark.org/review/24744Reviewed-by: 's avatarMichael Mann <mmann78@netscape.net>
      Petri-Dish: Michael Mann <mmann78@netscape.net>
      Tested-by: Petri Dish Buildbot
      Reviewed-by: 's avatarAnders Broman <a.broman58@gmail.com>
      d0d1eaad
  11. 24 Nov, 2017 1 commit
  12. 19 Nov, 2017 1 commit
    • João Valverde's avatar
      Fix (and chop) static build option · 262a84c3
      João Valverde authored
      This sets the scope of the static build option to Wireshark support
      libraries only.
      
      Before the patch:
      
      Static plugins don't work with CMake and autotools.
      
      autotools static build is broken, and most likely will always be, as
      building Wireshark all-static is difficult and time-consuming.
      
      After the patch:
      
      For CMake Wireshark will be built with static or shared libraries and
      dynamic plugins. Everything just works. CMake apparently doesn't want
      you building static and shared libraries at the same time.
      
      For autotools Wireshark will be built with shared libraries by default.
      --disable-shared and --enable-static options work as usual. Dlopened
      plugins are not built if --disable-shared is given to configure (to
      disable shared libraries). This is a limitations imposed by libtool.
      
      Tested on Linux. This removes broken support for building plugins
      statically.
      
      Change-Id: Ib8e8176976f136eea93a2ce8f9857b6cf9bec64c
      Reviewed-on: https://code.wireshark.org/review/24241
      Petri-Dish: João Valverde <j@v6e.pt>
      Tested-by: Petri Dish Buildbot
      Reviewed-by: 's avatarJoão Valverde <j@v6e.pt>
      262a84c3
  13. 15 Nov, 2017 1 commit
  14. 29 Oct, 2017 1 commit
  15. 26 Oct, 2017 3 commits
  16. 25 Oct, 2017 2 commits
  17. 24 Oct, 2017 1 commit
  18. 03 Oct, 2017 1 commit
  19. 17 Sep, 2017 1 commit
    • João Valverde's avatar
      plugins: Fix paths to match WSUG · 978f6b4e
      João Valverde authored
      The Wireshark User Guide seems to say:
      
      Global lua plugins are in $pkglibdir/plugins
      Personal lua plugins are in XDG_CONFIG_HOME/plugins
      
      Global binary plugins are in $pkglibdir/plugins/$version
      Personal binary plugins are in XDG_CONFIG_HOME/plugins/$version
      
      Fix code to match that. This is a backward-incompatible change
      for global lua plugins and personal binary plugins.
      
      Adds a version subfolder to the personal plugin folder for binary plugins.
      
      This allows for safe upgrades and side-by-side installations
      with different prefixes (they no longer use the same personal dir).
      
      Change-Id: Ie0f039113628a257625a9a9fb2cb30e532f5dd47
      Reviewed-on: https://code.wireshark.org/review/23516
      Petri-Dish: João Valverde <j@v6e.pt>
      Tested-by: 's avatarPetri Dish Buildbot <buildbot-no-reply@wireshark.org>
      Reviewed-by: 's avatarJoão Valverde <j@v6e.pt>
      978f6b4e
  20. 06 Sep, 2017 1 commit
  21. 22 Aug, 2017 1 commit
    • Ahmad Fatoum's avatar
      Add hardware timestamping support · aca55a29
      Ahmad Fatoum authored
      pcap provides a pcap_set_tstamp_type function, which can be used to request
      hardware timestamps from a supporting kernel.
      
      This patch adds support for aforementioned function as well as two new
      command line options to dumpcap, wireshark and tshark:
      
          --list-time-stamp-types
                                   List time stamp types supported for the interface
          --time-stamp-type <type>
                                   Change the interface's timestamp method
      
      Name choice mimics those used by tcpdump(1), which already supports this
      feature. However, unlike tcpdump, we provide both options unconditionally.
      If Wireshark was configured without pcap_set_tstamp_type being available,
      --list-time-stamp-types reports an empty list.
      
      Change-Id: I418a4b2b84cb01949cd262aad0ad8427f5ac0652
      Signed-off-by: 's avatarAhmad Fatoum <ahmad.fatoum@siemens.com>
      Reviewed-on: https://code.wireshark.org/review/23113
      Petri-Dish: Guy Harris <guy@alum.mit.edu>
      Tested-by: 's avatarPetri Dish Buildbot <buildbot-no-reply@wireshark.org>
      Reviewed-by: 's avatarAnders Broman <a.broman58@gmail.com>
      aca55a29
  22. 30 Jul, 2017 1 commit
  23. 16 Jun, 2017 2 commits
  24. 11 May, 2017 2 commits
  25. 10 May, 2017 1 commit
    • Guy Harris's avatar
      Get rid of HAVE_REMOTE. · d13b8ea1
      Guy Harris authored
      We never test for it - we test for HAVE_PCAP_REMOTE - so there's no need
      to set it in config.h.
      
      While we're at it, note that "PCAP" in "HAVE_PCAP_REMOTE" can refer to
      libpcap as well as WinPcap, given that, at least in the tip of the
      master branch, you can configure remote support in libpcap, although
      it's not enabled by default (it needs to be vetted for security, as it
      increases the attack surface of a machine running the server *and* of an
      application using libpcap with remote support).
      
      Change-Id: I3c96cf16bbda19ec7c085f74cffc6f125198d45b
      Reviewed-on: https://code.wireshark.org/review/21589Reviewed-by: 's avatarGuy Harris <guy@alum.mit.edu>
      d13b8ea1
  26. 19 Apr, 2017 1 commit
  27. 14 Apr, 2017 1 commit
  28. 05 Apr, 2017 1 commit
  29. 13 Feb, 2017 1 commit
  30. 07 Dec, 2016 1 commit
  31. 06 Dec, 2016 1 commit
    • Peter Wu's avatar
      codecs: Add support for G.722 and G.726 · f5e22a14
      Peter Wu authored
      Integrate the Spandsp library for G.722 and G.726 support. Adds support
      for G.722 and all eight variants of G.726.
      
      Note: this also fixes a crash in Qt (buffer overrun, reading too much
      data) caused by confusion of the larger output buffer (resample_buff)
      with the smaller input buffer (decode_buff). It was not triggered before
      because the sample rate was always 8k, but with the addition of the new
      codecs, a different sample rate became possible (16k).
      
      Fix also a crash which occurs when the RTP_STREAM_DEBUG macro is enabled
      and the VOIP Calls dialog is opened (the begin frame, start_fd, is not
      yet known and therfore a NULL dereference could occur).
      
      Passes testing (plays normally without bad RTP timing errors) with
      SampleCaptures files: sip-rtp-g722.pcap and sip-rtp-g726.pcap. Tested
      with cmake (Qt), autotools (Qt and GTK+) with ASAN enabled.
      
      Bug: 5619
      Change-Id: I5661908d193927bba50901079119eeff0c04991f
      Reviewed-on: https://code.wireshark.org/review/18939
      Petri-Dish: Peter Wu <peter@lekensteyn.nl>
      Tested-by: 's avatarPetri Dish Buildbot <buildbot-no-reply@wireshark.org>
      Reviewed-by: 's avatarAlexis La Goutte <alexis.lagoutte@gmail.com>
      Reviewed-by: Peter Wu's avatarPeter Wu <peter@lekensteyn.nl>
      f5e22a14
  32. 22 Oct, 2016 2 commits
    • Guy Harris's avatar
      Fix the #defines for the presence of structure names. · 5f68435a
      Guy Harris authored
      AC_CHECK_MEMBER() and AC_CHECK_MEMBERS() use a standard name for the
      {structurename} being the name of the structure type, complete with
      "struct" if a typedef wasn't used, and with all letters mapped to upper
      case, and with {membername} being the name of the structure member, with
      all letters mapped to upper case.
      
      check_struct_has_member() lets you choose the name; choose the same name
      that the autoconf macros use, and fix the code to check for them.
      
      Change-Id: Ifb3cf65e7e94907ad0a2f8aacca0c21a531f0c5b
      Reviewed-on: https://code.wireshark.org/review/18382
      Petri-Dish: Guy Harris <guy@alum.mit.edu>
      Reviewed-by: 's avatarGuy Harris <guy@alum.mit.edu>
      5f68435a
    • Guy Harris's avatar
      On UN*X, st_ctime is the last status change time, not the creation time. · 528894e7
      Guy Harris authored
      That's the time the file's inode last changed, so size changes,
      permission changes, etc. affect it.  It's *not* the time the file was
      created; most UN*Xes don't provide that.  Newer versions of FreeBSD,
      NetBSD, OpenBSD, and macOS do, but other UN*Xes don't appear to.
      
      On Windows, at least according to Microsoft's documentation, st_ctime
      *is* the creation time.  Hopefully that's not the result of confusion on
      the part of somebody at Microsoft.
      
      Change-Id: I20743703f6ef66e40dff9004dc91bed46af6fad0
      Reviewed-on: https://code.wireshark.org/review/18378Reviewed-by: 's avatarGuy Harris <guy@alum.mit.edu>
      528894e7