1. 16 Mar, 2011 1 commit
  2. 22 Feb, 2011 3 commits
  3. 15 Feb, 2011 1 commit
  4. 13 Feb, 2011 2 commits
    • Ander Conselvan de Oliveira's avatar
      ProcXkbGetXkbByName: fix use of uninitialised bytes valgrind error. · 85f90173
      Ander Conselvan de Oliveira authored
      ==9999== Syscall param writev(vector[...]) points to uninitialised byte(s)
      ==9999==    at 0x4AB5154: writev (writev.c:51)
      ==9999==    by 0x7C7C3: _XSERVTransWritev (Xtrans.c:912)
      ==9999==    by 0x61C8B: FlushClient (io.c:924)
      ==9999==    by 0x62423: WriteToClient (io.c:846)
      ==9999==    by 0xCE39B: XkbSendMap (xkb.c:1408)
      ==9999==    by 0xD247B: ProcXkbGetKbdByName (xkb.c:5814)
      ==9999==    by 0x4AB53: Dispatch (dispatch.c:432)
      ==9999==    by 0x205BF: main (main.c:291)
      ==9999==  Address 0x557eb68 is 40 bytes inside a block of size 4,096 alloc'd
      ==9999==    at 0x48334A4: calloc (vg_replace_malloc.c:467)
      ==9999==    by 0x62567: WriteToClient (io.c:1065)
      ==9999==    by 0x452EB: ProcEstablishConnection (dispatch.c:3685)
      ==9999==    by 0x4AB53: Dispatch (dispatch.c:432)
      ==9999==    by 0x205BF: main (main.c:291)
      ==9999==  Uninitialised value was created by a stack allocation
      ==9999==    at 0xD1910: ProcXkbGetKbdByName (xkb.c:5559)
      Signed-off-by: default avatarPeter Hutterer <peter.hutterer@who-t.net>
      Reviewed-by: default avatarOliver McFadden <oliver.mcfadden@nokia.com>
      Signed-off-by: default avatarAnder Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
      85f90173
    • Ander Conselvan de Oliveira's avatar
      XkbSendNames: fix use of uninitialised bytes valgrind error. · 8a34d7a8
      Ander Conselvan de Oliveira authored
      ==537== Syscall param writev(vector[...]) points to uninitialised byte(s)
      ==537==    at 0x4AB7154: writev (writev.c:51)
      ==537==    by 0x8935B: _XSERVTransWritev (Xtrans.c:912)
      ==537==    by 0x6C55F: FlushClient (io.c:924)
      ==537==    by 0x6CCF3: WriteToClient (io.c:846)
      ==537==    by 0xD51D3: XkbSendNames (xkb.c:3765)
      ==537==    by 0xD8183: ProcXkbGetKbdByName (xkb.c:5825)
      ==537==    by 0x27B7B: Dispatch (dispatch.c:432)
      ==537==    by 0x205B7: main (main.c:291)
      ==537==  Address 0x55899f2 is 154 bytes inside a block of size 1,896 alloc'd
      ==537==    at 0x4834C48: malloc (vg_replace_malloc.c:236)
      ==537==    by 0xD47AF: XkbSendNames (xkb.c:3642)
      ==537==    by 0xD8183: ProcXkbGetKbdByName (xkb.c:5825)
      ==537==    by 0x27B7B: Dispatch (dispatch.c:432)
      ==537==    by 0x205B7: main (main.c:291)
      ==537==  Uninitialised value was created by a heap allocation
      ==537==    at 0x4834C48: malloc (vg_replace_malloc.c:236)
      ==537==    by 0xD47AF: XkbSendNames (xkb.c:3642)
      ==537==    by 0xD8183: ProcXkbGetKbdByName (xkb.c:5825)
      ==537==    by 0x27B7B: Dispatch (dispatch.c:432)
      ==537==    by 0x205B7: main (main.c:291)
      Signed-off-by: default avatarPeter Hutterer <peter.hutterer@who-t.net>
      Reviewed-by: default avatarOliver McFadden <oliver.mcfadden@nokia.com>
      Signed-off-by: default avatarAnder Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
      8a34d7a8
  5. 27 Jan, 2011 1 commit
  6. 19 Oct, 2010 2 commits
  7. 01 Sep, 2010 2 commits
  8. 20 Jul, 2010 1 commit
  9. 11 Jun, 2010 1 commit
  10. 07 Jun, 2010 1 commit
  11. 06 Jun, 2010 2 commits
  12. 14 May, 2010 1 commit
  13. 12 May, 2010 1 commit
  14. 02 Feb, 2010 1 commit
  15. 24 Jan, 2010 1 commit
  16. 19 Dec, 2009 3 commits
  17. 11 Dec, 2009 2 commits
  18. 14 Oct, 2009 1 commit
  19. 21 Sep, 2009 1 commit
  20. 04 Sep, 2009 1 commit
  21. 15 Jul, 2009 1 commit
  22. 14 Jul, 2009 1 commit
  23. 22 May, 2009 2 commits
    • Peter Hutterer's avatar
      Input: rename DeviceIntRec->isMaster to ->type. · b12d302d
      Peter Hutterer authored
      isMaster is not enough as long as we differ between master pointers and
      keyboard. With flexible device classes, the usual checks for whether a
      master device is a pointer (currently check for ->button, ->valuators or
      ->key) do not work as an SD may post an event through a master and mess this
      check up.
      
      Example, a device with valuators but no buttons would remove the button
      class from the VCP and thus result in the
      IsPointerDevice(inputInfo.pointer) == FALSE.
      
      This will become worse in the future when new device classes are introduced
      that aren't provided in the current system (e.g. a switch class).
      
      This patch replaces isMaster with "type", one of SLAVE, MASTER_POINTER and
      MASTER_KEYBOARD. All checks for dev->isMaster are replaced with an
      IsMaster(dev).
      b12d302d
    • Tomáš Janoušek's avatar
      Bug #6428, #16458, #21464: Fix crash due to uninitialized VModMap fields. · 525aa17f
      Tomáš Janoušek authored
      In ProcXkbGetKbdByName, mrep.firstVModMapKey, .nVModMapKeys and
      .totalVModMapKeys were not initialized, contained random values and caused
      accesses to unallocated and later modified memory, causing
      XkbSizeVirtualModMap and XkbWriteVirtualModMap to see different number of
      nonzero values, resulting in writes past the end of an array in XkbSendMap.
      
      This patch initializes those values sensibly and reverts commits 5c0a2088 and
      6dd4fc46, which have been plain non-sense.
      Signed-off-by: Tomáš Janoušek's avatarTomas Janousek <tomi@nomi.cz>
      Signed-off-by: default avatarPeter Hutterer <peter.hutterer@who-t.net>
      525aa17f
  24. 21 May, 2009 2 commits
  25. 08 May, 2009 1 commit
  26. 04 May, 2009 1 commit
  27. 23 Mar, 2009 1 commit
  28. 16 Mar, 2009 1 commit
  29. 16 Feb, 2009 1 commit