1. 21 Apr, 2015 1 commit
  2. 12 Nov, 2014 1 commit
  3. 12 Jan, 2014 2 commits
  4. 12 Nov, 2013 1 commit
  5. 10 Jul, 2012 4 commits
  6. 21 Mar, 2012 1 commit
    • Keith Packard's avatar
      Introduce a consistent coding style · 9838b703
      Keith Packard authored
      This is strictly the application of the script 'x-indent-all.sh'
      from util/modular. Compared to the patch that Daniel posted in
      January, I've added a few indent flags:
      
      	-bap
      	-psl
      	-T PrivatePtr
      	-T pmWait
      	-T _XFUNCPROTOBEGIN
      	-T _XFUNCPROTOEND
      	-T _X_EXPORT
      
      The typedefs were needed to make the output of sdksyms.sh match the
      previous output, otherwise, the code is formatted badly enough that
      sdksyms.sh generates incorrect output.
      
      The generated code was compared with the previous version and found to
      be essentially identical -- "assert" line numbers and BUILD_TIME were
      the only differences found.
      
      The comparison was done with this script:
      
      dir1=$1
      dir2=$2
      
      for dir in $dir1 $dir2; do
      	(cd $dir && find . -name '*.o' | while read file; do
      		dir=`dirname $file`
      		base=`basename $file .o`
      		dump=$dir/$base.dump
      		objdump -d $file > $dump
      	done)
      done
      
      find $dir1 -name '*.dump' | while read dump; do
      	otherdump=`echo $dump | sed "s;$dir1;$dir2;"`
      	diff -u $dump $otherdump
      done
      Signed-off-by: default avatarKeith Packard <keithp@keithp.com>
      Acked-by: default avatarDaniel Stone <daniel@fooishbar.org>
      Acked-by: default avatarAlan Coopersmith <alan.coopersmith@oracle.com>
      9838b703
  7. 01 Dec, 2011 1 commit
    • Keith Packard's avatar
      Save major/minor opcodes in ClientRec for RecordAReply · fb22a408
      Keith Packard authored
      The record extension needs the major and minor opcodes in the reply
      hook, but the request buffer may have been freed by the time the hook
      is invoked. Saving the request major and minor codes as the request is
      executed avoids fetching from the defunct request buffer.
      
      This patch also eliminates the public MinorOpcodeOfRequest function,
      inlining it into Dispatch. Usages of that function have been replaced
      with direct access to the new ClientRec field.
      Signed-off-by: default avatarKeith Packard <keithp@keithp.com>
      Reviewed-by: default avatarJamey Sharp <jamey@minilop.net>
      fb22a408
  8. 18 Nov, 2011 1 commit
  9. 21 Sep, 2011 1 commit
  10. 03 May, 2011 1 commit
  11. 09 Mar, 2011 1 commit
  12. 25 Feb, 2011 1 commit
    • Erkki Seppälä's avatar
      record: avoid crash when calling RecordFlushReplyBuffer recursively · 0801afbd
      Erkki Seppälä authored
      RecordFlushReplyBuffer can call itself recursively through
      WriteClient->CallCallbacks->_CallCallbacks->RecordFlushAllContexts
      when the recording client's buffer cannot be completely emptied in one
      WriteClient. When a such a recursion occurs, it will not be broken out
      of which results in segmentation fault when the stack is exhausted.
      
      This patch adds a counter (a flag, really) that guards against this
      situation, to break out of the recursion.
      
      One alternative to this change would be to change _CallCallbacks to
      check the corresponding counter before the callback loop, but that
      might affect existing behavior, which may be relied upon.
      Reviewed-by: default avatarRami Ylimäki <rami.ylimaki@vincit.fi>
      Signed-off-by: default avatarErkki Seppälä <erkki.seppala@vincit.fi>
      Signed-off-by: default avatarKeith Packard <keithp@keithp.com>
      0801afbd
  13. 16 Feb, 2011 1 commit
  14. 22 Jun, 2010 1 commit
    • Rami Ylimäki's avatar
      record: Prevent a crash on recording client disconnect. · 8b65f2ed
      Rami Ylimäki authored
      Execute the following steps to reproduce the issue.
      
        1. Run at least two recording clients simultaneously.
           $ cnee --record --request-range 1-127 &
           $ cnee --record --request-range 1-127 &
        2. Kill the recording clients.
           $ killall cnee
        3. Give X server something to do so that the clients are closed.
           $ xinput list
           $ xinput list
      
      As a result RecordUninstallHooks accesses NullClient, because
      RecordAClientStateChange doesn't clean the recording clients up
      properly.
      
      Fix RecordUninstallHooks to fail locally on an assertion instead of
      much later in privates code, if NullClient is still accessed because
      of some other bug. Fix RecordAClientStateChange to iterate through all
      contexts so that modifications of the iterated array during iteration
      don't cause contexts to be skipped.
      Signed-off-by: default avatarRami Ylimäki <ext-rami.ylimaki@nokia.com>
      Reviewed-by: default avatarKeith Packard <keithp@keithp.com>
      Signed-off-by: default avatarKeith Packard <keithp@keithp.com>
      8b65f2ed
  15. 18 Jun, 2010 1 commit
  16. 11 Jun, 2010 1 commit
  17. 06 Jun, 2010 3 commits
  18. 03 Jun, 2010 2 commits
  19. 19 May, 2010 1 commit
  20. 14 May, 2010 1 commit
  21. 12 May, 2010 1 commit
  22. 22 Feb, 2010 1 commit
  23. 19 Dec, 2009 2 commits
  24. 08 Dec, 2009 1 commit
    • Jeremy Huddleston's avatar
      Miscellaneous compilation warning fixes · 1b8f90aa
      Jeremy Huddleston authored
      main.c:134: warning: no previous prototype for 'dix_main'
      rootlessScreen.c: In function 'RootlessMarkOverlappedWindows':
      rootlessScreen.c:434: warning: function declaration isn't a prototype
      backtrace.c:51: warning: format '%lx' expects type 'long unsigned int', but argument 5 has type 'int'
      backtrace.c:54: warning: format '%lx' expects type 'long unsigned int', but argument 5 has type 'int'
      set.c: In function 'RecordSetMemoryRequirements':
      set.c:413: warning: old-style function definition
      set.c: In function 'RecordCreateSet':
      set.c:425: warning: old-style function definition
      stub.c: In function ‘main’:
      stub.c:236: warning: ISO C90 forbids mixed declarations and code
      Signed-off-by: default avatarJeremy Huddleston <jeremyhu@freedesktop.org>
      1b8f90aa
  25. 21 Sep, 2009 1 commit
  26. 24 Aug, 2009 1 commit
  27. 29 Jul, 2009 2 commits
    • Peter Hutterer's avatar
      record: silence some compiler warnings. · 994f7a1c
      Peter Hutterer authored
      warning: passing argument 4 of ‘RecordAProtocolElement’ discards qualifiers
      from pointer target type
      note: expected ‘pointer’ but argument is of type ‘const void *’
      
      record.c:2745: warning: passing argument 1 of ‘SwapConnSetupInfo’ from
      incompatible pointer type
      ../include/swaprep.h:243: note: expected ‘char *’ but argument is of type
      ‘struct xConnSetup *’
      
      record.c:2745: warning: passing argument 1 of ‘SwapConnSetupInfo’ from
      incompatible pointer type
      ../include/swaprep.h:243: note: expected ‘char *’ but argument is of type
      ‘struct xConnSetup *’
      Signed-off-by: default avatarPeter Hutterer <peter.hutterer@who-t.net>
      994f7a1c
    • Peter Hutterer's avatar
      record: ifdef out RecordExtensionInit and print a warning to the log. · 0217d037
      Peter Hutterer authored
      The RECORD extension is currently broken. By ifdef'ing out the content of
      RecordExtensionInit the extension isn't added to the server's internal list
      and it does not get advertised to the client. Clients can thus fail
      gracefully with a "extension not supported" instead of waiting forever for
      events that never arrive.
      Signed-off-by: default avatarPeter Hutterer <peter.hutterer@who-t.net>
      0217d037
  28. 14 Jul, 2009 1 commit
  29. 18 Jun, 2009 1 commit
  30. 29 Apr, 2009 1 commit
  31. 12 Dec, 2008 1 commit
    • Peter Hutterer's avatar
      Remove #define NEED_EVENTS and NEED_REPLIES · cb95642d
      Peter Hutterer authored
      A grep on xorg/* revealed there's no consumer of this define.
      
      Quote Alan Coopersmith:
      "The consumer was in past versions of the headers now located
      in proto/x11proto - for instance, in X11R6.0's xc/include/Xproto.h,
      all the event definitions were only available if NEED_EVENTS were
      defined, and all the reply definitions required NEED_REPLIES.
      
      Looks like Xproto.h dropped them by X11R6.3, which didn't have
      the #ifdef's anymore, so these are truly ancient now."
      Signed-off-by: default avatarPeter Hutterer <peter.hutterer@redhat.com>
      Signed-off-by: default avatarAdam Jackson <ajax@redhat.com>
      cb95642d