1. 19 Oct, 2015 4 commits
  2. 13 Oct, 2015 2 commits
    • Ken Thomases's avatar
      XQuartz: Fix how we calculate the height of the OSX menu bar · 4513f924
      Ken Thomases authored
      +[NSScreen mainScreen] does not mean the primary display.  It used to mean the
      one with the key window.  When "Displays have separate spaces" is enabled, it
      means the active screen, the one whose menu bar is mostly opaque.  As such, it
      may not be the screen whose lower-left corner is located at (0, 0).  That's
      why its max-Y is not necessarily comparable to its height.  That only works
      for the primary display.
      
      This code could use [[NSScreen screens] firstObject].  This is always the
      primary display, the one whose lower-left corner is at (0, 0).
      
      Once that's done, the above change should be reverted.  The height of the
      visible frame would be the full height of the screen minus the menu bar _and
      the Dock_ if the Dock is along the bottom of the screen.
      
      Actually, there's a theoretically-simpler approach: use
      -[NSMenu menuBarHeight].  That replaces a long-deprecated method
      +[NSMenuView menuBarHeight].  However, there was a bug in Tiger that led to
      the former not working while the latter still worked. I haven't actually
      checked recently.
      
      CrossOver's still-kicking X server code uses this code, which tries all of
      the above:
      
             NSScreen* primaryScreen = [[NSScreen screens] objectAtIndex:0];
             aquaMenuBarHeight = [[NSApp mainMenu] menuBarHeight];
             if (!aquaMenuBarHeight) aquaMenuBarHeight = [NSMenuView menuBarHeight];
             if (!aquaMenuBarHeight) aquaMenuBarHeight =
                 NSHeight([primaryScreen frame]) - NSMaxY([primaryScreen visibleFrame]);
      Reviewed-by: default avatarJeremy Huddleston Sequoia <jeremyhu@apple.com>
      Signed-off-by: default avatarKen Thomases <ken@codeweavers.com>
      4513f924
    • Jeremy Huddleston Sequoia's avatar
  3. 12 Oct, 2015 1 commit
  4. 07 Oct, 2015 2 commits
  5. 06 Oct, 2015 5 commits
  6. 05 Oct, 2015 1 commit
  7. 30 Sep, 2015 2 commits
  8. 29 Sep, 2015 5 commits
  9. 25 Sep, 2015 9 commits
  10. 24 Sep, 2015 7 commits
  11. 23 Sep, 2015 2 commits