• Jeremy Huddleston's avatar
    security: Silence some benign -Wformat warnings · a7a00e4b
    Jeremy Huddleston authored
    XID may be either 'unsigned long' or 'unsigned int' depending on:
    
    typedef unsigned long CARD64;
    typedef unsigned int CARD32;
    typedef unsigned long long CARD64;
    typedef unsigned long CARD32;
    
    typedef unsigned long XID;
    typedef CARD32 XID;
    
    so when building with -Wformat, we get some warnings that are benign.  This silences them.
    
    security.c:215:52: warning: format specifies type 'int' but the argument has type 'XID' (aka 'unsigned long')
          [-Wformat,Format String Issue]
        SecurityAudit("revoked authorization ID %d\n", pAuth->id);
                                                ~~     ^~~~~~~~~
                                                %lu
      CC       dpmsstubs.lo
    security.c:553:25: warning: format specifies type 'int' but the argument has type 'XID' (aka 'unsigned long')
          [-Wformat,Format String Issue]
             client->index, pAuth->id, pAuth->trustLevel, pAuth->timeout,
                            ^~~~~~~~~
    security.c:553:55: warning: format specifies type 'int' but the argument has type 'CARD32' (aka 'unsigned long')
          [-Wformat,Format String Issue]
             client->index, pAuth->id, pAuth->trustLevel, pAuth->timeout,
                                                          ^~~~~~~~~~~~~~
    security.c:554:10: warning: format specifies type 'int' but the argument has type 'XID' (aka 'unsigned long')
          [-Wformat,Format String Issue]
             pAuth->group, eventMask);
             ^~~~~~~~~~~~
    security.c:554:24: warning: format specifies type 'int' but the argument has type 'Mask' (aka 'unsigned long')
          [-Wformat,Format String Issue]
             pAuth->group, eventMask);
                           ^~~~~~~~~
    security.c:781:19: warning: format specifies type 'unsigned int' but the argument has type 'Mask' (aka 'unsigned
    long')
          [-Wformat,Format String Issue]
                      requested, rec->id, cid,
                      ^~~~~~~~~
    security.c:781:30: warning: format specifies type 'unsigned int' but the argument has type 'XID' (aka 'unsigned long')
          [-Wformat,Format String Issue]
                      requested, rec->id, cid,
                                 ^~~~~~~
    security.c:863:23: warning: format specifies type 'unsigned int' but the argument has type 'XID' (aka 'unsigned long')
          [-Wformat,Format String Issue]
                          rec->pWin->drawable.id, wClient(rec->pWin)->index,
                          ^~~~~~~~~~~~~~~~~~~~~~
    security.c:893:31: warning: format specifies type 'unsigned int' but the argument has type 'XID' (aka 'unsigned long')
          [-Wformat,Format String Issue]
                                  rec->pWin->drawable.id,
                                  ^~~~~~~~~~~~~~~~~~~~~~
    security.c:915:39: warning: format specifies type 'unsigned int' but the argument has type 'XID' (aka 'unsigned long')
          [-Wformat,Format String Issue]
                      rec->client->index, rec->pWin->drawable.id,
                                          ^~~~~~~~~~~~~~~~~~~~~~
    Signed-off-by: 's avatarJeremy Huddleston Sequoia <jeremyhu@apple.com>
    Reviewed-by: 's avatarAlan Coopersmith <alan.coopersmith@oracle.com>
    a7a00e4b
Name
Last commit
Last update
..
Makefile.am Loading commit data...
bigreq.c Loading commit data...
dpms.c Loading commit data...
dpmsproc.h Loading commit data...
dpmsstubs.c Loading commit data...
geext.c Loading commit data...
geext.h Loading commit data...
geint.h Loading commit data...
hashtable.c Loading commit data...
hashtable.h Loading commit data...
panoramiX.c Loading commit data...
panoramiX.h Loading commit data...
panoramiXSwap.c Loading commit data...
panoramiXh.h Loading commit data...
panoramiXprocs.c Loading commit data...
panoramiXsrv.h Loading commit data...
saver.c Loading commit data...
security.c Loading commit data...
securitysrv.h Loading commit data...
shape.c Loading commit data...
shm.c Loading commit data...
shmint.h Loading commit data...
sleepuntil.c Loading commit data...
sleepuntil.h Loading commit data...
sync.c Loading commit data...
syncsdk.h Loading commit data...
syncsrv.h Loading commit data...
xace.c Loading commit data...
xace.h Loading commit data...
xacestr.h Loading commit data...
xcmisc.c Loading commit data...
xf86bigfont.c Loading commit data...
xf86bigfontsrv.h Loading commit data...
xres.c Loading commit data...
xselinux.h Loading commit data...
xselinux_ext.c Loading commit data...
xselinux_hooks.c Loading commit data...
xselinux_label.c Loading commit data...
xselinuxint.h Loading commit data...
xtest.c Loading commit data...
xvdisp.c Loading commit data...
xvdisp.h Loading commit data...
xvdix.h Loading commit data...
xvmain.c Loading commit data...
xvmc.c Loading commit data...
xvmcext.h Loading commit data...