• Jeremy Huddleston's avatar
    security: Silence some benign -Wformat warnings · a7a00e4b
    Jeremy Huddleston authored
    XID may be either 'unsigned long' or 'unsigned int' depending on:
    
    typedef unsigned long CARD64;
    typedef unsigned int CARD32;
    typedef unsigned long long CARD64;
    typedef unsigned long CARD32;
    
    typedef unsigned long XID;
    typedef CARD32 XID;
    
    so when building with -Wformat, we get some warnings that are benign.  This silences them.
    
    security.c:215:52: warning: format specifies type 'int' but the argument has type 'XID' (aka 'unsigned long')
          [-Wformat,Format String Issue]
        SecurityAudit("revoked authorization ID %d\n", pAuth->id);
                                                ~~     ^~~~~~~~~
                                                %lu
      CC       dpmsstubs.lo
    security.c:553:25: warning: format specifies type 'int' but the argument has type 'XID' (aka 'unsigned long')
          [-Wformat,Format String Issue]
             client->index, pAuth->id, pAuth->trustLevel, pAuth->timeout,
                            ^~~~~~~~~
    security.c:553:55: warning: format specifies type 'int' but the argument has type 'CARD32' (aka 'unsigned long')
          [-Wformat,Format String Issue]
             client->index, pAuth->id, pAuth->trustLevel, pAuth->timeout,
                                                          ^~~~~~~~~~~~~~
    security.c:554:10: warning: format specifies type 'int' but the argument has type 'XID' (aka 'unsigned long')
          [-Wformat,Format String Issue]
             pAuth->group, eventMask);
             ^~~~~~~~~~~~
    security.c:554:24: warning: format specifies type 'int' but the argument has type 'Mask' (aka 'unsigned long')
          [-Wformat,Format String Issue]
             pAuth->group, eventMask);
                           ^~~~~~~~~
    security.c:781:19: warning: format specifies type 'unsigned int' but the argument has type 'Mask' (aka 'unsigned
    long')
          [-Wformat,Format String Issue]
                      requested, rec->id, cid,
                      ^~~~~~~~~
    security.c:781:30: warning: format specifies type 'unsigned int' but the argument has type 'XID' (aka 'unsigned long')
          [-Wformat,Format String Issue]
                      requested, rec->id, cid,
                                 ^~~~~~~
    security.c:863:23: warning: format specifies type 'unsigned int' but the argument has type 'XID' (aka 'unsigned long')
          [-Wformat,Format String Issue]
                          rec->pWin->drawable.id, wClient(rec->pWin)->index,
                          ^~~~~~~~~~~~~~~~~~~~~~
    security.c:893:31: warning: format specifies type 'unsigned int' but the argument has type 'XID' (aka 'unsigned long')
          [-Wformat,Format String Issue]
                                  rec->pWin->drawable.id,
                                  ^~~~~~~~~~~~~~~~~~~~~~
    security.c:915:39: warning: format specifies type 'unsigned int' but the argument has type 'XID' (aka 'unsigned long')
          [-Wformat,Format String Issue]
                      rec->client->index, rec->pWin->drawable.id,
                                          ^~~~~~~~~~~~~~~~~~~~~~
    Signed-off-by: default avatarJeremy Huddleston Sequoia <jeremyhu@apple.com>
    Reviewed-by: default avatarAlan Coopersmith <alan.coopersmith@oracle.com>
    a7a00e4b
Name
Last commit
Last update
Xext Loading commit data...
Xi Loading commit data...
composite Loading commit data...
config Loading commit data...
damageext Loading commit data...
dbe Loading commit data...
dix Loading commit data...
doc Loading commit data...
dri3 Loading commit data...
exa Loading commit data...
fb Loading commit data...
glamor Loading commit data...
glx Loading commit data...
hw Loading commit data...
include Loading commit data...
m4 Loading commit data...
man Loading commit data...
mi Loading commit data...
miext Loading commit data...
os Loading commit data...
present Loading commit data...
pseudoramiX Loading commit data...
randr Loading commit data...
record Loading commit data...
render Loading commit data...
test Loading commit data...
xfixes Loading commit data...
xkb Loading commit data...
.dir-locals.el Loading commit data...
.gitignore Loading commit data...
COPYING Loading commit data...
Makefile.am Loading commit data...
README Loading commit data...
autogen.sh Loading commit data...
configure.ac Loading commit data...
devbook.am Loading commit data...
docbook.am Loading commit data...
fix-miregion Loading commit data...
fix-miregion-private Loading commit data...
fix-patch-whitespace Loading commit data...
fix-region Loading commit data...
manpages.am Loading commit data...
xorg-server.m4 Loading commit data...
xorg-server.pc.in Loading commit data...
xserver.ent.in Loading commit data...