1. 02 Sep, 2018 1 commit
    • Ell's avatar
      app, icons, menus: add performance-log recording to the dashboard · 40ac4f7b
      Ell authored
      Add an option to record a performance log through the dashboard.
      The log contains a series of samples of the dashboard variables, as
      well as the full program backtrace, when available.  As such, it
      essentially acts as a built-in profiler, which allows us to
      correlate program execution with the information available through
      the dashboard.  It is meant to be used for creating logs to
      accompany perofrmance-related bug reports, as well as for profiling
      GIMP during development.
      The sample frequency defaults to 10 samples per second, but can be
      environment variable.  Backtraces are included by default when
      available, but can be suppressed using the
      GIMP_PERFORMANCE_LOG_NO_BACKTRACE environment variable.
      Logs are created through the new "record" button at the bottom of
      the dashboard dialog.  When pressed, a file dialog is opened to
      select the log file, and, once confirmed, data is being recorded to
      the selected file.  Recording is stopped by pressing the "record"
      button again (we use a highlight to indicate that recording is
      While recording, the "reset" button is replaced with an "add marker"
      button, which can be used to add event markers to the log.  These
      can be used to mark events of interest, such as "started painting"
      and "stopped painting", which then appear in the log as part of the
      sample stream.  Markers are numbered sequentually, and the number
      of the next (to-be-added) marker appears on the button.  Shift-
      clicking the button adds an empty (description-less) marker, which
      is only identified by its number; this can be used when markers
      need to be added quickly.
      The log is an XML file, containing some extra information (such as
      the output of "$ gimp -v", and symbol information) in addition to
      the samples.  The data in the file is delta-encoded to reduce the
      file size, meaning that samples (as well as some other elements)
      only specify the changes since the previous sample.  This adds a
      necessary decoding step before data can be processed; the next
      commit adds a tool that does that.
      There are currently no tools to actually analyze the data -- that's
      still TBD -- but at least we can start gathering it.
  2. 19 Aug, 2018 1 commit
  3. 12 Aug, 2018 1 commit
    • Jehan's avatar
      configure: GLIB_COMPILE_RESOURCES is wrong when cross-compiling. · d1d9eb17
      Jehan authored
      AM_PATH_GLIB_2_0 m4 macro actually computes this value using
      $PKG_CONFIG. Yet $PKG_CONFIG variable is the pkg-config tool looking for
      target libraries (not host), hence it would return the executable
      `glib-compile-resources` built for the target.
      Also using the same variable name invalidates our test: our own
      AC_PATH_PROG was never run as the variable was already set. And no
      environment variable could override this test anymore either. This is
      why I rename the test variable to HOST_GLIB_COMPILE_RESOURCES.
  4. 10 Aug, 2018 1 commit
  5. 30 Jul, 2018 2 commits
    • Jehan's avatar
      icons: update icons for new top-to-bottom text feature. · ff13f75e
      Jehan authored
      They are not perfect (not a designer here!) but a bit less packed than
      the previous one. So hopefully more understandable.
      (cherry picked from commit e326faa77c32143add199475c022d78a470cad78)
    • ONO Yoshio's avatar
      MR !19: Add support for vertical text writing. · e2958714
      ONO Yoshio authored
      Squashed commit of the following:
      commit ee1ff7d502658cfa1248a13a3f0348495db07eda
      Author: ONO Yoshio <ohtsuka.yoshio@gmail.com>
      Date:   Sun Jul 29 00:31:47 2018 +0900
          Fixed that gimp-text-dir-ttb-* icons are lacked in Symbolic.
      commit d87d012d697628da28fe90199cc04b95b72ba8ef
      Author: ONO Yoshio <ohtsuka.yoshio@gmail.com>
      Date:   Sat Jul 28 16:23:10 2018 +0900
          Fix a typo.
      commit cf0238bf7df56c384cdf3b7ec69557d14740f853
      Author: ONO Yoshio <ohtsuka.yoshio@gmail.com>
      Date:   Sat Jul 28 15:50:57 2018 +0900
          Fixed seg fault error.
      commit b07f60d06fa1a753fda5b4d46af01698c344154e
      Author: ONO Yoshio <ohtsuka.yoshio@gmail.com>
      Date:   Fri Jul 27 17:15:34 2018 +0900
          Add support for vertical text writing.
      (cherry picked from commit 587d9bbb03b19558b7900f61c852a470f85761aa)
  6. 23 Jul, 2018 1 commit
  7. 20 Jul, 2018 1 commit
  8. 23 Jun, 2018 10 commits
    • Jehan's avatar
      icons: work around dimension bug of librsvg for a bunch of color icons. · be3abe6c
      Jehan authored
      It feels I am just fighting against the system. So annoying!
      (cherry picked from commit b87d34bacefd3f26fbb59eda4ff213c398c85efe)
    • Jehan's avatar
      icons: complete color-scalable SVG. · 87d2dbbe
      Jehan authored
      Preparing extracting icons from a single file.
      (cherry picked from commit 199df5a128d0a46d0a870eda5c7a79fd5d2d2677)
    • Jehan's avatar
      icons: update various icons to account for librsvg bugs. · 402c0d98
      Jehan authored
      It should now be possible to fully export our symbolic icons from a
      single central file.
      My long-standing bug of librsvg#250 is still opened and unfixed, but it
      turns out most issues I encountered are anyway also problems when
      recoloring symbolic icons in GTK+ (like using strokes instead of
      fills!). So let's just bypass all problems at once by accounting for
      these issues in the design.
      (cherry picked from commit 4c68d5dfc903553f03cbbfbf56cefe50317a4b8e)
    • Jehan's avatar
      icons: fix many icons for proper recoloring. · 9bc78a3b
      Jehan authored
      I tried to fix all the icons I could see which had issues regarding all
      recoloring matters (using fill not stroke, change circle/ellipses to
      paths, etc.) when looking at a blank canvas.
      I'm sure I still miss a lot but that will do for now.
      (cherry picked from commit 8811b0d9160232abfc5fb8415ed0f207eb78d194)
    • Jehan's avatar
      icons: force colors on some icons. · e960c488
      Jehan authored
      Sometimes even within symbolic icons, parts of the design must keep
      fixed colors, when they are semantic. For instance this is the case for
      the color-picker-(black|gray|white) icons or the gimp-default-colors.
      The trick used by GTK+ to recolor is by supplying an additional CSS
      style to icons which overrides inline CSS thanks to "! important"
      keyword. Our own trick to circumvent this trick is to set "!important"
      in inline CSS when one wishes not to have it overrided by the general
      Right now I am doing the edit by hand with vim because Inkscape doesn't
      seem to validate this keyword if I add it manually in its XML editor. So
      what I did is add the "color-important" label on such object, and I will
      later modify my SVG export tool to add !important on such object "fill"
      values at export time.
      (cherry picked from commit 5d5bbeb88b6519c434e7ad1653b1374cb06704ea)
    • Jehan's avatar
      icons: fix various symbolic icons not properly recolored. · fa6f2f65
      Jehan authored
      The current recolorization code only recolors paths and rectangles. In
      particular it leaves circles and ellipses as-is.
      I opened the merge request gtk!214 for this issue. But in the meantime,
      it is quite easy to change circles and ellipses into path with "object
      to path" in Inkscape.
      A second problem is that it only recolors fills, not strokes, as
      previously stated. So I need to remove strokes from icons, or transform
      them to paths.
      (cherry picked from commit fd460182038d1b9259b07dc353095891861d242e)
    • Jehan's avatar
      icons: larger spacing between broken chains. · eb821610
      Jehan authored
      It seems not wide enough to differentiate easily the broken and
      non-broken chains. So let's make this gap bigger.
      (cherry picked from commit a5afb04501e6680b285846c833c7b187370f77ae)
    • Jehan's avatar
      icons: fixing more icons. · 99e6b365
      Jehan authored
      This time, 2 icons still had problems because of visible rectangles.
      Fixing "gimp-prefs-folders" and "gimp-prefs-folders-mypaint-brushes".
      (cherry picked from commit 2bb8afd119a36739bf00a6ef283e782ace0d4567)
    • Jehan's avatar
      icons: fix various icons broken when recoloring with CSS. · 11dd2365
      Jehan authored
      For anyone wishing to help me fix icons, here is the trick: apparently
      GTK+ would fill the paths with CSS colors, not stroke them. So when we
      have icon drawing based on path-stroking, they don't end up as expected.
      In Inkscape, just run "Stroke to Path" to transform a stroke design in a
      fill design.
      I am fixing "gimp-tool-cage", "document-revert", "gimp-image-reload",
      "gimp-reset" and "view-refresh". More to follow as we discover them, I
      (cherry picked from commit 4b6869dd67869fdbf9b0d98cfdaed4e10775bcaa)
    • Jehan's avatar
      icons: make gimp-tool-ellipse-select symmetric. · 709e5e4c
      Jehan authored
      I may not be an icon designer, but this icon be so clearly asymmetric
      always deeply annoyed me.
      (cherry picked from commit 45f46db815322b646728fb3956e4818192e80b2d)
  9. 14 Jun, 2018 2 commits
    • Jehan's avatar
      icons: clean the symbolic vector file. · 8ede025c
      Jehan authored
      All icons are now in the file.
      (cherry picked from commit 3096fd295af5c129477bbe61b1919d0603aa3299)
    • Jehan's avatar
      icons: fix symbolic icons. · 98763dde
      Jehan authored
      With the symbolic-awareness of GTK+, vector icons are recolored (using
      fg, success, warning and error colors). Unfortunately it was also
      recoloring some rectangles with neither fill nor stroke, which were
      using only to get appropriate icon size (these icons were therefore
      displayed as just a square).
      I made a quick pass in our icons to "fix" these. I expect I may have
      missed some icons, or at the opposite, I may have broken other icons by
      removing rectangles which should not have been removed. If you find any
      such icon, please fix.
      Also some icons do not look quite right just now. We will have to create
      new guidelines on how to make symbolic icons and fix/redesign some, I
      (cherry picked from commit 0c3659c5f1297614322774be766edd5f1cee5654)
  10. 20 May, 2018 1 commit
  11. 15 Apr, 2018 1 commit
  12. 13 Apr, 2018 1 commit
  13. 24 Feb, 2018 3 commits
  14. 23 Feb, 2018 1 commit
    • Aryeom Han's avatar
      icons: new symbolic icons gimp-attach and gimp-detach. · a542bb1e
      Aryeom Han authored
      These are simple on purpose since the smaller size they are displayed at
      is 12 px (in overlay dialogs) so it needs to be simple shapes.
      Note by Jehan: gimpicons.h and Makefile.am not updated yet. Waiting for
      the color icons first.
  15. 06 Jan, 2018 1 commit
  16. 05 Jan, 2018 4 commits
  17. 28 Dec, 2017 1 commit
  18. 27 Dec, 2017 7 commits