1. 19 Oct, 2018 1 commit
    • Josef Ridky's avatar
      Issue #2087 - Issues discovered by coverity scan · 56c8f832
      Josef Ridky authored
      Add missing fclose invocations and fix copy-paste issue.
      
      This issues has been discovered by coverity scan proceeded by Red Hat.
      
      Fixed some mistakes in the patch and added more fclose() (Mitch)
      56c8f832
  2. 09 Oct, 2018 1 commit
  3. 01 Oct, 2018 1 commit
  4. 29 Sep, 2018 2 commits
  5. 26 Sep, 2018 1 commit
    • Ell's avatar
      plug-ins: in script-fu, don't query PDB procedures' info on startup · 97a29b1e
      Ell authored
      script-fu used to query the information of every PDB procedure on
      startup, in order to get the number of parameters for each
      procedure.  This was done so that nullary procedures were defined
      in such a way as to accept (and ignore) any number of arguments
      (and at least one of the scripts we ship relies on this behavior).
      However, this requires expensive back-and-forth communication with
      the main GIMP process, which notable slowed down script-fu's
      startup, and had a non-negligible impact on GIMP's startup time.
      
      Instead, avoid querying procedure information, and implement the
      special behavior for nullary procedures at call time.  We do this
      by defining, in addition to the "strict" gimp-proc-db-call
      procedure, a "permissive" -gimp-proc-db-call internal procedure,
      and using the latter to call the predefined PDB procedures.
      
      (cherry picked from commit 9a2999a553c59927bef382b28d4ec2cf8ac8ce1a)
      97a29b1e
  6. 19 Sep, 2018 2 commits
  7. 18 Sep, 2018 13 commits
  8. 17 Sep, 2018 1 commit
    • luz.paz's avatar
      Misc. typo fixes · 23648e75
      luz.paz authored
      Found via `codespell`
      
      (cherry picked from commit 386587736f3ba57047206ecbf8059b26c7a87af9)
      23648e75
  9. 16 Sep, 2018 3 commits
    • Jehan's avatar
      plug-ins: add the "msf1" brand for HEIF files. · e1cf3405
      Jehan authored
      After Dirk Farin had another look in the specs, it turns out that "mif1"
      is actually allowed as major brand for HEIF. Also adding "msf1" which is
      the equivalent for image sequences.
      
      (cherry picked from commit 64b00b5c7fdf80c0fbbbd72beba15bc1b34d5543)
      e1cf3405
    • Jehan's avatar
      Issue #2209: more accurate magic for HEIF files. · e4bff4c8
      Jehan authored
      Just looking for "ftyp" would also match other ISOBMFF files (.mov or
      .mp4 files for instance). These are the possible 4-byte "brand" code
      which can follow "ftyp", as listed by Dirk Farin from libheif.
      
      I add the "mif1" brand, as I encountered some files using this magic
      (even though this should normally not be valid apparently, yet the file
      loaded fine in GIMP).
      
      This is not perfect as the standard allows potentially very big box
      headers, in which case 8 bytes (the "largesize" slot) may be inserted
      between "ftyp" and the brand, as I understand it. But this is actually
      unlikely enough to probably never happen (the compatible brands list
      would have to be huuuge, as it looks like this is the only extendable
      part in a ftyp box). So let's assume this just never happens.
      
      See also: https://github.com/strukturag/libheif/issues/83
      
      (cherry picked from commit 4ad3993eca935854ef2f5664fb77a75c128bbf4d)
      e4bff4c8
    • Jehan's avatar
      Issue #2209: HEIF: Invalid input: No 'ftyp' box. · e76d0941
      Jehan authored
      Adding a magic number for HEIC/HEIF, which would allow to discard
      obvious non-HEIC images even with the wrong extension.
      
      Note: it looks like this magic number would also match more generically
      other ISO base media file format (ISOBMFF) formats, like .mov or .mp4
      files. I am enquiring for better magic but for now, this is better than
      nothing.
      
      (cherry picked from commit d738d2f645abe16457311389b8827ecd80ca71da)
      e76d0941
  10. 19 Aug, 2018 1 commit
    • Jehan's avatar
      Issue #1970: Python-fu missing in 2.10.4. · 8f21c948
      Jehan authored
      Do not set the interpreter to `python2` but to whatever was found by the
      AM_PATH_PYTHON2() m4 macro.
      It looks like the Python2 binary we ship in our DMG may be call "python"
      only (without the '2'). Let's just make our code more resilient to
      various builds.
      I am not sure yet this is the only/actual problem for this issue on
      macOS, but this is at least in the right way.
      8f21c948
  11. 17 Aug, 2018 1 commit
    • Jehan's avatar
      plug-ins: include the right python source in the distribution. · 55a7872e
      Jehan authored
      The python path with directory are generated files and should not be in
      the dist. The previous commit was fixing an in-tree `make check` but
      this one fixes the `make distcheck` as the dist was packaging the wrong
      python files.
      55a7872e
  12. 16 Aug, 2018 4 commits
    • Jehan's avatar
      Issue #788: also install all python plug-ins in their own directory. · 035c7854
      Jehan authored
      It seems I forgot to also install python plug-ins in a subdirectory
      (because they are deactivated on master for the time being). I even
      found a year-old patch from myself rotting in the tracker, and which was
      doing exactly this.
      I redid it, improved to fit changes.
      
      (cherry picked from commit dbb9555d2f22b796b490d205563bdd272159f05d)
      035c7854
    • Jehan's avatar
      plug-ins: fix individual install targets of common plug-ins. · 5682a016
      Jehan authored
      The "rule from hell", dixit Mitch. :-)
      
      (cherry picked from commit 2713bc428528524e3629907b8b121846c90db95a)
      5682a016
    • Jehan's avatar
      plug-ins: make plug-ins inside common/ to also install in subfolders. · 25f09934
      Jehan authored
      (cherry picked from commit d89ad95cc78e6167353635cbb0240cfa17999834)
      25f09934
    • Jehan's avatar
      plug-ins: install plug-ins in subfolder. · 79961a65
      Jehan authored
      I am going to forbid plug-ins from being installed directly in the root
      of the plug-ins/ directory. They will have to be installed in a
      subdirectory named the same as the entry point binary.
      This may seem useless for our core plug-ins which are nearly all
      self-contained in single binaries, but this is actually a necessary
      restriction to eliminate totally the DLL hell issue on Windows. Moving
      core plug-ins in subfolders is only a necessary consequence for it.
      
      (cherry picked from commit 870ca6334d79b421811e5ecd817883a5cff2673a)
      79961a65
  13. 12 Aug, 2018 2 commits
    • Jehan's avatar
      plug-ins: replace s/printf/g_printf/ · c49afa4f
      Jehan authored
      When cross-compiling, I got various linking errors for printf() calls:
      > undefined reference to `libintl_printf'
      
      I am unsure why, since this is not recent code, and it used to build
      fine with mingw64 compilers (last I cross-built, which is many months
      ago). Anyway g_printf() works fine, all necessary libs are already
      linked, and it is supposed to be a synonym. So let's just go the easy
      way and use g_printf() only.
      c49afa4f
    • Jehan's avatar
      configure: GLIB_COMPILE_RESOURCES is wrong when cross-compiling. · d1d9eb17
      Jehan authored
      AM_PATH_GLIB_2_0 m4 macro actually computes this value using
      $PKG_CONFIG. Yet $PKG_CONFIG variable is the pkg-config tool looking for
      target libraries (not host), hence it would return the executable
      `glib-compile-resources` built for the target.
      
      Also using the same variable name invalidates our test: our own
      AC_PATH_PROG was never run as the variable was already set. And no
      environment variable could override this test anymore either. This is
      why I rename the test variable to HOST_GLIB_COMPILE_RESOURCES.
      d1d9eb17
  14. 06 Aug, 2018 1 commit
  15. 17 Jul, 2018 1 commit
    • Ell's avatar
      Issue #1825 - PSD files are loaded as merged by default ... · dd91322a
      Ell authored
      ... depending on UI language
      
      Use gimp_register_file_handler_priority(), added in the previous
      commit, to increase the priority of the merged PSD loader, so that
      the non-merged loader is always preferred over it (unless
      explicitly chosen), regardless of the UI language.
      
      (cherry picked from commit 03201262542072dc1231bf5d82298345c5d26618)
      dd91322a
  16. 14 Jul, 2018 3 commits
  17. 13 Jul, 2018 1 commit
  18. 11 Jul, 2018 1 commit