Hari Rana authored Apr 13, 2024 and Georges Basile Stavracas Neto committed Apr 26, 2024

This changes the tooltip text display area uniquely to the
subtitle label, and excludes HTML elements and attributes
from accessibility labels.

Jean-François Fortin Tam authored Feb 25, 2024 and Georges Basile Stavracas Neto committed Apr 26, 2024

In commit 1494f740, we focus the summary entry when opening the dialog.
However, this prevents the Escape keyboard shortcut from working
when opening a read-only event after having opened a writable event.

Set focus onto the "Done" button when showing a read-only event,
as it's the only widget that can be activated/clicked in this situation.

This makes the "Escape", "Spacebar" and "Enter" keyboard shortcuts work.

Fixes https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/1180

Hari Rana authored Mar 16, 2024 and Georges Basile Stavracas Neto committed Apr 26, 2024

This removes a lot of duplicated code, as we can simply reuse the
appdata file. It will also allow us to add release notes without
needing to rewrite them. A simple update in the
`adw_about_dialog_new_from_appdata` method will take care of
displaying the release notes.

This also renames the appdata file from `appdata.xml` to
`metainfo.xml`, as `appdata.xml` is considered a legacy filename.

Aurélien Delory authored Feb 24, 2024 and Georges Basile Stavracas Neto committed May 01, 2024

Closes: https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/1146

Make GcalCalendarManagementPage require implementors to be
AdwNavigationPages

Jamie Gravendeel authored Apr 20, 2024 and Georges Basile Stavracas Neto committed May 01, 2024

Also puts the remove button in its own PreferencesGroup so that the row
can be showed separately from the rest of the list.

Jean-François Fortin Tam authored Feb 21, 2024 and Georges Basile Stavracas Neto committed May 01, 2024

This makes it easier to troubleshoot what triggers and stops searches.

Jean-François Fortin Tam authored Feb 21, 2024 and Georges Basile Stavracas Neto committed May 01, 2024

A more realistic default delay avoids spamming the search backends.
Benefits of this approach:

* Improves overall performance, allows wider search timeline ranges;
* Reduces power consumption;
* Reduces or eliminates flickering in the GUI;
* Reduces the amount of trace logging noise by more than 15x.

Fixes https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/1170

Jean-François Fortin Tam authored Feb 23, 2024 and Georges Basile Stavracas Neto committed May 01, 2024

Non-technical users may not realize why they can not edit some events
from read-only subscribed remote calendars.

A symbolic padlock icon does not suffice to make this obvious.
This tooltip makes the UI self-documenting, and improves accessibility.

As per mockups.

See https://gitlab.gnome.org/Teams/Design/app-mockups/-/issues/102

As per mockups.

Update relocated metainfo file location in the POTFILES.in

A leftover from: 0c8e1834

- sync the visuals with that of the mini-calendar in the Shell
- make other month days more visible/have greater contrast

Fixes #1244

We'll start using CSS variables

This vastly simplifies the code!

José Guilherme authored Jun 10, 2024 and Georges Basile Stavracas Neto committed Jul 02, 2024

When the text is pasted on gitlab, it recognizes the version SHA and
places a hyperlink to the commit, which might facilitate unintended
references to be created.

By enclosing the string between backticks, gitlab does not recognize it.

Closes #1246

Sabri Ünal authored May 06, 2024 and Georges Basile Stavracas Neto committed Jul 02, 2024

Due to some languages using the "nplurals=1; plural=0" plural form,
and the string already in use in src/gui/calendar-management/gcal-new-calendar-page.c
with g_dngettext, add context to the other "Add Calendar" strings to fix the problem.

AFAIK, other locales (confirmed: be_BY, fa_IR, id_ID, kk_KZ, ko_KR, my_MM, zh_CN)
are also affected by this issue.

They're failing CI, I don't know why, and I'm afraid it's not really
related to GNOME Calendar itself. So just disable them for now.

Otávio Silva authored Jun 24, 2024 and Georges Basile Stavracas Neto committed Jul 09, 2024

This function can be useful in contexts other than the creation of
the meeting row.

Otávio Silva authored Jun 24, 2024 and Georges Basile Stavracas Neto committed Jul 09, 2024

In case the location is an URL, it is irrelevant to display the full
link,
as it is not clickable. So, this shows the meeting service provider if
it
is known or reduces the text in the tooltip, preventing it from covering
other information in the calendar.

Closes: #1232

Otávio Silva authored Jul 04, 2024 and Georges Basile Stavracas Neto committed Jul 09, 2024

In the tooltip, the event location always has the preposition "At ...".
This changes it to "On ..." when the location is a known meeting
service.

Vitaly Dyachkov authored Jul 04, 2024 and Georges Basile Stavracas Neto committed Jul 09, 2024

Currenlty, there is no easy way to copy an event title.

Abdullahi Usman authored May 05, 2024 and Georges Basile Stavracas Neto committed Jul 09, 2024

Alarm toggle state are in three stages because we do not update both
icon and active when pressed.

we now update the icons to match their states.

Abdullahi Usman authored May 05, 2024 and Georges Basile Stavracas Neto committed Jul 09, 2024

When the alarm sound changes, the change is not updated because
gcal-manager does not see the changes.

We now update the components and make more comparisons so that
it can be seen by gcal-manager

Daniel Garcia Moreno authored Nov 09, 2023 and Georges Basile Stavracas Neto committed Jul 09, 2024

Fix https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/898
Fix https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/968

Daniel Garcia Moreno authored Nov 09, 2023 and Georges Basile Stavracas Neto committed Jul 09, 2024

This patch do not sends ADD_EVENT for events that are multiday and are
part of the old_range when calling calculate_changed_events. This will
prevent multiday duplicate events to appear in the agenda widget when
using the week view.

If the event is a multiday and it was in the previous range, it won't
send the REMOVE_EVENT so multiday events won't dissapear when it's still
relevant.

See https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/898#note_1602391

I shouldn't write code in a hurry

When subscribing to one or multiple online Webcal or CalDAV calendars,
do not unexpectedly create an extra local calendar.

While this doesn't allow customizing names & colors while subscribing,
users can still easily set those just after adding the subscriptions,
as they are then returned to the "Calendars" page of "Manage Calendars".

Punting this to a separate step might not seem like the "perfect" flow,
but it works well enough and fixes the buggy UX that we currently had.

Fixes https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/566
Fixes https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/978

Timeline subscribers (i.e week_view, month_view, agenda_view, date_chooser) were not
properly notified of event(s) moved out of their listening ranges.
We notify them to remove these events.

fixes: #994 and #1043

When dealing with floating time events the timezone used was UTC,
but according to RFC5545 when the timezone is not specified the
local timezone should be used.

Fixes #171

Add test to check the timezone of events.

See https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/171

Otávio Silva authored Jul 18, 2024 and Georges Basile Stavracas Neto committed Jul 20, 2024

Modify the GcalImportFileRow struct to now have the
property GcalContext.

Otávio Silva authored Jul 18, 2024 and Georges Basile Stavracas Neto committed Jul 20, 2024

Add GObject.constructed override and call the setup_calendars
function inside of it.

Otávio Silva authored Jul 18, 2024 and Georges Basile Stavracas Neto committed Jul 20, 2024

In the import dialog, start and end date-time fields were being
incorrectly displayed, not considering the local timezone and the
24-hours vs 12-hours format used by the user. Also, the libical
already deals with the case in which events do not have the DTEND
field, simplifying the implementation.

Fixes #1175

because days starts at 01:01:01 (HH:MM::SS), some events at the start
or end of day may be push into another day or back into previous day.
day should starts at 00:00:00 and previous day should stop at 23:59:59.

fixes:
https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/1255

Hari Rana authored Feb 12, 2024 and Georges Basile Stavracas Neto committed Jul 22, 2024

This builds on top of the existing UI/code, while adding a few improvements and
behavioral changes:

- The popover displays the changes-prevent icon when the even is read-only.
- Each section is properly separated with `GtkSeparator`s, with equal amount of
top and bottom margins.
- Location and Meetings section are mutually exclusive; only one is shown.
- When an event has no event note, the popover will always display that there's no
description.
- `GcalMeetingRow` has been ported to `GtkListBoxRow`.
- The action button adapts its icon and tooltip text depending on the event
permission.

Automeris naranja authored Jul 23, 2024 and Georges Basile Stavracas Neto committed Jul 24, 2024

AdwToast title is already bold, so using HTML b tags doesn't do
anything. To fix this, use quote symbols instead.

And:
- Use the quote symbols recommended by HIG:
https://developer.gnome.org/hig/guidelines/typography.html#take-advantage-of-unicode
- Add a translator comment explaining what "%s" means

Diego Iván authored Jul 22, 2024 and Georges Basile Stavracas Neto committed Jul 24, 2024

This also brings some other changes:

* Enables closing the window using Escape
* Fixes a few criticals

Closes #1258

Diego Iván authored Jul 22, 2024 and Georges Basile Stavracas Neto committed Jul 24, 2024

Closes #1208

Fixes a regression introduced in !465 by replacing the
`GtkHeaderBar` with a `AdwHeaderBar`

Closes #1265

whenever a day is selected anywhere, let start it at 00:00:00

fixes: https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/1256

Diego Iván authored Jul 29, 2024 and Georges Basile Stavracas Neto committed Aug 05, 2024

This toast overlay will be used to display error messages
in import operations, namely, files that could not be
imported in a drag and drop operation

Diego Iván authored Jul 29, 2024 and Georges Basile Stavracas Neto committed Aug 05, 2024

A new widget to perform drag and drop operations, for example,
dropping ICS files to the GcalWindow. It allows to overlay
a child for visual feedback when a DnD operation is done.

either in the main window or in the import dialog,
depending on whether none could be imported, or just some
of them.

It is based on Loupe's DragOverlay widget.

Closes #1257

Enzo MAROS authored Jul 28, 2024 and Georges Basile Stavracas Neto committed Aug 05, 2024

When enabling or disabling a calendar through the GcalCalendarButton
popover, the user loses the ability to click right after. This bug was
caused by the update mechanism, triggered by the calendar-changed signal,
which would delete then create a brand new GtkWidget for the row.

To fix this, I replaced the manual signal-based create, update and
remove mechanisms with a binding between the GtkListBox and the calendar
GListModel.

Diego Iván authored Jul 23, 2024 and Georges Basile Stavracas Neto committed Aug 05, 2024

Ports the import dialog out of AdwPreferencesPage to
modify some properties of the ScrolledWindow so the dialog
does the sizing as expected

This avoids scrolling when the natural height of the contents
fits within the window