- Add vcs-browser URL.
- Add translate URL.
- Update the donation URL.
- Update the homepage URL.

These URLs are visible on GNOME Control Center and Flathub.

More information: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-url

The convention is to use US strings by default.

(cherry picked from commit 3f106ab32d4f51278e87d3880017cd49cab9747d)

- Add the `<developer><name>` tag
- Mark the `<developer_name>` tag as  deprecated
- Use appstreamcli to validate appdata
- Remove one of Purism tag to pass appstreamcli validation

There are no longer being used and actually give out errors when using
some appstream validation tools.

Related: https://github.com/ximion/appstream/issues/476

"The old generator also included all the none-value entries—it
no longer does this, you can safely remove them.

If it only consists of none values, it’s safe to shorten it to just:
`<content_rating type="oars-1.1" />`"

More information: https://docs.flathub.org/docs/for-app-authors/appdata-guidelines/#oars-information

We've for a very long time not generated a NEWS file, as using AppData
files provide users better ways of (structurally) getting changelogs,
and git forges like GitLab provide developer-tailored information such
as Merge Request information.

Just remove the NEWS file and add the command to generate it to the
README file (and while at it, replace `appstream-util` with the upstream
maintained `appstreamcli`

Directories like `_build` are specific to developers' tastes and should
be added to global are local gitignores by the people themselves.

We stopped using libgnomedesktop with the move to GTK4, so remove the
files that were still lingering.

Using GtkListView's `list.scroll-to-item` action was a temporary
workaround until we had the proper API. Let's make sure we actually use
it now that it's available.

Gotam Gorabh authored Aug 15, 2022 and Niels De Graef committed Jan 06, 2024

changing the word "Remove" to "Delete" to delete the selected contacts.
The "Delete" word fit for the toast that pop up after deleting the contacts.

Similarly to the Flathub manifest of GNOME Contacts Flatpak [1], enable
access to evolution-data-server avatars by providing read-only access to
its default cache folder.

[1]: https://github.com/flathub/org.gnome.Contacts/commit/f9b63a6ad99226ca1c0a55022fd3c27c52878b08

Fixes: https://gitlab.gnome.org/GNOME/gnome-contacts/-/issues/333

This commit changes a couple of things about the import UI:

First of all, rather than showing a "simple" message dialog, we have a
custom `ImportDialog` class to allow more extended interfaces.

Since we now have this new-fangled dialog, we can actually use it to
show the list of contacts that would be imported, so we can give a clear
idea to the user what we're exactly importing.

Finally, thanks to the custom UI, this allows us to enable importing
from multiple files, rather than just a single file.

Fixes: https://gitlab.gnome.org/GNOME/gnome-contacts/-/issues/328
Related: https://gitlab.gnome.org/GNOME/gnome-contacts/-/issues/329

(cherry picked from commit db29917ea8792e0e08764f87188937909c55a0c5)

Dylan McCall authored Jul 29, 2023 and Niels De Graef committed Jan 08, 2024

This fixes a bug where the application would enter a strange state after
the user opens a new contact through the search provider while editing
a different contact. Instead, we will add a new method,
`Contacts.MainWindow.navigation_request`, and only change the selected
contact if the result is true.

Fixes: https://gitlab.gnome.org/GNOME/gnome-contacts/-/issues/319

When clicking the check button of a contact in the contact list
directly (rather than the row), this didn't actually do anything.
This commit adds the necessary handlers (and adds some funky workarounds
to make sure we don't end up in an endless loop).

Fixes: https://gitlab.gnome.org/GNOME/gnome-contacts/-/issues/332

Follow the change in the AppStream metadata to use the page on
apps.gnome.org, rather than the GNOME Wiki (which is going away).

Signed-off-by: Tomasz Kłoczko <kloczek@github.com>

`g_return_if_fail()`, `g_return_val_if_fail()` (and similarly
`g_return_if_reached()` are often used in GLib C to denote a
precondition or soft assertion for a specific place in the code, often
pointing to a programmer error if the condition fails.

Vala also binds to these methods, but unfortunately, they're a bit less
useful: the error message it prints only shows the "compiled" temporary
variable (e.g. `_tmp4_ != NULL`) rather than the actual value, and more
importantly, it skips some type strictness checks when compiling to C
(for example, allowing to return nothing in a function that expects a
boolean return value).

This commit avoids those macros in several ways:
- Throwing an error for unsupported code paths
- Using the `requires()` construct in Vala, which is a similar construct
  to that of GLib, but specific to Vala (but can only be used at the
  function signature level)
- For other points in the code, we fall back to `warn_if_fail()`, which
  still suffers from the problem of printing temporary variables, but at
  least doesn't fail any type checks.

Fixes: https://gitlab.gnome.org/GNOME/gnome-contacts/-/issues/340

Note that in practice these source files are all split over some static
helper libraries, but for our use case it's easiest to just ignore that
and parse them all in one go.

Fixes: https://gitlab.gnome.org/GNOME/gnome-contacts/-/issues/342

Rather than using `Adw.ActionRow`s, this commit splits out the
`ContactSheetRow` helper class into a separate file, and changes it to
use a GTK template UI file. An even bigger change is that it no longer
extends `AdwActionRow` but instead implements a custom `GtkListBoxRow`.

By implementing a custom row, we can add extra API that might be too
niche of a use case for `AdwActionRow` to expose, such as setting the
text direction on the title of a row.

For some fields such as phone numbers, we want to explicitly override
the direction to LTR, even when displaying in an system that is
configured to display as RTL.

This commit adds an extra API to set the text direction of the title
label of a contact sheet row, so we can force this behavior without
messing up the subtitle (or other child widgets) of that row.

See also https://gitlab.gnome.org/GNOME/gnome-contacts/-/merge_requests/277