Loading
Commits on Source 82
-
Felipe Borges authored
-
Scrambled 777 authored
-
Automeris naranja authored
Also: - Remove the use-underline property, because this button doesn't have any label, so the property isn't doing a thing - Remove the a11y label, because Orca also reads tooltips
-
Automeris naranja authored
- Separate the "Name" row from the others, so the feedback message can appear below this row (the feedback message is only related to the printer name, so it doesn't make sense to show below the "Driver" row) - Use .warning instead of .error style class in both "Name" and in the feedback message when the printer name is invalid - Remove the icon from the feedback text, as the latter is a transient thing, unlike CcFeedbackEntry
-
Automeris naranja authored
The icons from CcEntryFeedback aren't the same used in the mockups¹; also, they don't get recolored with @success/@error_color. Update the icons and their styles to match the mockups. ¹ https://gitlab.gnome.org/Teams/Design/settings-mockups/-/commit/28f17616e9c8e22e73287a2deaa63a265d2dab60
-
Sid authored
The binding for the visible wifi device would be removed as part of wifi adapter (the binding source) removal. So, we clear the reference to the binding during wifi adapter removal, so we don't try unbinding an invalid binding later in `on_stack_visible_child_changed_cb ()` causing a crash. Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2748
-
Automeris naranja authored
Doing so, the IDs will match the row titles, which are written in the plural form. This was missing from 431ff9ad
-
Hari Rana authored
-
Automeris naranja authored
The invalid character is something apart from the feedback message, so they need to be in quotation marks. Also, this is very useful if the invalid character is a whitespace character, for example, which will look invisible without quotation marks.
-
Automeris naranja authored
Use dialog-error-symbolic instead of dialog-warning-symbolic. CcAddUserDialog already use dialog-error-symbolic for displaying errors in the mockups¹. Also, since "Domain not found" label is an error, it needs have a proper error icon. ¹ https://gitlab.gnome.org/Teams/Design/settings-mockups/-/commit/28f17616e9c8e22e73287a2deaa63a265d2dab60
-
Martin authored
-
Felipe Borges authored
Fixes #3159
-
Automeris naranja authored
Doing so, it will be easy to find it in the C code. This was missing from https://gitlab.gnome.org/GNOME/gnome-control-center/-/commit/431ff9ad729c7aa503d3b7a178a91fba470595ab
-
Automeris naranja authored
-
Felipe Borges authored
It's not used by any widget.
-
Felipe Borges authored
Since we don't define a style for the ENROLL_STATE_NORMAL state, we were using "" as a placeholder in the ENROLL_STATE_CLASSES list, which is an empty string for gtk_widget_{add/remove}_css_class. Let's use "normal" instead and comment it as "undefined", since we don't define any css styling for it. Fixes the following criticals during fingerprint enrollment. ``` 15:25:20.6575 Gtk[307443]:CRITICAL: gtk_widget_is_ancestor: assertion 'GTK_IS_WIDGET (widget)' failed 15:25:21.6477 Gtk[307443]:CRITICAL: gtk_widget_remove_css_class: assertion 'css_class[0] != '\0'' failed 15:25:21.6477 Gtk[307443]:CRITICAL: gtk_widget_add_css_class: assertion 'css_class[0] != '\0'' failed 15:25:23.3037 Gtk[307443]:CRITICAL: gtk_widget_remove_css_class: assertion 'css_class[0] != '\0'' failed 15:25:24.0548 Gtk[307443]:CRITICAL: gtk_widget_remove_css_class: assertion 'css_class[0] != '\0'' failed 15:25:24.0549 Gtk[307443]:CRITICAL: gtk_widget_add_css_class: assertion 'css_class[0] != '\0'' failed 15:25:25.0959 Gtk[307443]:CRITICAL: gtk_widget_remove_css_class: assertion 'css_class[0] != '\0'' failed 15:25:25.4640 Gtk[307443]:CRITICAL: gtk_widget_remove_css_class: assertion 'css_class[0] != '\0'' failed 15:25:25.7319 Gtk[307443]:CRITICAL: gtk_widget_remove_css_class: assertion 'css_class[0] != '\0'' failed 15:25:26.1519 Gtk[307443]:CRITICAL: gtk_widget_remove_css_class: assertion 'css_class[0] != '\0'' failed 15:25:26.6959 Gtk[307443]:CRITICAL: gtk_widget_remove_css_class: assertion 'css_class[0] != '\0'' failed 15:25:27.3641 Gtk[307443]:CRITICAL: gtk_widget_remove_css_class: assertion 'css_class[0] != '\0'' failed 15:25:27.7800 Gtk[307443]:CRITICAL: gtk_widget_remove_css_class: assertion 'css_class[0] != '\0'' failed 15:25:28.5305 Gtk[307443]:CRITICAL: gtk_widget_remove_css_class: assertion 'css_class[0] != '\0'' failed 15:25:28.5306 Gtk[307443]:CRITICAL: gtk_widget_add_css_class: assertion 'css_class[0] != '\0'' failed 15:25:29.7042 Gtk[307443]:CRITICAL: gtk_widget_remove_css_class: assertion 'css_class[0] != '\0'' failed ``` -
Daniel Șerbănescu authored
(cherry picked from commit 2c53ae5e)
-
Sabri Ünal authored
-
Felipe Borges authored
Commit aa6c8e17 undid the changes in commit cfcea083. Fixes #3160
-
Felipe Borges authored
We were not writing the newly added shared-folders to rygel.conf. This regression was introduced in the port to AdwDialog, which won't run the "close-attempt" signal callback if AdwDialog.can_close is TRUE.
-
Quentin PAGÈS authored
-
Vasil Pupkin authored
-
Ekaterine Papava authored
-
Andy Holmes authored
Update the Microsoft 365 description line to reflect the support for email, calendar and contacts.
-
Felipe Borges authored
If built with location-services disabled (default), we keep the auto timezone toggle hidden and we forcibly disable the auto-timezone setting. org.gnome.desktop.datetime automatic-timezone If built with the location-services option enabled, we show the auto-timezone toggle. See #2959 (cherry picked from commit 021fce8c)
-
Daniel DeGrasse authored
Commit 021fce8c (datetime: Don't show Auto Timezone setting without location services) added code that unconditionally disables the "automatic-timezone" dconf key while loading the datetime panel view. Make this code conditional, so it only executes if HAVE_LOCATION_SERVICES is not defined by the compiler. Fixes #3157 Signed-off-by:
Daniel DeGrasse <daniel@degrasse.com> (cherry picked from commit 213650b5)
-
Rafael authored
-
Brage Fuglseth authored
-
Yosef Or Boczko authored
-
Vasil Pupkin authored
-
Yuri Chornoivan authored
-
Jose Riha authored
-
Luming Zh authored
-
Luming Zh authored
-
Asier Sarasua Garmendia authored
-
Jordi Mas authored
-
Danial Behzadi authored
-
Michael Catanzaro authored
Currently it looks like we crash if the permission variant is a non-null strv containing no strings. Probably fixes #3168 (cherry picked from commit fa994e08)
-
Matthijs Velsink authored
In uses of CcBackgroundPaintable, the parent GtkPicture's scale-factor is bound to that of CcBackgroundPaintable. Binding this property will always result in a property setting of scale-factor. Currently, that results in a cache update, even if the new scale-factor is the same as it was. By checking if that is actually the case, we can avoid any unwanted cache updates. (cherry picked from commit c5ddb131)
-
Matthijs Velsink authored
This avoids the situation where the user has a scale-factor other than 1, as the paintable gets constructed with scale-factor 1, which then causes another cache update once the scale-factor is set from the parent GtkPicture usually. Instead, we can just initialize the paintable with the correct scale-factor which is known from any parent widget. It will now only cause a cache update in the rare case that the scale-factor is changed while this panel is open. (cherry picked from commit 0c5f2da3)
-
Matthijs Velsink authored
Otherwise they are not available during construction and the init scale-factor other than 1 will still cause a cache update. (cherry picked from commit 60b15a41)
-
Matthijs Velsink authored
The "size" string property is only used for debugging purposes. But updating it is costly, as it uses libgnome-desktop calls on the background which may involve file IO. Therefore, we should only call update_size whenever we actually want to return it. None of the functions that can return or use the size string are currently in use, so this should not add any time anywhere. (cherry picked from commit 04ad18d1)
-
Matthijs Velsink authored
Mutter takes a key repeat interval of 0 to mean disabled, so we should limit the range to not get to 0. https://gitlab.gnome.org/GNOME/mutter/-/blob/0104fbe577594bcc7fdc965be323be08e4bd35d0/src/wayland/meta-wayland-keyboard.c#L500 Closes #2409 (cherry picked from commit 0cf22e6e)
-
Jeremy Bícha authored
The UI looks bad without it installed and it is not expected for people to not have it installed. gnome-core previously Depended on it anyway
-
Jeremy Bícha authored
-
Hugo Carvalho authored
-
Hugo Carvalho authored
-
Tim Sabsch authored
-
Baurzhan Muftakhidinov authored
-
Andika Triwidada authored
-
Sabri Ünal authored
-
Quentin PAGÈS authored
-
Changwoo Ryu authored
-
Aurimas Černius authored
-
Jordi Mas authored
-
Daniel Mustieles authored
-
François Guerraz authored
cc_display_monitor_get_mode returns NULL if the display was previously disabled, also, we already have a current_mode, a width and a height at that point, just use them! Introduced in fe045da8 (cherry picked from commit 9d8c1dea)
-
Fran Dieguez authored
-
Matthijs Velsink authored
By creating any used GnomeBG items only when we need them, it's much easier to wrap the use of GnomeBG api in async calls, which will happen in the next commit. (cherry picked from commit e3efc579)
-
Christian Hergert authored
Frames can be used on slideshows, but for years only the first image has been loaded anyways of slideshows. So we don't have to keep the frame-selective loader around. (cherry picked from commit 9903053e)
-
Christian Hergert authored
This massively speeds up loading of backgrounds and does not stall the main loop anymore. This is particularly important for the first load of the panel when thumbnails have not been generated yet. Fixes #3167 Co-Authored-By:
Matthijs Velsink <mvelsink@gnome.org> (cherry picked from commit af13ea6f)
-
Matthijs Velsink authored
Because a change in scale-factor can incur a cache update and therefore another (costly) thumbnail load, it's important to initially set the scale-factor correctly. However, if a widget does not have a root, getting its scale factor can take it from the first available monitor, which may not have the same scaling as the monitor the panel is on in a multi-monitor setup. Therefore, we should wait until the widget that created the CcBackgroundPaintable is rooted before we do anything to load thumbnails. This change also means the handling of scaling is now internal to CcBackgroundPaintable, making it more self-contained. (cherry picked from commit a9cd46ae)
-
Matthijs Velsink authored
Sometimes when opening Settings on a multi-monitor setup with different scaling, the reported scale-factor can be initially wrong. We therefore need to re-run the cache update, even though that might be running async already. Therefore, add a GCancellable to make this work properly. (cherry picked from commit 05065be1331053ab422fc6db66f264828640c6e6)
-
Felipe Borges authored
-
Jeremy Bícha authored
-
Jeremy Bícha authored
Update to upstream version '47~rc' with Debian dir 341c8b778ba47509c3887875f22c84071353fb45
-
Jeremy Bícha authored
-
Nathan Teodosio authored
The old patches hereby removed no longer applied to Gnome 47 beta.
-
Jeremy Bícha authored
-
Jeremy Bícha authored
fixes the Apps tab being blank, see LP: #2072772 comment 5 Also, there's a new law requiring parental controls to be pre-installed for computers sold in France
-
Jeremy Bícha authored
-
Jeremy Bícha authored
tagging package gnome-control-center version debian/1%47_rc-1 * tag 'debian/1%47_rc-1': (74 commits) releasing package gnome-control-center version 1:47~rc-1 Depend instead of Recommend malcontent-gui Ubuntu actually does build g-c-c with malcontent now Bring back the possilibity to unset the alternate key. New upstream release 47.rc background-paintable: Allow for concurrent cache updates background-paintable: Internally handle scale-factor background-item: Load GnomeBG thumbnails async background-item: Remove unused API from header background-item: Only create GnomeBG transiently Update Galician translation display: Fix crash introduced in fe045da8 Update Spanish translation Update Catalan translation Update Lithuanian translation Update Korean translation Update Occitan translation Update Turkish translation Update Indonesian translation ...
-
Jeremy Bícha authored
-
Jeremy Bícha authored
Gbp-Dch: Ignore
-
Jeremy Bícha authored
O is used for Output Device and A is used for Alert Sound but V isn't used
-
Jeremy Bícha authored
-
Jeremy Bícha authored