Commit bf77325d authored by Debarshi Ray's avatar Debarshi Ray

Remove Todoist and deprecate org.gnome.OnlineAccounts.Todo

During the GNOME 3.25.x / 3.26 development cycle it was decided that
Todoist doesn't fit the goals of GNOME Online Accounts [1].

The two applications that were meant to consume the Todoist provider,
GNOME Recipes [2] and To Do [3], are not part of a minimum viable GNOME
system. While they do bear the GNOME name and follow the GNOME Human
Interface Guidelines [4], they are not tightly coupled with the rest of
GNOME. eg., they don't follow the GNOME development and release
schedule. They are optional applications which often won't be
installed, and we don't want to have online accounts that don't do
anything.

Since then, Recipes has grown its own built-in Todoist support, and
To Do is expected to do the same.

[1] https://wiki.gnome.org/Projects/GnomeOnlineAccounts/Goals
[2] https://wiki.gnome.org/Apps/Recipes
[3] https://wiki.gnome.org/Apps/Todo
[4] https://developer.gnome.org/hig/stable/
parent da67970e
......@@ -71,12 +71,6 @@ useful:
http://www.slideshare.net/KuoE0/pocket-authentication-with-oauth-on-firefox-os
Todoist
-------
OAuth 2.0: https://developer.todoist.com/
Windows Live
------------
......
......@@ -285,32 +285,6 @@ if test "$enable_facebook" != "no"; then
AC_DEFINE(GOA_FACEBOOK_ENABLED, 1, [Enable Facebook data provider])
fi
# Todoist
AC_DEFINE(GOA_TODOIST_NAME, ["todoist"], [ProviderType and extension point name])
AC_ARG_ENABLE([todoist],
[AS_HELP_STRING([--enable-todoist], [Enable Todoist provider])],
[],
[enable_todoist=no])
AC_ARG_WITH(todoist-client-id,
[AS_HELP_STRING([--with-todoist-client-id], [Todoist OAuth 2.0 client id])],
[],
[])
AC_ARG_WITH(todoist-client-secret,
[AS_HELP_STRING([--with-todoist-client-secret], [Todoist client secret])],
[],
[])
if test "$with_todoist_client_id" = ""; then
with_todoist_client_id="2e41575c1dd74f98ad7cfb178e1ba3dd"
fi
if test "$with_todoist_client_secret" = ""; then
with_todoist_client_secret="3e59831ffdd64633918d19aa0a1efd2b"
fi
AC_DEFINE_UNQUOTED(GOA_TODOIST_CLIENT_ID, ["$with_todoist_client_id"], [Todoist OAuth 2.0 client id])
AC_DEFINE_UNQUOTED(GOA_TODOIST_CLIENT_SECRET, ["$with_todoist_client_secret"], [Todoist client secret])
if test "$enable_todoist" != "no"; then
AC_DEFINE(GOA_TODOIST_ENABLED, 1, [Enable Todoist data provider])
fi
# Windows Live
AC_DEFINE(GOA_WINDOWS_LIVE_NAME, ["windows_live"], [ProviderType and extension point name])
AC_ARG_ENABLE([windows-live],
......@@ -574,7 +548,6 @@ echo "
ownCloud provider: ${enable_owncloud}
Kerberos provider: ${enable_kerberos}
Facebook provider: ${enable_facebook} (OAuth 2.0, id:${with_facebook_client_id})
Todoist provider: ${enable_todoist} (OAuth 2.0, id:${with_todoist_client_id} secret:${with_todoist_client_secret})
Windows Live provider: ${enable_windows_live} (OAuth 2.0, id:${with_windows_live_client_id})
Pocket provider: ${enable_pocket} (id:${with_pocket_client_id})
Last.fm provider: ${enable_lastfm} (id:${with_lastfm_client_id} secret:${with_lastfm_client_secret})
......
......@@ -256,7 +256,9 @@
Note that the #org.gnomeOnlineAccounts.Todo interface is added or
removed from the account asynchronously.
-->
<property name="TodoDisabled" type="b" access="readwrite"/>
<property name="TodoDisabled" type="b" access="readwrite">
<annotation name="org.freedesktop.DBus.Deprecated" value="true"/>
</property>
<!-- ReadLaterDisabled:
@since: 3.12.0
......@@ -797,8 +799,12 @@
An account object implements this interface if it provides
todo-like capabilities.
The #org.gnome.OnlineAccounts.Todo interface is not used by
any account.
-->
<interface name="org.gnome.OnlineAccounts.Todo">
<annotation name="org.freedesktop.DBus.Deprecated" value="true"/>
</interface>
<!--
......
......@@ -10,7 +10,6 @@ icon_DATA = \
goa-account-owncloud.png \
goa-account-pocket.png \
goa-account-foursquare.png \
goa-account-todoist.png \
$(NULL)
EXTRA_DIST = \
......
......@@ -10,7 +10,6 @@ icon_DATA = \
goa-account-owncloud.png \
goa-account-pocket.png \
goa-account-foursquare.png \
goa-account-todoist.png \
$(NULL)
EXTRA_DIST = \
......
......@@ -10,7 +10,6 @@ icon_DATA = \
goa-account-pocket.png \
goa-account-foursquare.png \
goa-account-flickr.png \
goa-account-todoist.png \
$(NULL)
EXTRA_DIST = \
......
......@@ -10,7 +10,6 @@ icon_DATA = \
goa-account-owncloud.png \
goa-account-pocket.png \
goa-account-foursquare.png \
goa-account-todoist.png \
$(NULL)
EXTRA_DIST = \
......
......@@ -10,7 +10,6 @@ icon_DATA = \
goa-account-pocket.png \
goa-account-flickr.png \
goa-account-foursquare.png \
goa-account-todoist.png \
$(NULL)
EXTRA_DIST = \
......
......@@ -10,7 +10,6 @@ icon_DATA = \
goa-account-pocket.png \
goa-account-flickr.png \
goa-account-foursquare.png \
goa-account-todoist.png \
$(NULL)
EXTRA_DIST = \
......
......@@ -7,7 +7,6 @@ icon_data = [
'goa-account-owncloud.png',
'goa-account.png',
'goa-account-pocket.png',
'goa-account-todoist.png'
]
icon_data_256 = ['goa-account.png']
......
......@@ -216,18 +216,6 @@ config_h.set_quoted('GOA_POCKET_CLIENT_ID', pocket_client_id)
enable_pocket = get_option('pocket')
config_h.set('GOA_POCKET_ENABLED', enable_pocket)
# Todoist
config_h.set_quoted('GOA_TODOIST_NAME', 'todoist')
todoist_client_id = get_option('todoist_client_id')
config_h.set_quoted('GOA_TODOIST_CLIENT_ID', todoist_client_id)
todoist_client_secret = get_option('todoist_client_secret')
config_h.set_quoted('GOA_TODOIST_CLIENT_SECRET', todoist_client_secret)
enable_todoist = get_option('todoist')
config_h.set('GOA_TODOIST_ENABLED', enable_todoist)
# Windows Live
config_h.set_quoted('GOA_WINDOWS_LIVE_NAME', 'windows_live')
......@@ -355,11 +343,6 @@ if enable_pocket
output += ' (id:@0@)'.format(pocket_client_id)
endif
output += '\n'
output += ' Todoist provider: ' + enable_todoist.to_string()
if enable_todoist
output += ' (OAuth 2.0, id:@0@ secret:@1@)'.format(todoist_client_id, todoist_client_secret)
endif
output += '\n'
output += ' Windows Live provider: ' + enable_windows_live.to_string()
if enable_windows_live
output += ' (OAuth 2.0, id:@0@)'.format(windows_live_client_id)
......
......@@ -32,10 +32,6 @@ option('owncloud', type: 'boolean', value: true, description: 'Enable ownCloud p
option('pocket', type: 'boolean', value: true, description: 'Enable Pocket provider')
option('pocket_client_id', type: 'string', value: '16630-40b25246b56e8ad5310b2883', description: 'Pocket OAuth 2.0 client id')
option('todoist', type: 'boolean', value: false, description: 'Enable Todoist provider')
option('todoist_client_id', type: 'string', value: '2e41575c1dd74f98ad7cfb178e1ba3dd', description: 'Todoist OAuth 2.0 client id')
option('todoist_client_secret', type: 'string', value: '3e59831ffdd64633918d19aa0a1efd2b', description: 'Todoist client secret')
option('windows_live', type: 'boolean', value: true, description: 'Enable Windows Live provider')
option('windows_live_client_id', type: 'string', value: '0000000044067703', description: 'Windows Live OAuth 2.0 client id')
......
......@@ -19,7 +19,6 @@ src/goabackend/goaowncloudprovider.c
src/goabackend/goapocketprovider.c
src/goabackend/goaprovider.c
src/goabackend/goasmtpauth.c
src/goabackend/goatodoistprovider.c
src/goabackend/goautils.c
src/goabackend/goawebview.c
src/goabackend/goawindowsliveprovider.c
......
......@@ -94,7 +94,6 @@ libgoa_backend_1_0_la_SOURCES = \
goawindowsliveprovider.h goawindowsliveprovider.c \
goapocketprovider.h goapocketprovider.c \
goalastfmprovider.h goalastfmprovider.c \
goatodoistprovider.h goatodoistprovider.c \
goaobjectskeletonutils.h goaobjectskeletonutils.c \
goautils.h goautils.c \
goawebview.h goawebview.c \
......
......@@ -71,6 +71,7 @@ typedef enum
* @GOA_PROVIDER_FEATURE_PRINTERS: Network printing services (e.g. Google Cloud Print).
* @GOA_PROVIDER_FEATURE_MAPS: Maps related services (e.g. Foursquare, Facebook).
* @GOA_PROVIDER_FEATURE_MUSIC: Music related services (e.g. Vkontakte).
* @GOA_PROVIDER_FEATURE_TODO: Deprecated; currently unused.
* @GOA_PROVIDER_FEATURE_INVALID: Used for error handling. No provider
* should provide this feature.
*
......
......@@ -204,29 +204,6 @@ goa_object_skeleton_attach_maps (GoaObjectSkeleton *object,
g_clear_object (&maps);
}
void
goa_object_skeleton_attach_todo (GoaObjectSkeleton *object,
gboolean todo_enabled)
{
GoaTodo *todo = NULL;
todo = goa_object_get_todo (GOA_OBJECT (object));
if (todo_enabled)
{
if (todo == NULL)
{
todo = goa_todo_skeleton_new ();
goa_object_skeleton_set_todo (object, todo);
}
}
else
{
if (todo != NULL)
goa_object_skeleton_set_todo (object, NULL);
}
g_clear_object (&todo);
}
void
goa_object_skeleton_attach_read_later (GoaObjectSkeleton *object,
gboolean read_later_enabled)
......
......@@ -55,9 +55,6 @@ void goa_object_skeleton_attach_photos (GoaObjectSkeleton *o
void goa_object_skeleton_attach_printers (GoaObjectSkeleton *object,
gboolean printers_enabled);
void goa_object_skeleton_attach_todo (GoaObjectSkeleton *object,
gboolean todo_enabled);
void goa_object_skeleton_attach_read_later (GoaObjectSkeleton *object,
gboolean read_later_enabled);
......
......@@ -33,7 +33,6 @@
#include "goapocketprovider.h"
#include "goamediaserverprovider.h"
#include "goalastfmprovider.h"
#include "goatodoistprovider.h"
#ifdef GOA_KERBEROS_ENABLED
#include "goakerberosprovider.h"
......@@ -960,9 +959,6 @@ static struct
#ifdef GOA_LASTFM_ENABLED
{ GOA_LASTFM_NAME, goa_lastfm_provider_get_type },
#endif
#ifdef GOA_TODOIST_ENABLED
{ GOA_TODOIST_NAME, goa_todoist_provider_get_type },
#endif
#ifdef GOA_IMAP_SMTP_ENABLED
{ GOA_IMAP_SMTP_NAME, goa_imap_smtp_provider_get_type },
#endif
......
This diff is collapsed.
/* -*- mode: C; c-file-style: "gnu"; indent-tabs-mode: nil; -*- */
/*
* Copyright © 2017 Ekta Nandwani
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General
* Public License along with this library; if not, see <http://www.gnu.org/licenses/>.
*/
#if !defined (__GOA_BACKEND_INSIDE_GOA_BACKEND_H__) && !defined (GOA_BACKEND_COMPILATION)
#error "Only <goabackend/goabackend.h> can be included directly."
#endif
#ifndef __GOA_TODOIST_PROVIDER_H__
#define __GOA_TODOIST_PROVIDER_H__
#include <glib-object.h>
#include "goaoauth2provider-priv.h"
G_BEGIN_DECLS
#define GOA_TYPE_TODOIST_PROVIDER (goa_todoist_provider_get_type ())
G_DECLARE_FINAL_TYPE (GoaTodoistProvider, goa_todoist_provider, GOA, TODOIST_PROVIDER, GoaOAuth2Provider);
G_END_DECLS
#endif /* __GOA_TODOIST_PROVIDER_H__ */
\ No newline at end of file
......@@ -48,7 +48,6 @@ sources = enum_sources + files(
'goarestproxy.c',
'goasmtpauth.c',
'goasouplogger.c',
'goatodoistprovider.c',
'goautils.c',
'goawebview.c',
'goawindowsliveprovider.c',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment